Skip to content

Commit b32fb9b

Browse files
authored
fix: enable verbose for the proxy command (#241)
When log dir setting is enabled we need to also enable verbose mode otherwise the proxy command will not log anything relevant. - resolves #240
1 parent f004533 commit b32fb9b

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
## Unreleased
44

5+
### Changed
6+
7+
- the proxy command now always logs in verbose mode when the log directory is enabled
8+
59
## 0.8.1 - 2025-12-11
610

711
### Changed

src/main/kotlin/com/coder/toolbox/cli/CoderCLIManager.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -384,8 +384,7 @@ class CoderCLIManager(
384384
"--network-info-dir ${escape(context.settingsStore.networkInfoDir)}"
385385
)
386386
val proxyArgs = baseArgs + listOfNotNull(
387-
context.settingsStore.sshLogDirectory?.takeIf { it.isNotBlank() }?.let { "--log-dir" },
388-
context.settingsStore.sshLogDirectory?.takeIf { it.isNotBlank() }?.let { escape(it) },
387+
context.settingsStore.sshLogDirectory?.takeIf { it.isNotBlank() }?.let { "--log-dir ${escape(it)} -v" },
389388
if (feats.reportWorkspaceUsage) "--usage-app=jetbrains" else null,
390389
)
391390
val extraConfig = context.settingsStore.sshConfigOptions

src/test/resources/fixtures/outputs/log-dir.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# --- START CODER JETBRAINS TOOLBOX test.coder.invalid
22
Host coder-jetbrains-toolbox--owner--foo.agent1--test.coder.invalid
3-
ProxyCommand /tmp/coder-toolbox/test.coder.invalid/coder-linux-amd64 --global-config /tmp/coder-toolbox/test.coder.invalid/config --url https://test.coder.invalid ssh --stdio --network-info-dir /tmp/coder-toolbox/ssh-network-metrics --log-dir /tmp/coder-toolbox/test.coder.invalid/logs --usage-app=jetbrains owner/foo.agent1
3+
ProxyCommand /tmp/coder-toolbox/test.coder.invalid/coder-linux-amd64 --global-config /tmp/coder-toolbox/test.coder.invalid/config --url https://test.coder.invalid ssh --stdio --network-info-dir /tmp/coder-toolbox/ssh-network-metrics --log-dir /tmp/coder-toolbox/test.coder.invalid/logs -v --usage-app=jetbrains owner/foo.agent1
44
ConnectTimeout 0
55
StrictHostKeyChecking no
66
UserKnownHostsFile /dev/null

0 commit comments

Comments
 (0)