cleanup tmpdir

Author: sreya

integration/integrationtest/os.go

@@ -14,9 +14,15 @@ func TmpDir(t *testing.T) string {
 	// We use os.MkdirTemp as oposed to t.TempDir since the envbox container will
 	// chown some of the created directories here to root:root causing the cleanup
 	// function to fail once the test exits.
-	tmpdir, err := os.MkdirTemp("", strings.ReplaceAll(t.Name(), "/", "_"))
+	tmpdir, err := os.MkdirTemp(os.TempDir(), strings.ReplaceAll(t.Name(), "/", "_"))
 	require.NoError(t, err)
 	t.Logf("using tmpdir %s", tmpdir)
+	t.Cleanup(func() {
+		if !t.Failed() {
+			// Could be useful in case of test failure.
+			_ = os.RemoveAll(tmpdir)
+		}
+	})
 	return tmpdir
 }