address PR feedback re wording

Author: johnstcn

docs/env-variables.md

@@ -18,7 +18,7 @@
 | `--docker-config-base64` | `ENVBUILDER_DOCKER_CONFIG_BASE64` |  | The base64 encoded Docker config file that will be used to pull images from private container registries. When this is set, Docker configuration set via the DOCKER_CONFIG environment variable is ignored. |
 | `--fallback-image` | `ENVBUILDER_FALLBACK_IMAGE` |  | Specifies an alternative image to use when neither an image is declared in the devcontainer.json file nor a Dockerfile is present. If there's a build failure (from a faulty Dockerfile) or a misconfiguration, this image will be the substitute. Set ExitOnBuildFailure to true to halt the container if the build faces an issue. |
 | `--exit-on-build-failure` | `ENVBUILDER_EXIT_ON_BUILD_FAILURE` |  | Terminates the container upon a build failure. This is handy when preferring the FALLBACK_IMAGE in cases where no devcontainer.json or image is provided. However, it ensures that the container stops if the build process encounters an error. |
-| `--exit-on-push-failure` | `ENVBUILDER_EXIT_ON_PUSH_FAILURE` |  | ExitOnPushFailure terminates the container upon a push failure. This is useful if failure to push the built image should not block usage of the workspace. |
+| `--exit-on-push-failure` | `ENVBUILDER_EXIT_ON_PUSH_FAILURE` |  | ExitOnPushFailure terminates the container upon a push failure. This is useful if failure to push the built image should abort execution and result in an error. |
 | `--force-safe` | `ENVBUILDER_FORCE_SAFE` |  | Ignores any filesystem safety checks. This could cause serious harm to your system! This is used in cases where bypass is needed to unblock customers. |
 | `--insecure` | `ENVBUILDER_INSECURE` |  | Bypass TLS verification when cloning and pulling from container registries. |
 | `--ignore-paths` | `ENVBUILDER_IGNORE_PATHS` |  | The comma separated list of paths to ignore when building the workspace. |

options/options.go

@@ -79,8 +79,8 @@ type Options struct {
 	// container stops if the build process encounters an error.
 	ExitOnBuildFailure bool
 	// ExitOnPushFailure terminates the container upon a push failure. This is
-	// useful if failure to push the built image should not block usage
-	// of the workspace.
+	// useful if failure to push the built image should abort execution
+	// and result in an error.
 	ExitOnPushFailure bool
 	// ForceSafe ignores any filesystem safety checks. This could cause serious
 	// harm to your system! This is used in cases where bypass is needed to
@@ -313,8 +313,8 @@ func (o *Options) CLI() serpent.OptionSet {
 			Env:   WithEnvPrefix("EXIT_ON_PUSH_FAILURE"),
 			Value: serpent.BoolOf(&o.ExitOnPushFailure),
 			Description: "ExitOnPushFailure terminates the container upon a push failure. " +
-				"This is useful if failure to push the built image should not block " +
-				"usage of the workspace.",
+				"This is useful if failure to push the built image should abort execution " +
+				"and result in an error.",
 		},
 		{
 			Flag:  "force-safe",

options/testdata/options.golden

@@ -68,8 +68,8 @@ OPTIONS:
 
       --exit-on-push-failure bool, $ENVBUILDER_EXIT_ON_PUSH_FAILURE
           ExitOnPushFailure terminates the container upon a push failure. This
-          is useful if failure to push the built image should not block usage of
-          the workspace.
+          is useful if failure to push the built image should abort execution
+          and result in an error.
 
       --export-env-file string, $ENVBUILDER_EXPORT_ENV_FILE
           Optional file path to a .env file where envbuilder will dump