feat: adjust thinpack logging and option definition

Author: CH-Chang

git/git.go

@@ -54,28 +54,40 @@ func CloneRepo(ctx context.Context, logf func(string, ...any), opts CloneRepoOpt
 		return false, fmt.Errorf("parse url %q: %w", opts.RepoURL, err)
 	}
 	logf("Parsed Git URL as %q", parsed.Redacted())
-	if parsed.Hostname() == "dev.azure.com" || opts.ThinPack {
-		// Azure DevOps requires capabilities multi_ack / multi_ack_detailed,
-		// which are not fully implemented and by default are included in
-		// transport.UnsupportedCapabilities.
-		//
-		// The initial clone operations require a full download of the repository,
-		// and therefore those unsupported capabilities are not as crucial, so
-		// by removing them from that list allows for the first clone to work
-		// successfully.
-		//
-		// Additional fetches will yield issues, therefore work always from a clean
-		// clone until those capabilities are fully supported.
-		//
-		// New commits and pushes against a remote worked without any issues.
-		// See: https://github.com/go-git/go-git/issues/64
-		//
-		// This is knowingly not safe to call in parallel, but it seemed
-		// like the least-janky place to add a super janky hack.
+
+	thinPack := true
+
+	if !opts.ThinPack {
+		thinPack = false
+		logf("ThinPack options is false, Marking thin-pack as unsupported")
+	} else {
+		if parsed.Hostname() == "dev.azure.com" {
+			// Azure DevOps requires capabilities multi_ack / multi_ack_detailed,
+			// which are not fully implemented and by default are included in
+			// transport.UnsupportedCapabilities.
+			//
+			// The initial clone operations require a full download of the repository,
+			// and therefore those unsupported capabilities are not as crucial, so
+			// by removing them from that list allows for the first clone to work
+			// successfully.
+			//
+			// Additional fetches will yield issues, therefore work always from a clean
+			// clone until those capabilities are fully supported.
+			//
+			// New commits and pushes against a remote worked without any issues.
+			// See: https://github.com/go-git/go-git/issues/64
+			//
+			// This is knowingly not safe to call in parallel, but it seemed
+			// like the least-janky place to add a super janky hack.
+			thinPack = false
+			logf("Workaround for Azure DevOps: marking thin-pack as unsupported")
+		}
+	}
+
+	if !thinPack {
 		transport.UnsupportedCapabilities = []capability.Capability{
 			capability.ThinPack,
 		}
-		logf("Workaround for Azure DevOps: marking thin-pack as unsupported")
 	}
 
 	err = opts.Storage.MkdirAll(opts.Path, 0o755)

options/options.go

@@ -381,7 +381,8 @@ func (o *Options) CLI() serpent.OptionSet {
 			Flag:        "git-clone-thinpack",
 			Env:         WithEnvPrefix("GIT_CLONE_THINPACK"),
 			Value:       serpent.BoolOf(&o.GitCloneThinPack),
-			Description: "Clone with thin pack compabilities.",
+			Default:     "true",
+			Description: "Git clone with thin pack compatibility enable.",
 		},
 		{
 			Flag:        "git-username",

options/options_test.go

@@ -70,7 +70,7 @@ func TestEnvOptionParsing(t *testing.T) {
 			t.Setenv(options.WithEnvPrefix("GIT_CLONE_THINPACK"), "")
 			o := runCLI()
 			require.False(t, o.GitCloneSingleBranch)
-			require.False(t, o.GitCloneThinPack)
+			require.True(t, o.GitCloneThinPack)
 		})
 	})
 }

options/testdata/options.golden

@@ -100,7 +100,7 @@ OPTIONS:
           Clone only a single branch of the Git repository.
 
       --git-clone-thinpack bool, $ENVBUILDER_GIT_CLONE_THINPACK
-          Clone with thin pack compabilities.
+          Git clone with thin pack compatibility enable.
 
       --git-http-proxy-url string, $ENVBUILDER_GIT_HTTP_PROXY_URL
           The URL for the HTTP proxy. This is optional.