Upgrade to go 1.24, fix build problems

Author: deansheather

.github/workflows/enterprise-release.yaml

@@ -30,7 +30,8 @@ jobs:
       # Necessary for Docker manifest
       DOCKER_CLI_EXPERIMENTAL: "enabled"
     steps:
-      - uses: actions/checkout@v3
+      - name: Checkout
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
@@ -43,15 +44,16 @@ jobs:
         run: git fetch --tags --force
 
       - name: Docker Login
-        uses: docker/login-action@v2
+        uses: docker/login-action@v3
         with:
           registry: ghcr.io
           username: ${{ github.actor }}
           password: ${{ secrets.GITHUB_TOKEN }}
 
-      - uses: actions/setup-go@v3
+      - name: Install Go
+        uses: actions/setup-go@v5
         with:
-          go-version: "^1.21.9"
+          go-version: "^1.24.5"
 
       - name: Build binaries
         run: |

.github/workflows/enterprise.yaml

@@ -34,10 +34,13 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 20
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-go@v3
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Install Go
+        uses: actions/setup-go@v5
         with:
-          go-version: "^1.21.9"
+          go-version: "^1.24.5"
 
       - name: Echo Go Cache Paths
         id: go-cache-paths
@@ -46,13 +49,13 @@ jobs:
           echo "::set-output name=go-mod::$(go env GOMODCACHE)"
 
       - name: Go Build Cache
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: ${{ steps.go-cache-paths.outputs.go-build }}
           key: ${{ runner.os }}-go-build-${{ hashFiles('**/go.**', '**.go') }}
 
       - name: Go Mod Cache
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: ${{ steps.go-cache-paths.outputs.go-mod }}
           key: ${{ runner.os }}-go-mod-${{ hashFiles('**/go.sum') }}

.github/workflows/gen.yml renamed to .github/workflows/gen.yaml

@@ -31,7 +31,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Run make
         run: make

.github/workflows/quality.yml renamed to .github/workflows/quality.yaml

@@ -31,12 +31,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Install Go
-        uses: actions/setup-go@v2
+        uses: actions/setup-go@v5
         with:
-          go-version: "^1.21.9"
+          go-version: "^1.24.5"
 
       - name: Run make fmt/go
         run: make fmt/go
@@ -49,12 +49,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Install Node.js
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v4
         with:
-          node-version: "18"
+          node-version: "22"
 
       - name: Install prettier
         run: npm install --global prettier
@@ -70,17 +70,16 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Install Go
-        uses: actions/setup-go@v2
+        uses: actions/setup-go@v5
         with:
-          go-version: "^1.21.9"
+          go-version: "^1.24.5"
 
       - name: Install golangci-lint
         run: |
-          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh \
-            | sh -s -- -b $(go env GOPATH)/bin v1.57.2
+          go install github.com/golangci/golangci-lint/cmd/[email protected]
 
       # Linting needs to be done on each build variation of GOOS.
       - name: Run make lint/go/linux
@@ -95,10 +94,13 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 20
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-go@v3
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Install Go
+        uses: actions/setup-go@v5
         with:
-          go-version: "^1.21.9"
+          go-version: "^1.24.5"
 
       - name: Echo Go Cache Paths
         id: go-cache-paths
@@ -107,13 +109,13 @@ jobs:
           echo "::set-output name=go-mod::$(go env GOMODCACHE)"
 
       - name: Go Build Cache
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: ${{ steps.go-cache-paths.outputs.go-build }}
           key: ${{ runner.os }}-go-build-${{ hashFiles('**/go.**', '**.go') }}
 
       - name: Go Mod Cache
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: ${{ steps.go-cache-paths.outputs.go-mod }}
           key: ${{ runner.os }}-go-mod-${{ hashFiles('**/go.sum') }}
@@ -126,7 +128,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Run make lint/c
         run: make lint/c
@@ -144,7 +146,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Install shellcheck
         run: sudo apt install -y shellcheck

.golangci.yaml

@@ -5,12 +5,19 @@
 # - removed testpackage
 
 linters-settings:
+  dupl:
+    # goal: 100
+    threshold: 412
+
   exhaustruct:
     include:
       # Gradually extend to cover more of the codebase.
       - 'httpmw\.\w+'
+      # We want to enforce all values are specified when inserting or updating
+      # a database row. Ref: #993
+      - 'github.com/coder/coder/v2/coderd/database\.[^G][^e][^t]\w+Params'
   gocognit:
-    min-complexity: 46 # Min code complexity (def 30).
+    min-complexity: 300
 
   goconst:
     min-len: 4 # Min length of string consts (def 3).
@@ -20,30 +27,19 @@ linters-settings:
     enabled-checks:
       # - appendAssign
       # - appendCombine
-      #- argOrder
       # - assignOp
       # - badCall
-      #- badCond
       - badLock
       - badRegexp
       - boolExprSimplify
       # - builtinShadow
       - builtinShadowDecl
-      #- captLocal
-      #- caseOrder
-      #- codegenComment
       # - commentedOutCode
       - commentedOutImport
-      #- commentFormatting
-      #- defaultCaseOrder
       - deferUnlambda
       # - deprecatedComment
       # - docStub
-      #- dupArg
-      #- dupBranchBody
-      #- dupCase
       - dupImport
-      #- dupSubExpr
       # - elseif
       - emptyFallthrough
       # - emptyStringTest
@@ -52,64 +48,47 @@ linters-settings:
       # - exitAfterDefer
       # - exposedSyncMutex
       # - filepathJoin
-      #- flagDeref
-      #- flagName
       - hexLiteral
       # - httpNoBody
       # - hugeParam
       # - ifElseChain
       # - importShadow
       - indexAlloc
       - initClause
-      #- mapKey
       - methodExprCall
       # - nestingReduce
-      #- newDeref
       - nilValReturn
       # - octalLiteral
-      #- offBy1
       # - paramTypeCombine
       # - preferStringWriter
       # - preferWriteByte
       # - ptrToRefParam
       # - rangeExprCopy
       # - rangeValCopy
-      #- regexpMust
       - regexpPattern
       # - regexpSimplify
-      #- ruleguard
-      #- singleCaseSwitch
-      #- sloppyLen
+      # - ruleguard
       # - sloppyReassign
-      #- sloppyTypeAssert
       - sortSlice
       - sprintfQuotedString
       - sqlQuery
       # - stringConcatSimplify
       # - stringXbytes
       # - suspiciousSorting
-      #- switchTrue
       - truncateCmp
       - typeAssertChain
       # - typeDefFirst
-      #- typeSwitchVar
       # - typeUnparen
-      #- underef
       # - unlabelStmt
       # - unlambda
       # - unnamedResult
       # - unnecessaryBlock
       # - unnecessaryDefer
       # - unslice
-      #- valSwap
       - weakCond
       # - whyNoLint
       # - wrapperFunc
       # - yodaStyleExpr
-    #settings:
-    #  ruleguard:
-    #    failOn: all
-    #    rules: "${configDir}/scripts/rules.go"
 
   staticcheck:
     # https://staticcheck.io/docs/options#checks
@@ -121,10 +100,6 @@ linters-settings:
   goimports:
     local-prefixes: coder.com,cdr.dev,go.coder.com,github.com/cdr,github.com/coder
 
-  gocyclo:
-    # goal: 30
-    min-complexity: 47
-
   importas:
     no-unaliased: true
 
@@ -134,7 +109,8 @@ linters-settings:
       - trialer
 
   nestif:
-    min-complexity: 4 # Min complexity of if statements (def 5, goal 4)
+    # goal: 10
+    min-complexity: 20
 
   revive:
     # see https://github.com/mgechev/revive#available-rules for details.
@@ -174,8 +150,6 @@ linters-settings:
       - name: modifies-value-receiver
       - name: package-comments
       - name: range
-      - name: range-val-address
-      - name: range-val-in-closure
       - name: receiver-naming
       - name: redefines-builtin-id
       - name: string-of-int
@@ -189,11 +163,21 @@ linters-settings:
       - name: unnecessary-stmt
       - name: unreachable-code
       - name: unused-parameter
+        exclude: "**/*_test.go"
       - name: unused-receiver
       - name: var-declaration
       - name: var-naming
       - name: waitgroup-by-value
 
+  # irrelevant as of Go v1.22: https://go.dev/blog/loopvar-preview
+  govet:
+    disable:
+      - loopclosure
+  gosec:
+    excludes:
+      # Implicit memory aliasing of items from a range statement (irrelevant as of Go v1.22)
+      - G601
+
 issues:
   # Rules listed here: https://github.com/securego/gosec#available-rules
   exclude-rules:
@@ -203,15 +187,6 @@ issues:
         - errcheck
         - forcetypeassert
         - exhaustruct # This is unhelpful in tests.
-    - path: scripts/*
-      linters:
-        - exhaustruct
-
-  exclude-files:
-    - scripts/rules.go
-
-  exclude-dirs:
-    - node_modules
 
   fix: true
   max-issues-per-linter: 0
@@ -233,10 +208,14 @@ linters:
     - errname
     - errorlint
     - exhaustruct
-    - exportloopref
     - forcetypeassert
     - gocritic
-    - gocyclo
+    # gocyclo is may be useful in the future when we start caring
+    # about testing complexity, but for the time being we should
+    # create a good culture around cognitive complexity.
+    # - gocyclo
+    - gocognit
+    - nestif
     - goimports
     - gomodguard
     - gosec
@@ -260,15 +239,9 @@ linters:
 
     - staticcheck
     - tenv
-    # In Go, it's possible for a package to test it's internal functionality
-    # without testing any exported functions. This is enabled to promote
-    # decomposing a package before testing it's internals. A function caller
-    # should be able to test most of the functionality from exported functions.
-    #
-    # There are edge-cases to this rule, but they should be carefully considered
-    # to avoid structural inconsistency.
-    #- testpackage
+    # - testpackage
     - tparallel
     - typecheck
     - unconvert
     - unused
+    - dupl