Skip to content

Commit f8f1b4b

Browse files
committed
add suggestions from review
1 parent a5c3190 commit f8f1b4b

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

images/base/ubuntu.Dockerfile

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,16 @@ RUN apt-get update && \
3737
unzip \
3838
vim \
3939
wget \
40-
rsync
40+
rsync && \
41+
rm -rf /var/lib/apt/lists/*
4142

4243
# Compat: on non-armv7 architectures, install `software-properties-common`
43-
RUN [[ "$(dpkg --print-architecture)" != "armhf" ]] && apt-get install --yes software-properties-common || echo "WARN: Skipping software-properties-common installation on armhf"
44+
RUN [[ "$(dpkg --print-architecture)" != "armhf" ]] && \
45+
( \
46+
apt-get update && \
47+
apt-get install --yes software-properties-common && \
48+
rm -rf /var/lib/apt/lists/* \
49+
) || echo "WARN: Skipping software-properties-common installation on armhf"
4450

4551
# Install latest Git using their official PPA
4652
# Note: due to a dependency issue with the armv7 `software-properties-common` package,

0 commit comments

Comments
 (0)