fix: force CLI manager to use user settings

CLIManager can be created with default settings (simplifies testing),
among which the ssh wildcard config is enabled. But in reality the
config can be disabled by the user.

Author: fioan89

src/main/kotlin/com/coder/gateway/cli/CoderCLIManager.kt

@@ -12,7 +12,6 @@ import com.coder.gateway.sdk.v2.models.User
 import com.coder.gateway.sdk.v2.models.Workspace
 import com.coder.gateway.sdk.v2.models.WorkspaceAgent
 import com.coder.gateway.settings.CoderSettings
-import com.coder.gateway.settings.CoderSettingsState
 import com.coder.gateway.util.CoderHostnameVerifier
 import com.coder.gateway.util.DialogUi
 import com.coder.gateway.util.InvalidVersionException
@@ -129,7 +128,7 @@ class CoderCLIManager(
     // The URL of the deployment this CLI is for.
     private val deploymentURL: URL,
     // Plugin configuration.
-    private val settings: CoderSettings = CoderSettings(CoderSettingsState()),
+    private val settings: CoderSettings,
     // If the binary directory is not writable, this can be used to force the
     // manager to download to the data directory instead.
     private val forceDownloadToData: Boolean = false,

src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspaceProjectIDEStepView.kt

@@ -237,7 +237,7 @@ class CoderWorkspaceProjectIDEStepView(
                                         IDECellRenderer(CoderGatewayBundle.message("gateway.connector.view.coder.connect-ssh"))
                                     }
                                 val executor = createRemoteExecutor(
-                                    CoderCLIManager(data.client.url).getBackgroundHostName(
+                                    CoderCLIManager(data.client.url, settings).getBackgroundHostName(
                                         data.workspace,
                                         data.client.me,
                                         data.agent
@@ -470,7 +470,11 @@ class CoderWorkspaceProjectIDEStepView(
     override fun data(): WorkspaceProjectIDE = withoutNull(cbIDE.selectedItem, state) { selectedIDE, state ->
         selectedIDE.withWorkspaceProject(
             name = CoderCLIManager.getWorkspaceParts(state.workspace, state.agent),
-            hostname = CoderCLIManager(state.client.url).getHostName(state.workspace, state.client.me, state.agent),
+            hostname = CoderCLIManager(state.client.url, settings).getHostName(
+                state.workspace,
+                state.client.me,
+                state.agent
+            ),
             projectPath = tfProject.text,
             deploymentURL = state.client.url,
         )

src/test/kotlin/com/coder/gateway/cli/CoderCLIManagerTest.kt

@@ -106,7 +106,7 @@ internal class CoderCLIManagerTest {
     @Test
     fun testServerInternalError() {
         val (srv, url) = mockServer(HttpURLConnection.HTTP_INTERNAL_ERROR)
-        val ccm = CoderCLIManager(url)
+        val ccm = CoderCLIManager(url, CoderSettings(CoderSettingsState()))
 
         val ex =
             assertFailsWith(