fix: show all Coder workspaces in picker regardless of status

- Remove filterRunning parameter from listWorkspaces() - return all statuses
- Show status in dropdown options (e.g., 'my-workspace (template) • stopped')
- Change empty state text from 'No running workspaces' to 'No workspaces found'
- Make coder controls container w-fit instead of full width

ensureReady() already handles starting stopped workspaces, so users should
be able to see and select them in the existing workspace picker.

Addresses Codex review comment on PR #1617.

Author: ethanndickson

src/browser/components/ChatInput/CoderControls.tsx

@@ -184,7 +184,7 @@ export function CoderControls(props: CoderControlsProps) {
       {enabled && (
         <div
           className={cn(
-            "flex rounded-md border",
+            "flex w-fit rounded-md border",
             hasError ? "border-red-500" : "border-border-medium"
           )}
           data-testid="coder-controls-inner"
@@ -300,13 +300,11 @@ export function CoderControls(props: CoderControlsProps) {
                   className="bg-bg-dark text-foreground border-border-medium focus:border-accent h-7 w-[180px] rounded-md border px-2 text-sm focus:outline-none disabled:opacity-50"
                   data-testid="coder-workspace-select"
                 >
-                  {existingWorkspaces.length === 0 && (
-                    <option value="">No running workspaces</option>
-                  )}
+                  {existingWorkspaces.length === 0 && <option value="">No workspaces found</option>}
                   {existingWorkspaces.length > 0 && <option value="">Select workspace...</option>}
                   {existingWorkspaces.map((w) => (
                     <option key={w.name} value={w.name}>
-                      {w.name} ({w.templateName})
+                      {w.name} ({w.templateName}) • {w.status}
                     </option>
                   ))}
                 </select>

src/node/services/coderService.test.ts

@@ -1,7 +1,11 @@
 import { EventEmitter } from "events";
 import { Readable } from "stream";
-import { describe, it, expect, vi, beforeEach, afterEach } from "bun:test";
+import { describe, it, expect, vi, beforeEach, afterEach, spyOn } from "bun:test";
 import { CoderService, compareVersions } from "./coderService";
+import * as childProcess from "child_process";
+
+// eslint-disable-next-line @typescript-eslint/no-empty-function
+const noop = () => {};
 
 function mockExecOk(stdout: string, stderr = ""): void {
   mockExecAsync.mockReturnValue({
@@ -17,6 +21,12 @@ function mockExecError(error: Error): void {
   });
 }
 
+/**
+ * Mock spawn for streaming createWorkspace() tests.
+ * Uses spyOn instead of vi.mock to avoid polluting other test files.
+ */
+let spawnSpy: ReturnType<typeof spyOn<typeof childProcess, "spawn">> | null = null;
+
 function mockCoderCommandResult(options: {
   stdout?: string;
   stderr?: string;
@@ -26,7 +36,7 @@ function mockCoderCommandResult(options: {
   const stderr = Readable.from(options.stderr ? [Buffer.from(options.stderr)] : []);
   const events = new EventEmitter();
 
-  mockSpawn.mockReturnValue({
+  spawnSpy?.mockReturnValue({
     stdout,
     stderr,
     exitCode: null,
@@ -39,19 +49,8 @@ function mockCoderCommandResult(options: {
   // Emit close after handlers are attached.
   setTimeout(() => events.emit("close", options.exitCode), 0);
 }
-// eslint-disable-next-line @typescript-eslint/no-empty-function
-const noop = () => {};
-
-// Mock execAsync
 
-// Mock spawn for streaming createWorkspace()
-void vi.mock("child_process", () => ({
-  spawn: vi.fn(),
-}));
-
-import { spawn } from "child_process";
-
-const mockSpawn = spawn as ReturnType<typeof vi.fn>;
+// Mock execAsync (this is safe - it's our own module, not a Node.js built-in)
 void vi.mock("@/node/utils/disposableExec", () => ({
   execAsync: vi.fn(),
 }));
@@ -67,10 +66,14 @@ describe("CoderService", () => {
   beforeEach(() => {
     service = new CoderService();
     vi.clearAllMocks();
+    // Set up spawn spy for tests that use mockCoderCommandResult
+    spawnSpy = spyOn(childProcess, "spawn");
   });
 
   afterEach(() => {
     service.clearCache();
+    spawnSpy?.mockRestore();
+    spawnSpy = null;
   });
 
   describe("getCoderInfo", () => {
@@ -245,42 +248,24 @@ describe("CoderService", () => {
   });
 
   describe("listWorkspaces", () => {
-    it("returns only running workspaces by default", async () => {
+    it("returns all workspaces regardless of status", async () => {
       mockExecAsync.mockReturnValue({
         result: Promise.resolve({
           stdout: JSON.stringify([
             { name: "ws-1", template_name: "t1", latest_build: { status: "running" } },
             { name: "ws-2", template_name: "t2", latest_build: { status: "stopped" } },
-            { name: "ws-3", template_name: "t3", latest_build: { status: "running" } },
+            { name: "ws-3", template_name: "t3", latest_build: { status: "starting" } },
           ]),
         }),
         [Symbol.dispose]: noop,
       });
 
       const workspaces = await service.listWorkspaces();
 
-      expect(workspaces).toEqual([
-        { name: "ws-1", templateName: "t1", status: "running" },
-        { name: "ws-3", templateName: "t3", status: "running" },
-      ]);
-    });
-
-    it("returns all workspaces when filterRunning is false", async () => {
-      mockExecAsync.mockReturnValue({
-        result: Promise.resolve({
-          stdout: JSON.stringify([
-            { name: "ws-1", template_name: "t1", latest_build: { status: "running" } },
-            { name: "ws-2", template_name: "t2", latest_build: { status: "stopped" } },
-          ]),
-        }),
-        [Symbol.dispose]: noop,
-      });
-
-      const workspaces = await service.listWorkspaces(false);
-
       expect(workspaces).toEqual([
         { name: "ws-1", templateName: "t1", status: "running" },
         { name: "ws-2", templateName: "t2", status: "stopped" },
+        { name: "ws-3", templateName: "t3", status: "starting" },
       ]);
     });
 
@@ -483,7 +468,7 @@ describe("CoderService", () => {
       const stderr = Readable.from([Buffer.from("err-1\n")]);
       const events = new EventEmitter();
 
-      mockSpawn.mockReturnValue({
+      spawnSpy!.mockReturnValue({
         stdout,
         stderr,
         kill: vi.fn(),
@@ -498,7 +483,7 @@ describe("CoderService", () => {
         lines.push(line);
       }
 
-      expect(mockSpawn).toHaveBeenCalledWith(
+      expect(spawnSpy).toHaveBeenCalledWith(
         "coder",
         ["create", "my-workspace", "-t", "my-template", "--yes"],
         { stdio: ["ignore", "pipe", "pipe"] }
@@ -517,7 +502,7 @@ describe("CoderService", () => {
       const stderr = Readable.from([]);
       const events = new EventEmitter();
 
-      mockSpawn.mockReturnValue({
+      spawnSpy!.mockReturnValue({
         stdout,
         stderr,
         kill: vi.fn(),
@@ -530,7 +515,7 @@ describe("CoderService", () => {
         // drain
       }
 
-      expect(mockSpawn).toHaveBeenCalledWith(
+      expect(spawnSpy).toHaveBeenCalledWith(
         "coder",
         ["create", "ws", "-t", "tmpl", "--yes", "--preset", "preset"],
         { stdio: ["ignore", "pipe", "pipe"] }
@@ -549,7 +534,7 @@ describe("CoderService", () => {
       const stderr = Readable.from([]);
       const events = new EventEmitter();
 
-      mockSpawn.mockReturnValue({
+      spawnSpy!.mockReturnValue({
         stdout,
         stderr,
         kill: vi.fn(),
@@ -562,7 +547,7 @@ describe("CoderService", () => {
         // drain
       }
 
-      expect(mockSpawn).toHaveBeenCalledWith(
+      expect(spawnSpy).toHaveBeenCalledWith(
         "coder",
         [
           "create",
@@ -587,7 +572,7 @@ describe("CoderService", () => {
       const stderr = Readable.from([]);
       const events = new EventEmitter();
 
-      mockSpawn.mockReturnValue({
+      spawnSpy!.mockReturnValue({
         stdout,
         stderr,
         kill: vi.fn(),

src/node/services/coderService.ts

@@ -523,9 +523,9 @@ export class CoderService {
   }
 
   /**
-   * List Coder workspaces. Only returns "running" workspaces by default.
+   * List Coder workspaces (all statuses).
    */
-  async listWorkspaces(filterRunning = true): Promise<CoderWorkspace[]> {
+  async listWorkspaces(): Promise<CoderWorkspace[]> {
     // Derive known statuses from schema to avoid duplication and prevent ORPC validation errors
     const KNOWN_STATUSES = new Set<string>(CoderWorkspaceStatusSchema.options);
 
@@ -546,19 +546,14 @@ export class CoderService {
         };
       }>;
 
-      // Filter to known statuses first to avoid ORPC schema validation failures
-      const mapped = workspaces
+      // Filter to known statuses to avoid ORPC schema validation failures
+      return workspaces
         .filter((w) => KNOWN_STATUSES.has(w.latest_build.status))
         .map((w) => ({
           name: w.name,
           templateName: w.template_name,
           status: w.latest_build.status as CoderWorkspaceStatus,
         }));
-
-      if (filterRunning) {
-        return mapped.filter((w) => w.status === "running");
-      }
-      return mapped;
     } catch (error) {
       // Common user state: Coder CLI installed but not configured/logged in.
       // Don't spam error logs for UI list calls.