🤖 refactor: remove generic links, keep only PR badge (#1658)

## Summary

Removes the generic link detection/dropdown feature, keeping only the PR
status badge in the workspace header.

## Changes

**Removed:**
- `LinksDropdown` component (showed chat-extracted URLs)
- Generic link detection from `StreamingMessageAggregator`
- `useWorkspaceLinks` hook from `WorkspaceStore`
- `GenericLink` type, `extractUrls`, `categorizeUrl`, `deduplicateLinks`
utilities
- Link detection test files

**Simplified:**
- `WorkspaceLinks` now only renders `PRLinkBadge`
- `links.ts` now only contains PR-related types (`GitHubPRLink`,
`GitHubPRStatus`)

## PR badge behavior (unchanged)

The PR badge is detected from the workspace's current branch via `gh pr
view` - not from chat content.

---
_Generated with `mux` • Model: `anthropic:claude-opus-4-5` • Thinking:
`high` • Cost: `$49.60`_

Author: ammar-agent

src/browser/components/LinksDropdown.tsx

@@ -1,42 +1,21 @@
 /**
- * Component to display detected links in the workspace header.
- * Shows:
- * - PR badge: from branch-based detection (via `gh pr view`)
- * - Links dropdown: from chat-extracted links
+ * Component to display the PR badge in the workspace header.
+ * PR is detected from the workspace's current branch via `gh pr view`.
  */
 
-import { useWorkspaceLinks } from "@/browser/stores/WorkspaceStore";
 import { useWorkspacePR } from "@/browser/stores/PRStatusStore";
-import type { GenericLink } from "@/common/types/links";
 import { PRLinkBadge } from "./PRLinkBadge";
-import { LinksDropdown } from "./LinksDropdown";
 
 interface WorkspaceLinksProps {
   workspaceId: string;
 }
 
 export function WorkspaceLinks({ workspaceId }: WorkspaceLinksProps) {
-  // Get links extracted from chat (for dropdown)
-  const { detectedLinks } = useWorkspaceLinks(workspaceId);
-
-  // Get PR for this workspace's branch (not from chat)
   const workspacePR = useWorkspacePR(workspaceId);
 
-  // Filter out generic links (non-PR) for dropdown
-  const genericLinks = detectedLinks.filter((link): link is GenericLink => link.type === "generic");
-
-  // Don't render anything if no PR and no links
-  if (!workspacePR && genericLinks.length === 0) {
+  if (!workspacePR) {
     return null;
   }
 
-  return (
-    <div className="flex items-center gap-1">
-      {/* Show the workspace's PR badge (from branch detection) */}
-      {workspacePR && <PRLinkBadge prLink={workspacePR} />}
-
-      {/* Generic links dropdown (from chat) */}
-      {genericLinks.length > 0 && <LinksDropdown links={genericLinks} />}
-    </div>
-  );
+  return <PRLinkBadge prLink={workspacePR} />;
 }

src/browser/components/WorkspaceLinks.tsx

@@ -5,7 +5,6 @@ import type { WorkspaceChatMessage, WorkspaceStatsSnapshot } from "@/common/orpc
 import type { RouterClient } from "@orpc/server";
 import type { AppRouter } from "@/node/orpc/router";
 import type { TodoItem } from "@/common/types/tools";
-import type { DetectedLink } from "@/common/types/links";
 import { applyWorkspaceChatEventToAggregator } from "@/browser/utils/messages/applyWorkspaceChatEventToAggregator";
 import { StreamingMessageAggregator } from "@/browser/utils/messages/StreamingMessageAggregator";
 import { updatePersistedState } from "@/browser/hooks/usePersistedState";
@@ -60,8 +59,6 @@ export interface WorkspaceState {
   // Live streaming stats (updated on each stream-delta)
   streamingTokenCount: number | undefined;
   streamingTPS: number | undefined;
-  // Detected links from chat content (generic URLs for links dropdown)
-  detectedLinks: DetectedLink[];
 }
 
 /**
@@ -871,7 +868,6 @@ export class WorkspaceStore {
         pendingCompactionModel: aggregator.getPendingCompactionModel(),
         streamingTokenCount,
         streamingTPS,
-        detectedLinks: aggregator.getDetectedLinks(),
       };
     });
   }
@@ -1873,46 +1869,6 @@ export function useWorkspaceSidebarState(workspaceId: string): WorkspaceSidebarS
   );
 }
 
-/**
- * State for detected links in a workspace (for the links dropdown).
- * PR badge uses branch-based detection via useWorkspacePR instead.
- */
-export interface WorkspaceLinksState {
-  detectedLinks: DetectedLink[];
-}
-
-// Cache for useWorkspaceLinks to return stable references
-const workspaceLinksCache = new Map<string, WorkspaceLinksState>();
-
-/**
- * Hook to get detected links from a workspace.
- * Separate from sidebar state to avoid re-renders on message changes.
- * Returns cached references to avoid triggering infinite render loops.
- */
-export function useWorkspaceLinks(workspaceId: string): WorkspaceLinksState {
-  const store = getStoreInstance();
-
-  return useSyncExternalStore(
-    (listener) => store.subscribeKey(workspaceId, listener),
-    () => {
-      const state = store.getWorkspaceState(workspaceId);
-      const existing = workspaceLinksCache.get(workspaceId);
-
-      // Return same reference if nothing meaningful changed
-      if (existing && existing.detectedLinks === state.detectedLinks) {
-        return existing;
-      }
-
-      // Create new state and cache it
-      const newState: WorkspaceLinksState = {
-        detectedLinks: state.detectedLinks,
-      };
-      workspaceLinksCache.set(workspaceId, newState);
-      return newState;
-    }
-  );
-}
-
 /**
  * Hook to get UI-only live stdout/stderr for a running bash tool call.
  */

src/browser/stores/WorkspaceStore.ts

@@ -1,7 +1,8 @@
 /**
- * PR link badge and links dropdown stories
+ * PR status badge stories
  *
  * Shows various PR status states in the workspace header.
+ * PR is detected from the workspace's current branch via `gh pr view`.
  */
 
 import { appMeta, AppWithMocks, type AppStory } from "./meta.js";