🤖 refactor: unify ancestor traversal in TaskService

Author: ammar-agent

src/node/services/taskService.ts

@@ -219,6 +219,25 @@ function buildParentAwaitSystemInstructions(activeTaskIds: string[]): string {
     "Once all are completed, write your final response integrating their reports."
   );
 }
+
+function* iterateAncestorWorkspaceIds(
+  parentById: Map<string, string>,
+  taskId: string
+): Generator<string, void> {
+  let current = taskId;
+  for (let i = 0; i < 32; i++) {
+    const parent = parentById.get(current);
+    if (!parent) {
+      return;
+    }
+    yield parent;
+    current = parent;
+  }
+
+  throw new Error(
+    `iterateAncestorWorkspaceIds: possible parentWorkspaceId cycle starting at ${taskId}`
+  );
+}
 function getIsoNow(): string {
   return new Date().toISOString();
 }
@@ -1374,17 +1393,13 @@ export class TaskService {
     ancestorWorkspaceId: string,
     taskId: string
   ): boolean {
-    let current = taskId;
-    for (let i = 0; i < 32; i++) {
-      const parent = parentById.get(current);
-      if (!parent) return false;
-      if (parent === ancestorWorkspaceId) return true;
-      current = parent;
+    for (const parent of iterateAncestorWorkspaceIds(parentById, taskId)) {
+      if (parent === ancestorWorkspaceId) {
+        return true;
+      }
     }
 
-    throw new Error(
-      `isDescendantAgentTaskUsingParentById: possible parentWorkspaceId cycle starting at ${taskId}`
-    );
+    return false;
   }
 
   // --- Internal orchestration ---
@@ -1393,19 +1408,7 @@ export class TaskService {
     parentById: Map<string, string>,
     taskId: string
   ): string[] {
-    const ancestors: string[] = [];
-
-    let current = taskId;
-    for (let i = 0; i < 32; i++) {
-      const parent = parentById.get(current);
-      if (!parent) return ancestors;
-      ancestors.push(parent);
-      current = parent;
-    }
-
-    throw new Error(
-      `listAncestorWorkspaceIdsUsingParentById: possible parentWorkspaceId cycle starting at ${taskId}`
-    );
+    return [...iterateAncestorWorkspaceIds(parentById, taskId)];
   }
 
   private listAgentTaskWorkspaces(