handle unknown values in dockerdata

Author: Emyrk

preview_test.go

@@ -130,35 +130,34 @@ func Test_Extract(t *testing.T) {
 			},
 		},
 		{
-			name:    "external docker resource",
-			dir:     "dockerdata",
-			expTags: map[string]string{"qux": "quux"},
-			unknownTags: []string{
-				"foo", "bar",
+			name: "external docker resource without plan data",
+			dir:  "dockerdata",
+			expTags: map[string]string{
+				"qux":    "quux",
+				"ubuntu": "0000000000000000000000000000000000000000000000000000000000000000",
+				"centos": "0000000000000000000000000000000000000000000000000000000000000000",
 			},
-
-			input: preview.Input{},
+			unknownTags: []string{},
+			input:       preview.Input{},
 			params: map[string]assertParam{
-				"Example": ap().
-					unknown().
-					// Value is unknown, but this is the safe string
-					value("data.coder_parameter.example.value"),
+				"os": ap().
+					value("0000000000000000000000000000000000000000000000000000000000000000"),
 			},
 		},
 		{
 			name: "external docker resource with plan data",
 			dir:  "dockerdata",
 			expTags: map[string]string{
-				"qux": "quux",
-				"foo": "sha256:18305429afa14ea462f810146ba44d4363ae76e4c8dfc38288cf73aa07485005",
-				"bar": "sha256:a27fd8080b517143cbbbab9dfb7c8571c40d67d534bbdee55bd6c473f432b177",
+				"qux":    "quux",
+				"ubuntu": "18305429afa14ea462f810146ba44d4363ae76e4c8dfc38288cf73aa07485005",
+				"centos": "a27fd8080b517143cbbbab9dfb7c8571c40d67d534bbdee55bd6c473f432b177",
 			},
 			unknownTags: []string{},
 			input: preview.Input{
 				PlanJSONPath: "plan.json",
 			},
 			params: map[string]assertParam{
-				"Example": ap().
+				"os": ap().
 					value("18305429afa14ea462f810146ba44d4363ae76e4c8dfc38288cf73aa07485005"),
 			},
 		},

testdata/conditional/main.tf

@@ -71,3 +71,23 @@ data "coder_parameter" "compute" {
     }
   }
 }
+
+data coder_workspace_owner "me" {}
+locals {
+  isAdmin = contains(data.coder_workspace_owner.me.groups, "admin")
+}
+
+data "coder_parameter" "image_hash" {
+  count       = local.isAdmin ? 1 : 0
+  name = "hash"
+  display_name        = "Image Hash"
+  description = "Override the hash of the image to use. Only available to admins."
+  // Value can get stale
+  default     = "e64c69d84d5f910b5cd4fc7bc01a67a6436865787b429e7e60ebaeb4e7dd1b44"
+  order       = 3
+
+  validation {
+    regex = "^[a-f0-9A-F]{64}$"
+    error = "The image hash must be a 64-character hexadecimal string."
+  }
+}

testdata/conditional/users.json

@@ -0,0 +1,8 @@
+{
+  "developer": {
+    "groups": ["developer"]
+  },
+  "administrator": {
+    "groups": ["admin"]
+  }
+}

testdata/dockerdata/main.tf

@@ -12,29 +12,36 @@ terraform {
   }
 }
 
-data "coder_parameter" "example" {
-  name        = "Example"
+locals {
+  empty_hash  = "0000000000000000000000000000000000000000000000000000000000000000"
+  ubuntu_hash = try(trimprefix(data.docker_registry_image.ubuntu.sha256_digest, "sha256:"), local.empty_hash)
+  centos_hash = try(trimprefix(data.docker_registry_image.centos.sha256_digest, "sha256:"), local.empty_hash)
+}
+
+data "coder_parameter" "os" {
+  name = "os"
+  display_name = "Choose your operating system"
   description = "An example parameter that has no purpose."
   type        = "string"
-  default     = trimprefix(data.docker_registry_image.ubuntu.sha256_digest, "sha256:")
+  default     = local.ubuntu_hash
 
   option {
-    name = "Ubuntu"
+    name = "Ubuntu (${substr(local.ubuntu_hash, 0, 6)}...${substr(local.ubuntu_hash, 58, 64)})"
     description = data.docker_registry_image.ubuntu.name
-    value = trimprefix(data.docker_registry_image.ubuntu.sha256_digest, "sha256:")
+    value = local.ubuntu_hash
   }
 
   option {
-    name = "Centos"
+    name = "Centos (${substr(local.centos_hash, 0, 6)}...${substr(local.centos_hash, 58, 64)})"
     description = data.docker_registry_image.centos.name
-    value = trimprefix(data.docker_registry_image.centos.sha256_digest, "sha256:")
+    value = local.centos_hash
   }
 }
 
 data "coder_workspace_tags" "custom_workspace_tags" {
   tags = {
-    "foo" = data.docker_registry_image.ubuntu.sha256_digest
-    "bar" = data.docker_registry_image.centos.sha256_digest
+    "ubuntu" = local.ubuntu_hash
+    "centos" = local.centos_hash
     "qux" = "quux"
   }
 }

workspacetags.go

@@ -121,11 +121,15 @@ func NewTag(srcRange *hcl.Range, files map[string]*hcl.File, key, val cty.Value)
 	}
 
 	if val.IsKnown() && val.Type() != cty.String {
+		fr := "<nil>"
+		if !val.Type().Equals(cty.NilType) {
+			fr = val.Type().FriendlyName()
+		}
 		//r := expr.ValueExpr.Range()
 		return types.Tag{}, &hcl.Diagnostic{
 			Severity: hcl.DiagError,
 			Summary:  "Invalid value type for tag",
-			Detail:   fmt.Sprintf("Value must be a string, but got %s", val.Type().FriendlyName()),
+			Detail:   fmt.Sprintf("Value must be a string, but got %s", fr),
 			//Subject:     &r,
 			Context: srcRange,
 			//Expression:  expr.ValueExpr,