add warnings when preview fails to predict count meta arguments

Author: Emyrk

preview.go

@@ -104,6 +104,10 @@ func Preview(ctx context.Context, input Input, dir fs.FS) (*Output, hcl.Diagnost
 	diags := make(hcl.Diagnostics, 0)
 	rp, rpDiags := RichParameters(modules)
 	tags, tagDiags := WorkspaceTags(modules, p.Files())
+
+	// Add warnings
+	diags = diags.Extend(warnings(modules))
+
 	return &Output{
 		ModuleOutput:  outputs,
 		Parameters:    rp,

testdata/wordle/main.tf

@@ -19,7 +19,6 @@ module "one" {
   index = 0
   correct = local.correct
   previous = "     "
-  default = "curse"
 }
 
 module "two" {
@@ -29,15 +28,38 @@ module "two" {
   previous = module.one.value
 }
 
-data "coder_parameter" "dump" {
-  name = "dump"
-  display_name = "test"
-  description = "Dump the state"
-  type = "string"
-  order = 100
-  default = ""
+module "three" {
+  source = "./word"
+  index = 2
+  correct = local.correct
+  previous = module.two.value
 }
+#
+# module "four" {
+#   source = "./word"
+#   index = 3
+#   correct = local.correct
+#   previous = module.three.value
+# }
+#
+# module "five" {
+#   source = "./word"
+#   index = 4
+#   correct = local.correct
+#   previous = module.four.value
+# }
+#
+# module "six" {
+#   source = "./word"
+#   index = 5
+#   correct = local.correct
+#   previous = module.five.value
+# }
+
 
+output "debug" {
+  value = module.two.debug
+}
 
 #
 # module "word_one" {

testdata/wordle/word/main.tf

@@ -33,16 +33,10 @@ variable "default" {
 }
 
 output "value" {
-  value = data.coder_parameter.word[0].value
+  value = lower(data.coder_parameter.word[0].value)
 }
 
 locals {
-  matching = join("", [
-    for i in range(0, length(var.correct)) : (
-      substr(var.previous, i, 1) == substr(var.correct, i, 1) ? "#" : "_"
-    )
-  ])
-
   // unmatchedLetters are letters that are not exact matches from the
   // previous input.
   unmatchedLetters = [
@@ -65,21 +59,42 @@ locals {
       l
     ) if contains(local.remainingLetters, l)
   ]
+
+  matching = join("", [
+    for i in range(0, length(var.correct)) : (
+      substr(var.previous, i, 1) == substr(var.correct, i, 1) ?
+        upper(substr(var.correct, i, 1)) :
+            contains(local.letterExists, substr(var.previous, i, 1)) ?
+              lower(substr(var.previous, i, 1)) :
+                "_"
+    )
+  ])
 }
 
 data "coder_parameter" "word" {
   count        = length(var.previous) == 5 ? 1 : 0
   name         = local.names[var.index]
-  display_name = "--> ${local.matching} <-- with ${join("", local.letterExists)}"
-  description = local.matching
+  display_name = var.index == 0 ? "Take a guess what the 5 letter word might be!" : "${var.index}: --> ${local.matching} <--"
+  description  = var.index == 0 ? "Additional guesses will appear.": "Capital letters are an exact match, lowercase are letters that are out of place."
   type         = "string"
   order        = var.index + 10
   default      = var.default
 
   validation {
-    regex = "^[a-zA-Z]{5}$"
+    regex = "^[a-z]{5}$"
     error = "You must enter a 5 letter word."
   }
 }
 
 
+
+output "debug" {
+  value = {
+    "correct" = var.correct
+    "previous" = var.previous
+    "unmatchedLetters" = local.unmatchedLetters
+    "remainingLetters" = local.remainingLetters
+    "letterExists" = local.letterExists
+    "matching" = local.matching
+  }
+}

warnings.go

@@ -0,0 +1,44 @@
+package preview
+
+import (
+	"fmt"
+
+	"github.com/aquasecurity/trivy/pkg/iac/terraform"
+	"github.com/hashicorp/hcl/v2"
+)
+
+func warnings(modules terraform.Modules) hcl.Diagnostics {
+	var diags hcl.Diagnostics
+	diags = diags.Extend(unexpandedCountBlocks(modules))
+
+	return diags
+}
+
+// unexpandedCountBlocks is to compensate for a bug in the trivy parser.
+// It is related to https://github.com/aquasecurity/trivy/pull/8479.
+// Essentially, submodules are processed once. So if there is interdependent
+// submodule references, then
+func unexpandedCountBlocks(modules terraform.Modules) hcl.Diagnostics {
+	var diags hcl.Diagnostics
+
+	for _, block := range modules.GetBlocks() {
+		block := block
+
+		if countAttr, ok := block.Attributes()["count"]; ok {
+			if block.IsExpanded() {
+				continue
+			}
+
+			diags = append(diags, &hcl.Diagnostic{
+				Severity:    hcl.DiagWarning,
+				Summary:     fmt.Sprintf("Unexpanded count argument on block %q", block.FullName()),
+				Detail:      "The count argument is not expanded. This may lead to unexpected behavior. The default behavior is to assume count is 1.",
+				Subject:     &countAttr.HCLAttribute().Range,
+				Context:     &block.HCLBlock().DefRange,
+				Expression:  countAttr.HCLAttribute().Expr,
+				EvalContext: block.Context().Inner(),
+			})
+		}
+	}
+	return diags
+}