add happy path test

Author: Emyrk

preview_test.go

@@ -41,12 +41,13 @@ func Test_Extract(t *testing.T) {
 		failPreview bool
 		input       preview.Input
 
-		expTags     map[string]string
-		unknownTags []string
-		params      map[string]assertParam
-		variables   map[string]assertVariable
-		presets     func(t *testing.T, presets []types.Preset)
-		warnings    []*regexp.Regexp
+		expTags      map[string]string
+		unknownTags  []string
+		params       map[string]assertParam
+		variables    map[string]assertVariable
+		presetsFuncs func(t *testing.T, presets []types.Preset)
+		presets      map[string]assertPreset
+		warnings     []*regexp.Regexp
 	}{
 		{
 			name:        "bad param values",
@@ -266,6 +267,27 @@ func Test_Extract(t *testing.T) {
 					errorDiagnostics("Required"),
 			},
 		},
+		{
+			name:        "valid prebuild",
+			dir:         "preset",
+			expTags:     map[string]string{},
+			input:       preview.Input{},
+			unknownTags: []string{},
+			params: map[string]assertParam{
+				"number":      ap(),
+				"has_default": ap(),
+			},
+			presets: map[string]assertPreset{
+				"valid_preset": aPre().
+					value("number", "9").
+					value("has_default", "changed").
+					prebuildCount(3),
+				"prebuild_instance_zero": aPre().
+					prebuildCount(0),
+				"not_prebuild": aPre().
+					prebuildCount(0),
+			},
+		},
 		{
 			name:        "invalid presets",
 			dir:         "invalidpresets",
@@ -276,7 +298,7 @@ func Test_Extract(t *testing.T) {
 				"valid_parameter_name": ap().
 					optVals("valid_option_value"),
 			},
-			presets: func(t *testing.T, presets []types.Preset) {
+			presetsFuncs: func(t *testing.T, presets []types.Preset) {
 				presetMap := map[string]func(t *testing.T, preset types.Preset){
 					"empty_parameters": func(t *testing.T, preset types.Preset) {
 						require.Len(t, preset.Diagnostics, 0)
@@ -688,8 +710,14 @@ func Test_Extract(t *testing.T) {
 			}
 
 			// Assert presets
-			if tc.presets != nil {
-				tc.presets(t, output.Presets)
+			if tc.presetsFuncs != nil {
+				tc.presetsFuncs(t, output.Presets)
+			}
+
+			for _, preset := range output.Presets {
+				check, ok := tc.presets[preset.Name]
+				require.True(t, ok, "unknown preset %s", preset.Name)
+				check(t, preset)
 			}
 
 			// Assert variables
@@ -961,6 +989,16 @@ func (a assertPreset) def(def bool) assertPreset {
 	})
 }
 
+func (a assertPreset) prebuildCount(exp int) assertPreset {
+	return a.extend(func(t *testing.T, preset types.Preset) {
+		if exp == 0 && preset.Prebuild == nil {
+			return
+		}
+		require.NotNilf(t, preset.Prebuild, "prebuild should not be nil, expected %d instances", exp)
+		require.Equal(t, exp, preset.Prebuild.Instances)
+	})
+}
+
 func (a assertPreset) value(key, value string) assertPreset {
 	return a.extend(func(t *testing.T, preset types.Preset) {
 		v, ok := preset.Parameters[key]

testdata/preset/main.tf

@@ -0,0 +1,50 @@
+terraform {
+  required_providers {
+    coder = {
+      source = "coder/coder"
+      version = "2.8.0"
+    }
+  }
+}
+
+data "coder_parameter" "number" {
+  name = "number"
+  default = "7"
+  type = "number"
+
+  validation {
+    min = 4
+    max = 10
+  }
+}
+
+data "coder_parameter" "has_default" {
+  name = "has_default"
+  default = "hello world"
+}
+
+
+data "coder_workspace_preset" "valid_preset" {
+  name = "valid_preset"
+
+  parameters = {
+    "number" = "9"
+    "has_default" = "changed"
+  }
+  prebuilds {
+    instances = 3
+  }
+}
+
+data "coder_workspace_preset" "prebuild_instance_zero" {
+  name = "prebuild_instance_zero"
+
+  prebuilds {
+    // No instances
+    instances = 0
+  }
+}
+
+data "coder_workspace_preset" "not_prebuild" {
+  name = "not_prebuild"
+}

testdata/presetfail/skipe2e

@@ -0,0 +1 @@
+parameters are invalid without input