Skip to content

Commit 08991f2

Browse files
Fix hostname logic as suggested in PR review
- Use owner_name in hostname when agent_name is provided: agent.workspace.owner.coder - Keep simple format when no agent_name: workspace.coder - Update tests to match the corrected hostname formats Implements the suggestion from PR review comment. Co-authored-by: matifali <[email protected]>
1 parent 3cba245 commit 08991f2

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

registry/coder/modules/zed/main.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ describe("zed", async () => {
1717
agent_id: "foo",
1818
});
1919
expect(state.outputs.zed_url.value).toBe(
20-
"zed://ssh/default.default.coder",
20+
"zed://ssh/default.coder",
2121
);
2222

2323
const coder_app = state.resources.find(
@@ -35,7 +35,7 @@ describe("zed", async () => {
3535
folder: "/foo/bar",
3636
});
3737
expect(state.outputs.zed_url.value).toBe(
38-
"zed://ssh/default.default.coder/foo/bar",
38+
"zed://ssh/default.coder/foo/bar",
3939
);
4040
});
4141

@@ -75,7 +75,7 @@ describe("zed", async () => {
7575
agent_name: "myagent",
7676
});
7777
expect(state.outputs.zed_url.value).toBe(
78-
"zed://ssh/myagent.default.me.coder",
78+
"zed://ssh/myagent.default.default.coder",
7979
);
8080
});
8181
});

registry/coder/modules/zed/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ locals {
5757
workspace_name = lower(data.coder_workspace.me.name)
5858
owner_name = lower(data.coder_workspace_owner.me.name)
5959
agent_name = lower(var.agent_name)
60-
hostname = var.agent_name != "" ? "${local.agent_name}.${local.workspace_name}.me.coder" : "${local.workspace_name}.${local.owner_name}.coder"
60+
hostname = var.agent_name != "" ? "${local.agent_name}.${local.workspace_name}.${local.owner_name}.coder" : "${local.workspace_name}.coder"
6161
}
6262

6363
resource "coder_app" "zed" {

0 commit comments

Comments
 (0)