fix: escape variable expansions in run.sh

Author: DevelopmentCats

registry/coder/modules/kasmvnc/run.sh

@@ -39,34 +39,34 @@ download_file() {
   fi
 
   # shellcheck disable=SC2288
-  "$${download_tool[@]}" "$url" > "$output" || {
-    echo "ERROR: Failed to download $url"
+  "$${download_tool[@]}" "$$url" > "$$output" || {
+    echo "ERROR: Failed to download $$url"
     exit 1
   }
 }
 
 # Function to install kasmvncserver for debian-based distros
 install_deb() {
-  local url=$1
+  local url=$$1
   local kasmdeb="/tmp/kasmvncserver.deb"
 
-  download_file "$url" "$kasmdeb"
+  download_file "$$url" "$$kasmdeb"
 
   CACHE_DIR="/var/lib/apt/lists/partial"
   # Check if the directory exists and was modified in the last 60 minutes
-  if [[ ! -d "$CACHE_DIR" ]] || ! find "$CACHE_DIR" -mmin -60 -print -quit &> /dev/null; then
+  if [[ ! -d "$$CACHE_DIR" ]] || ! find "$$CACHE_DIR" -mmin -60 -print -quit &> /dev/null; then
     echo "Stale package cache, updating..."
     # Update package cache with a 300-second timeout for dpkg lock
     sudo apt-get -o DPkg::Lock::Timeout=300 -qq update
   fi
 
-  DEBIAN_FRONTEND=noninteractive sudo apt-get -o DPkg::Lock::Timeout=300 install --yes -qq --no-install-recommends --no-install-suggests "$kasmdeb"
-  rm "$kasmdeb"
+  DEBIAN_FRONTEND=noninteractive sudo apt-get -o DPkg::Lock::Timeout=300 install --yes -qq --no-install-recommends --no-install-suggests "$$kasmdeb"
+  rm "$$kasmdeb"
 }
 
 # Function to install kasmvncserver for rpm-based distros
 install_rpm() {
-  local url=$1
+  local url=$$1
   local kasmrpm="/tmp/kasmvncserver.rpm"
   local package_manager
 
@@ -88,26 +88,26 @@ install_rpm() {
     exit 1
   fi
 
-  download_file "$url" "$kasmrpm"
+  download_file "$$url" "$$kasmrpm"
 
   # shellcheck disable=SC2288
-  sudo "$${package_manager[@]}" "$kasmrpm" || {
-    echo "ERROR: Failed to install $kasmrpm"
+  sudo "$${package_manager[@]}" "$$kasmrpm" || {
+    echo "ERROR: Failed to install $$kasmrpm"
     exit 1
   }
 
-  rm "$kasmrpm"
+  rm "$$kasmrpm"
 }
 
 # Function to install kasmvncserver for Alpine Linux
 install_alpine() {
-  local url=$1
+  local url=$$1
   local kasmtgz="/tmp/kasmvncserver.tgz"
 
-  download_file "$url" "$kasmtgz"
+  download_file "$$url" "$$kasmtgz"
 
-  tar -xzf "$kasmtgz" -C /usr/local/bin/
-  rm "$kasmtgz"
+  tar -xzf "$$kasmtgz" -C /usr/local/bin/
+  rm "$$kasmtgz"
 }
 
 # Detect system information
@@ -118,39 +118,39 @@ fi
 
 # shellcheck disable=SC1091
 source /etc/os-release
-distro="$ID"
-distro_version="$VERSION_ID"
-codename="$VERSION_CODENAME"
-arch="$(uname -m)"
-if [[ "$ID" == "ol" ]]; then
+distro="$$ID"
+distro_version="$$VERSION_ID"
+codename="$$VERSION_CODENAME"
+arch="$$(uname -m)"
+if [[ "$$ID" == "ol" ]]; then
   distro="oracle"
   distro_version="$${distro_version%%.*}"
-elif [[ "$ID" == "fedora" ]]; then
-  distro_version="$(grep -oP '\(\K[\w ]+' /etc/fedora-release | tr '[:upper:]' '[:lower:]' | tr -d ' ')"
+elif [[ "$$ID" == "fedora" ]]; then
+  distro_version="$$(grep -oP '\(\K[\w ]+' /etc/fedora-release | tr '[:upper:]' '[:lower:]' | tr -d ' ')"
 fi
 
-echo "Detected Distribution: $distro"
-echo "Detected Version: $distro_version"
-echo "Detected Codename: $codename"
-echo "Detected Architecture: $arch"
+echo "Detected Distribution: $$distro"
+echo "Detected Version: $$distro_version"
+echo "Detected Codename: $$codename"
+echo "Detected Architecture: $$arch"
 
 # Map arch to package arch
 case "$arch" in
   x86_64)
-    if [[ "$distro" =~ ^(ubuntu|debian|kali)$ ]]; then
+    if [[ "$$distro" =~ ^(ubuntu|debian|kali)$ ]]; then
       arch="amd64"
     fi
     ;;
   aarch64)
-    if [[ "$distro" =~ ^(ubuntu|debian|kali)$ ]]; then
+    if [[ "$$distro" =~ ^(ubuntu|debian|kali)$ ]]; then
       arch="arm64"
     fi
     ;;
   arm64)
     : # This is effectively a noop
     ;;
   *)
-    echo "ERROR: Unsupported architecture: $arch"
+    echo "ERROR: Unsupported architecture: $$arch"
     exit 1
     ;;
 esac
@@ -166,21 +166,21 @@ if ! check_installed; then
   base_url="https://github.com/kasmtech/KasmVNC/releases/download/v${KASM_VERSION}"
 
   echo "Installing KASM version: ${KASM_VERSION}"
-  case $distro in
+  case $$distro in
     ubuntu | debian | kali)
       bin_name="kasmvncserver_$${codename}_${KASM_VERSION}_$${arch}.deb"
-      install_deb "$base_url/$bin_name"
+      install_deb "$$base_url/$$bin_name"
       ;;
     oracle | fedora | opensuse)
       bin_name="kasmvncserver_$${distro}_$${distro_version}_${KASM_VERSION}_$${arch}.rpm"
-      install_rpm "$base_url/$bin_name"
+      install_rpm "$$base_url/$$bin_name"
       ;;
     alpine)
       bin_name="kasmvnc.alpine_$${distro_version//./}_$${arch}.tgz"
-      install_alpine "$base_url/$bin_name"
+      install_alpine "$$base_url/$$bin_name"
       ;;
     *)
-      echo "Unsupported distribution: $distro"
+      echo "Unsupported distribution: $$distro"
       exit 1
       ;;
   esac
@@ -192,23 +192,23 @@ if command -v sudo &> /dev/null && sudo -n true 2> /dev/null; then
   kasm_config_file="/etc/kasmvnc/kasmvnc.yaml"
   SUDO=sudo
 else
-  kasm_config_file="$HOME/.vnc/kasmvnc.yaml"
+  kasm_config_file="$$HOME/.vnc/kasmvnc.yaml"
   SUDO=""
 
   echo "WARNING: Sudo access not available, using user config dir!"
 
-  if [[ -f "$kasm_config_file" ]]; then
+  if [[ -f "$$kasm_config_file" ]]; then
     echo "WARNING: Custom user KasmVNC config exists, not overwriting!"
     echo "WARNING: Ensure that you manually configure the appropriate settings."
     kasm_config_file="/dev/stderr"
   else
     echo "WARNING: This may prevent custom user KasmVNC settings from applying!"
-    mkdir -p "$HOME/.vnc"
+    mkdir -p "$$HOME/.vnc"
   fi
 fi
 
-echo "Writing KasmVNC config to $kasm_config_file"
-$SUDO tee "$kasm_config_file" > /dev/null << EOF
+echo "Writing KasmVNC config to $$kasm_config_file"
+$$SUDO tee "$$kasm_config_file" > /dev/null << EOF
 network:
   protocol: http
   interface: 127.0.0.1
@@ -224,7 +224,7 @@ EOF
 # This password is not used since we start the server without auth.
 # The server is protected via the Coder session token / tunnel
 # and does not listen publicly
-echo -e "password\npassword\n" | vncpasswd -wo -u "$USER"
+echo -e "password\npassword\n" | vncpasswd -wo -u "$$USER"
 
 get_http_dir() {
   # determine the served file path
@@ -240,41 +240,41 @@ get_http_dir() {
   fi
 
   # Check the home directory for overriding values
-  if [[ -e "$HOME/.vnc/kasmvnc.yaml" ]]; then
-    d=$(grep -E '^\s*httpd_directory:.*$' "$HOME/.vnc/kasmvnc.yaml" | awk '{print $$2}')
+  if [[ -e "$$HOME/.vnc/kasmvnc.yaml" ]]; then
+    d=$(grep -E '^\s*httpd_directory:.*$' "$$HOME/.vnc/kasmvnc.yaml" | awk '{print $$2}')
     if [[ -n "$$d" && -d "$$d" ]]; then
       httpd_directory=$$d
     fi
   fi
-  echo $httpd_directory
+  echo $$httpd_directory
 }
 
 fix_server_index_file() {
   local fname=$${FUNCNAME[0]} # gets current function name
   if [[ $# -ne 1 ]]; then
-    error "$fname requires exactly 1 parameter:\n\tpath to KasmVNC httpd_directory"
+    error "$$fname requires exactly 1 parameter:\n\tpath to KasmVNC httpd_directory"
   fi
-  local httpdir="$1"
-  if [[ ! -d "$httpdir" ]]; then
-    error "$fname: $httpdir is not a directory"
+  local httpdir="$$1"
+  if [[ ! -d "$$httpdir" ]]; then
+    error "$$fname: $$httpdir is not a directory"
   fi
-  pushd "$httpdir" > /dev/null
+  pushd "$$httpdir" > /dev/null
 
   cat << 'EOH' > /tmp/path_vnc.html
 ${PATH_VNC_HTML}
 EOH
-  $SUDO mv /tmp/path_vnc.html .
+  $$SUDO mv /tmp/path_vnc.html .
   # check for the switcheroo
   if [[ -f "index.html" && -L "vnc.html" ]]; then
-    $SUDO mv $httpdir/index.html $httpdir/vnc.html
+    $$SUDO mv $$httpdir/index.html $$httpdir/vnc.html
   fi
-  $SUDO ln -s -f path_vnc.html index.html
+  $$SUDO ln -s -f path_vnc.html index.html
   popd > /dev/null
 }
 
 patch_kasm_http_files() {
   homedir=$(get_http_dir)
-  fix_server_index_file "$homedir"
+  fix_server_index_file "$$homedir"
 }
 
 if [[ "${SUBDOMAIN}" == "false" ]]; then
@@ -287,17 +287,17 @@ VNC_LOG="/tmp/kasmvncserver.log"
 printf "🚀 Starting KasmVNC server...\n"
 
 set +e
-vncserver -select-de "${DESKTOP_ENVIRONMENT}" -disableBasicAuth > "$VNC_LOG" 2>&1
-RETVAL=$?
+vncserver -select-de "${DESKTOP_ENVIRONMENT}" -disableBasicAuth > "$$VNC_LOG" 2>&1
+RETVAL=$$?
 set -e
 
-if [[ $RETVAL -ne 0 ]]; then
-  echo "ERROR: Failed to start KasmVNC server. Return code: $RETVAL"
-  if [[ -f "$VNC_LOG" ]]; then
+if [[ $$RETVAL -ne 0 ]]; then
+  echo "ERROR: Failed to start KasmVNC server. Return code: $$RETVAL"
+  if [[ -f "$$VNC_LOG" ]]; then
     echo "Full logs:"
-    cat "$VNC_LOG"
+    cat "$$VNC_LOG"
   else
-    echo "ERROR: Log file not found: $VNC_LOG"
+    echo "ERROR: Log file not found: $$VNC_LOG"
   fi
   exit 1
 fi