Skip to content

Commit 4f3e960

Browse files
Merge branch 'main' into cat/local-windows-rdp
2 parents d331c29 + a8e2364 commit 4f3e960

File tree

4 files changed

+26
-11
lines changed

4 files changed

+26
-11
lines changed

.github/workflows/version-bump.yaml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ jobs:
1717
permissions:
1818
contents: read
1919
pull-requests: write
20+
issues: write
2021
steps:
2122
- name: Checkout code
2223
uses: actions/checkout@v4
@@ -46,7 +47,6 @@ jobs:
4647
- name: Check version bump requirements
4748
id: version-check
4849
run: |
49-
# Run the script to check what versions should be
5050
output_file=$(mktemp)
5151
if ./.github/scripts/version-bump.sh "${{ steps.bump-type.outputs.type }}" origin/main > "$output_file" 2>&1; then
5252
echo "Script completed successfully"
@@ -56,17 +56,14 @@ jobs:
5656
exit 1
5757
fi
5858
59-
# Store output for PR comment
6059
{
6160
echo "output<<EOF"
6261
cat "$output_file"
6362
echo "EOF"
6463
} >> $GITHUB_OUTPUT
6564
66-
# Show output
6765
cat "$output_file"
6866
69-
# Check if any files would be modified by the script
7067
if git diff --quiet; then
7168
echo "versions_up_to_date=true" >> $GITHUB_OUTPUT
7269
echo "✅ All module versions are already up to date"
@@ -78,13 +75,18 @@ jobs:
7875
echo ""
7976
echo "Diff preview:"
8077
git diff
78+
79+
git checkout .
80+
git clean -fd
81+
8182
exit 1
8283
fi
8384
8485
- name: Comment on PR - Failure
8586
if: failure() && steps.version-check.outputs.versions_up_to_date == 'false'
8687
uses: actions/github-script@v7
8788
with:
89+
github-token: ${{ secrets.GITHUB_TOKEN }}
8890
script: |
8991
const output = `${{ steps.version-check.outputs.output }}`;
9092
const bumpType = `${{ steps.bump-type.outputs.type }}`;

registry/coder/modules/vscode-web/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Automatically install [Visual Studio Code Server](https://code.visualstudio.com/
1515
module "vscode-web" {
1616
count = data.coder_workspace.me.start_count
1717
source = "registry.coder.com/coder/vscode-web/coder"
18-
version = "1.2.0"
18+
version = "1.3.0"
1919
agent_id = coder_agent.example.id
2020
accept_license = true
2121
}
@@ -31,7 +31,7 @@ module "vscode-web" {
3131
module "vscode-web" {
3232
count = data.coder_workspace.me.start_count
3333
source = "registry.coder.com/coder/vscode-web/coder"
34-
version = "1.2.0"
34+
version = "1.3.0"
3535
agent_id = coder_agent.example.id
3636
install_prefix = "/home/coder/.vscode-web"
3737
folder = "/home/coder"
@@ -45,7 +45,7 @@ module "vscode-web" {
4545
module "vscode-web" {
4646
count = data.coder_workspace.me.start_count
4747
source = "registry.coder.com/coder/vscode-web/coder"
48-
version = "1.2.0"
48+
version = "1.3.0"
4949
agent_id = coder_agent.example.id
5050
extensions = ["github.copilot", "ms-python.python", "ms-toolsai.jupyter"]
5151
accept_license = true
@@ -60,7 +60,7 @@ Configure VS Code's [settings.json](https://code.visualstudio.com/docs/getstarte
6060
module "vscode-web" {
6161
count = data.coder_workspace.me.start_count
6262
source = "registry.coder.com/coder/vscode-web/coder"
63-
version = "1.2.0"
63+
version = "1.3.0"
6464
agent_id = coder_agent.example.id
6565
extensions = ["dracula-theme.theme-dracula"]
6666
settings = {
@@ -78,7 +78,7 @@ By default, this module installs the latest. To pin a specific version, retrieve
7878
module "vscode-web" {
7979
count = data.coder_workspace.me.start_count
8080
source = "registry.coder.com/coder/vscode-web/coder"
81-
version = "1.2.0"
81+
version = "1.3.0"
8282
agent_id = coder_agent.example.id
8383
commit_id = "e54c774e0add60467559eb0d1e229c6452cf8447"
8484
accept_license = true

registry/coder/modules/vscode-web/main.tf

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,12 @@ variable "use_cached" {
121121
default = false
122122
}
123123

124+
variable "disable_trust" {
125+
type = bool
126+
description = "Disables workspace trust protection for VS Code Web."
127+
default = false
128+
}
129+
124130
variable "extensions_dir" {
125131
type = string
126132
description = "Override the directory to store extensions in."
@@ -169,6 +175,7 @@ resource "coder_script" "vscode-web" {
169175
SETTINGS : replace(jsonencode(var.settings), "\"", "\\\""),
170176
OFFLINE : var.offline,
171177
USE_CACHED : var.use_cached,
178+
DISABLE_TRUST : var.disable_trust,
172179
EXTENSIONS_DIR : var.extensions_dir,
173180
FOLDER : var.folder,
174181
AUTO_INSTALL_EXTENSIONS : var.auto_install_extensions,

registry/coder/modules/vscode-web/run.sh

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,16 @@ if [ -n "${SERVER_BASE_PATH}" ]; then
1616
SERVER_BASE_PATH_ARG="--server-base-path=${SERVER_BASE_PATH}"
1717
fi
1818

19+
# Set disable workspace trust
20+
DISABLE_TRUST_ARG=""
21+
if [ "${DISABLE_TRUST}" = true ]; then
22+
DISABLE_TRUST_ARG="--disable-workspace-trust"
23+
fi
24+
1925
run_vscode_web() {
20-
echo "👷 Running $VSCODE_WEB serve-local $EXTENSION_ARG $SERVER_BASE_PATH_ARG --port ${PORT} --host 127.0.0.1 --accept-server-license-terms --without-connection-token --telemetry-level ${TELEMETRY_LEVEL} in the background..."
26+
echo "👷 Running $VSCODE_WEB serve-local $EXTENSION_ARG $SERVER_BASE_PATH_ARG $DISABLE_TRUST_ARG --port ${PORT} --host 127.0.0.1 --accept-server-license-terms --without-connection-token --telemetry-level ${TELEMETRY_LEVEL} in the background..."
2127
echo "Check logs at ${LOG_PATH}!"
22-
"$VSCODE_WEB" serve-local "$EXTENSION_ARG" "$SERVER_BASE_PATH_ARG" --port "${PORT}" --host 127.0.0.1 --accept-server-license-terms --without-connection-token --telemetry-level "${TELEMETRY_LEVEL}" > "${LOG_PATH}" 2>&1 &
28+
"$VSCODE_WEB" serve-local "$EXTENSION_ARG" "$SERVER_BASE_PATH_ARG" "$DISABLE_TRUST_ARG" --port "${PORT}" --host 127.0.0.1 --accept-server-license-terms --without-connection-token --telemetry-level "${TELEMETRY_LEVEL}" > "${LOG_PATH}" 2>&1 &
2329
}
2430

2531
# Check if the settings file exists...

0 commit comments

Comments
 (0)