update var name, remove deprecation note

Author: rowansmithau

registry/coder/modules/jetbrains-gateway/README.md

@@ -47,7 +47,7 @@ module "jetbrains_gateway" {
 
 This can be used when support for connecting to multiple agents within one workspace is required.
 
-To utilise this both `embed_agent_id` and `agent_name` must be populated on each instance of the module.
+To utilise this both `embed_agent_name` and `agent_name` must be populated on each instance of the module.
 In addition each instance must have a unique `slug` and `ide_parameter_name` variable defined.
 
 ```tf
@@ -59,7 +59,7 @@ module "jetbrains_gateway" {
   folder             = "/home/coder/example"
   jetbrains_ides     = ["CL", "GO"]
   default            = "GO"
-  embed_agent_id     = true
+  embed_agent_name   = true
   agent_name         = "main"
   ide_parameter_name = "jetbrains_ide" # default variable value
   slug               = "gateway"       # default variable value
@@ -73,7 +73,7 @@ module "jetbrains_gateway_agent2" {
   folder             = "/home/coder/example"
   jetbrains_ides     = ["CL", "GO", "IU", "PY", "WS"]
   default            = "GO"
-  embed_agent_id     = true
+  embed_agent_name   = true
   agent_name         = "jetbrainsagent2"
   ide_parameter_name = "jetbrains_ide_agent2"
   slug               = "gateway-agent2"

registry/coder/modules/jetbrains-gateway/main.test.ts

@@ -41,12 +41,12 @@ describe("jetbrains-gateway", async () => {
     expect(state.outputs.identifier.value).toBe("IU");
   });
 
-  it("optionally includes agent when embed_agent_id is true", async () => {
+  it("optionally includes agent when embed_agent_name is true", async () => {
     const state = await runTerraformApply(import.meta.dir, {
       agent_id: "foo",
       agent_name: "main",
       folder: "/home/coder",
-      embed_agent_id: true,
+      embed_agent_name: true,
     });
 
     expect(state.outputs.url.value).toBe(

registry/coder/modules/jetbrains-gateway/main.tf

@@ -36,8 +36,7 @@ variable "slug" {
 
 variable "agent_name" {
   type        = string
-  description = "Agent name. (unused). Will be removed in a future version"
-
+  description = "Agent name."
   default = ""
 }
 
@@ -68,7 +67,7 @@ variable "group" {
   default     = null
 }
 
-variable "embed_agent_id" {
+variable "embed_agent_name" {
   type        = bool
   description = "Embed the agent name in the JetBrains Gateway URL when support for multiple agents is required."
   default     = false
@@ -360,7 +359,7 @@ resource "coder_app" "gateway" {
     local.build_number,
     "&ide_download_link=",
     local.download_link,
-  ], var.embed_agent_id && trimspace(var.agent_name) != "" ? ["&agent=", var.agent_name] : []))
+  ], var.embed_agent_name && trimspace(var.agent_name) != "" ? ["&agent=", var.agent_name] : []))
 }
 
 output "identifier" {