Skip to content

Commit 8480748

Browse files
committed
docs: make comment for clear
1 parent e87dc93 commit 8480748

File tree

2 files changed

+25
-5
lines changed

2 files changed

+25
-5
lines changed

.github/workflows/ci.yaml

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ concurrency:
77
group: ${{ github.workflow }}-${{ github.ref }}
88
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
99
jobs:
10-
validate-contributors:
10+
validate-readme-files:
1111
runs-on: ubuntu-latest
1212
steps:
1313
- name: Check out code
@@ -20,3 +20,23 @@ jobs:
2020
run: go build ./scripts/contributors && ./contributors
2121
- name: Remove build file artifact
2222
run: rm ./contributors
23+
test-terraform:
24+
runs-on: ubuntu-latest/
25+
steps:
26+
- name: Check out code
27+
uses: actions/checkout@v4
28+
- name: Set up Terraform
29+
uses: coder/coder/.github/actions/setup-tf@main
30+
- name: Set up Bun
31+
uses: oven-sh/setup-bun@v2
32+
with:
33+
# We're using the latest version of Bun for now, but it might be worth
34+
# reconsidering. They've pushed breaking changes in patch releases
35+
# that have broken our CI.
36+
# Our PR where issues started to pop up: https://github.com/coder/modules/pull/383
37+
# The Bun PR that broke things: https://github.com/oven-sh/bun/pull/16067
38+
bun-version: latest
39+
- name: Install dependencies
40+
run: bun install
41+
- name: Run tests
42+
run: bun test

registry/coder/modules/windows-rdp/tsconfig.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@
1515
"module": "ESNext",
1616

1717
"paths": {
18-
// 2025-04-16 - This seems to be a Bun-specific bug, where extending the
19-
// tsconfig file causes all paths from the base tsconfig file to be
20-
// forgotten. Node and the VSCode IDE recognize the path no problem, but
21-
// without this, the tests will fail.
18+
// 2025-04-16 - This seems to be a Bun-specific bug, where extending a
19+
// tsconfig file causes all its paths to be forgotten. The VSCode LSP
20+
// recognizes the path just fine without this, but Bun needs the mapping
21+
// to be redefined
2222
"~test": ["../../../../test/test.ts"]
2323
}
2424
}

0 commit comments

Comments
 (0)