Fix all typos and the test suite.

Author: Harsh9485

registry/harsh9485/modules/sourcegraph_amp/README.md

@@ -1,7 +1,6 @@
 ---
-
 display\_name: Sourcegraph AMP
-icon: ../../../../.icons/sourcegraph-amp.svg
+icon: ../../../../.icons/sourcegraph_amp.svg
 description: Run Sourcegraph AMP CLI in your workspace with AgentAPI integration
 verified: true
 tags: \[agent, sourcegraph, amp, ai, tasks]
@@ -13,19 +12,19 @@ Run [Sourcegraph AMP CLI](https://sourcegraph.com/amp) in your workspace to acce
 
 ```tf
 module "sourcegraph_amp" {
-  source                  = "registry.coder.com/harsh9485/sourcegraph-amp/coder"
+  source                  = "registry.coder.com/harsh9485/sourcegraph_amp/coder"
   version                 = "1.0.0"
   agent_id                = coder_agent.example.id
   sourcegraph_amp_api_key = var.sourcegraph_amp_api_key
-  install_sourcegraph-amp = true
+  install_sourcegraph_amp = true
   agentapi_version        = "latest"
 }
 ```
 
 ## Prerequisites
 
-* Include the [Coder Login](https://registry.coder.com/modules/coder-login/coder) module in your template
-* Node.js and npm are automatically installed (via NVM) if not already available
+- Include the [Coder Login](https://registry.coder.com/modules/coder-login/coder) module in your template
+- Node.js and npm are automatically installed (via NVM) if not already available
 
 ## Usage Example
 
@@ -48,7 +47,7 @@ resource "coder_agent" "main" {
 
       Always log task status to Coder.
     EOT
-    SOURCEGRAPH_AMP_TASK_PROMPT = data.coder_parameter.ai_prompt.value
+    SOURCEGRAPH_AMP_TASK_PROMPT   = data.coder_parameter.ai_prompt.value
   }
 }
 
@@ -59,33 +58,33 @@ variable "sourcegraph_amp_api_key" {
 }
 
 module "sourcegraph_amp" {
-  count                       = data.coder_workspace.me.start_count
-  source                      = "registry.coder.com/harsh9485/sourcegraph-amp/coder"
-  version                     = "1.0.0"
-  agent_id                    = coder_agent.example.id
-  sourcegraph_amp_api_key     = var.sourcegraph_amp_api_key # recommended for authenticated usage
-  install_sourcegraph-amp     = true
+  count                   = data.coder_workspace.me.start_count
+  source                  = "registry.coder.com/harsh9485/sourcegraph_amp/coder"
+  version                 = "1.0.0"
+  agent_id                = coder_agent.example.id
+  sourcegraph_amp_api_key = var.sourcegraph_amp_api_key # recommended for authenticated usage
+  install_sourcegraph_amp = true
 }
 ```
 
 ## How it Works
 
-* **Install**: Installs Sourcegraph AMP CLI using npm (installs Node.js via NVM if required)
-* **Start**: Launches AMP CLI in the specified directory, wrapped with AgentAPI to enable tasks and AI interactions
-* **Environment Variables**: Sets `SOURCEGRAPH_AMP_API_KEY` and `SOURCEGRAPH_AMP_START_DIRECTORY` for the CLI execution
+- **Install**: Installs Sourcegraph AMP CLI using npm (installs Node.js via NVM if required)
+- **Start**: Launches AMP CLI in the specified directory, wrapped with AgentAPI to enable tasks and AI interactions
+- **Environment Variables**: Sets `SOURCEGRAPH_AMP_API_KEY` and `SOURCEGRAPH_AMP_START_DIRECTORY` for the CLI execution
 
 ## Troubleshooting
 
-* If `amp` is not found, ensure `install_sourcegraph-amp = true` and your API key is valid
-* Logs are written under `/home/coder/.sourcegraph-amp-module/` (`install.log`, `agentapi-start.log`) for debugging
-* If AgentAPI fails to start, verify that your container has network access and executable permissions for the scripts
+- If `amp` is not found, ensure `install_sourcegraph_amp = true` and your API key is valid
+- Logs are written under `/home/coder/.sourcegraph_amp-module/` (`install.log`, `agentapi-start.log`) for debugging
+- If AgentAPI fails to start, verify that your container has network access and executable permissions for the scripts
 
 > \[!IMPORTANT]
 > For using **Coder Tasks** with Sourcegraph AMP, make sure to pass the `AI Prompt` parameter and set `sourcegraph_amp_api_key`.
 > This ensures task reporting and status updates work seamlessly.
 
 ## References
 
-* [Sourcegraph AMP Documentation](https://sourcegraph.com/amp)
-* [AgentAPI Documentation](https://github.com/coder/agentapi)
-* [Coder AI Agents Guide](https://coder.com/docs/tutorials/ai-agents)
+- [Sourcegraph AMP Documentation](https://sourcegraph.com/amp)
+- [AgentAPI Documentation](https://github.com/coder/agentapi)
+- [Coder AI Agents Guide](https://coder.com/docs/tutorials/ai-agents)

registry/harsh9485/modules/sourcegraph_amp/main.test.ts

@@ -68,7 +68,7 @@ const setup = async (props?: SetupProps): Promise<{ id: string }> => {
 
 setDefaultTimeout(60 * 1000);
 
-describe("Sourcegraph AMP Module", async () => {
+describe("sourcegraph-amp", async () => {
   beforeAll(async () => {
     await runTerraformInit(import.meta.dir);
   });
@@ -79,7 +79,7 @@ describe("Sourcegraph AMP Module", async () => {
     await expectAgentAPIStarted(id);
   });
 
-  test("sourcegraph-amp-api-key", async () => {
+  test("api-key", async () => {
     const apiKey = "test-api-key-123";
     const { id } = await setup({
       moduleVariables: {
@@ -88,7 +88,7 @@ describe("Sourcegraph AMP Module", async () => {
     });
     await execModuleScript(id);
     const resp = await readFileContainer(id, "/home/coder/.sourcegraph-amp-module/agentapi-start.log");
-    expect(resp).toContain("AMP version: AMP CLI mock version v1.0.0");
+    expect(resp).toContain("sourcegraph_amp_api_key provided !");
   });
 
   test("custom-folder", async () => {
@@ -117,10 +117,23 @@ describe("Sourcegraph AMP Module", async () => {
     expect(postLog).toContain("post-install-script");
   });
 
-  test("amp-not-installed", async () => {
-    const { id } = await setup({ skipAmpMock: true });
-    await execModuleScript(id);
-    const log = await readFileContainer(id, "/home/coder/.sourcegraph-amp-module/install.log");
-    expect(log).toContain("Error");
+  test("system-prompt", async () => {
+    const prompt = "this is a system prompt for AMP";
+    const {id} = await setup();
+    await execModuleScript(id, {
+      SOURCEGRAPH_AMP_SYSTEM_PROMPT : prompt,
+    });
+    const resp = await readFileContainer(id, "/home/coder/.sourcegraph-amp/SYSTEM_PROMPT.md");
+    expect(resp).toContain(prompt);
   });
+
+  test("task-prompt", async () => {
+    const prompt = "this is a task prompt for AMP";
+    const {id} = await setup();
+    await execModuleScript(id, {
+      SOURCEGRAPH_AMP_TASK_PROMPT : prompt,
+    });
+    const resp = await readFileContainer(id, "/home/coder/.sourcegraph-amp-module/agentapi-start.log");
+    expect(resp).toContain(`sourcegraph amp task prompt provided : ${prompt}`);
+  })
 });

registry/harsh9485/modules/sourcegraph_amp/main.tf

@@ -38,26 +38,26 @@ variable "icon" {
 
 variable "folder" {
   type        = string
-  description = "The folder to run sourcegraph-amp in."
+  description = "The folder to run sourcegraph_amp in."
   default     = "/home/coder"
 }
 
-variable "install_sourcegraph-amp" {
+variable "install_sourcegraph_amp" {
   type        = bool
   description = "Whether to install sourcegraph-amp."
   default     = true
 }
 
-variable "sourcegraph-amp_api_key" {
+variable "sourcegraph_amp_api_key" {
   type        = string
   description = "sourcegraph-amp API Key"
   default     = ""
 }
 
-resource "coder_env" "sourcegraph-amp_api_key" {
+resource "coder_env" "sourcegraph_amp_api_key" {
   agent_id = var.agent_id
   name     = "SOURCEGRAPH_AMP_API_KEY"
-  value    = var.sourcegraph-amp_api_key
+  value    = var.sourcegraph_amp_api_key
 }
 
 variable "install_agentapi" {
@@ -74,13 +74,13 @@ variable "agentapi_version" {
 
 variable "pre_install_script" {
   type        = string
-  description = "Custom script to run before installing sourcegraph-amp"
+  description = "Custom script to run before installing sourcegraph_amp"
   default     = null
 }
 
 variable "post_install_script" {
   type        = string
-  description = "Custom script to run after installing sourcegraph-amp."
+  description = "Custom script to run after installing sourcegraph_amp."
   default     = null
 }
 
@@ -138,7 +138,7 @@ module "agentapi" {
 
      echo -n '${base64encode(local.start_script)}' | base64 -d > /tmp/start.sh
      chmod +x /tmp/start.sh
-     SOURCEGRAPH_AMP_API_KEY='${var.sourcegraph-amp_api_key}' \
+     SOURCEGRAPH_AMP_API_KEY='${var.sourcegraph_amp_api_key}' \
      SOURCEGRAPH_AMP_START_DIRECTORY='${var.folder}' \
      /tmp/start.sh
    EOT
@@ -150,7 +150,7 @@ module "agentapi" {
 
     echo -n '${base64encode(local.install_script)}' | base64 -d > /tmp/install.sh
     chmod +x /tmp/install.sh
-    ARG_INSTALL_SOURCEGRAPH_AMP='${var.install_sourcegraph-amp}' \
+    ARG_INSTALL_SOURCEGRAPH_AMP='${var.install_sourcegraph_amp}' \
     SOURCEGRAPH_AMP_START_DIRECTORY='${var.folder}' \
     BASE_EXTENSIONS='${replace(local.base_extensions, "'", "'\\''")}' \
     /tmp/install.sh

registry/harsh9485/modules/sourcegraph_amp/scripts/install.sh

@@ -60,7 +60,6 @@ function install_sourcegraph_amp() {
 
         printf "%s Installing Sourcegraph AMP CLI...\n" "${BOLD}"
         npm install -g @sourcegraph/[email protected]
-        export AMP_API_KEY="$SOURCEGRAPH_AMP_API_KEY"
         printf "%s Successfully installed Sourcegraph AMP CLI. Version: %s\n" "${BOLD}" "$(amp --version)"
     fi
 }

registry/harsh9485/modules/sourcegraph_amp/scripts/start.sh

@@ -5,7 +5,11 @@ set -euo pipefail
 # shellcheck source=/dev/null
 source "$HOME/.bashrc"
 # shellcheck source=/dev/null
-source "$HOME/.nvm/nvm.sh"
+if [ -f "$HOME/.nvm/nvm.sh" ]; then
+  source "$HOME"/.nvm/nvm.sh
+else
+  export PATH="$HOME/.npm-global/bin:$PATH"
+fi
 
 function ensure_command() {
   command -v "$1" &>/dev/null || { echo "Error: '$1' not found." >&2; exit 1; }
@@ -23,11 +27,16 @@ else
   mkdir -p "$dir"
 fi
 cd "$dir"
-echo "Add AMP API key"
-export AMP_API_KEY=$SOURCEGRAPH_AMP_API_KEY
 
-if [ -n "$SOURCEGRAPH_AMP_TASK_PROMPT" ]; then
-    printf "Running the task prompt: %s\n" "$SOURCEGRAPH_AMP_TASK_PROMPT"
+if [ -n "$SOURCEGRAPH_AMP_API_KEY" ]; then
+    printf "sourcegraph_amp_api_key provided !\n"
+    export AMP_API_KEY=$SOURCEGRAPH_AMP_API_KEY
+else
+    printf "sourcegraph_amp_api_key not provided\n"
+fi
+
+if [ -n "${SOURCEGRAPH_AMP_TASK_PROMPT:-}" ]; then
+    printf "sourcegraph amp task prompt provided : $SOURCEGRAPH_AMP_TASK_PROMPT"
     PROMPT="Every step of the way, report tasks to Coder with proper descriptions and statuses. Your task at hand: $SOURCEGRAPH_AMP_TASK_PROMPT"
 
     # Pipe the prompt into amp, which will be run inside agentapi