feat(copilot-cli): improve GitHub authentication with multiple fallback methods

Author: DevelopmentCats

registry/coder-labs/modules/copilot-cli/README.md

@@ -26,7 +26,11 @@ module "copilot_cli" {
 
 - **Node.js v22+** and **npm v10+**
 - **Active Copilot subscription** (GitHub Copilot Pro, Pro+, Business, or Enterprise)
-- **GitHub external authentication** configured in Coder
+- **GitHub authentication** via one of:
+  - Coder external authentication (recommended)
+  - GitHub CLI (`gh auth login`)
+  - Environment token (`GITHUB_TOKEN`)
+  - Or use interactive login in Copilot CLI
 
 ## Examples
 
@@ -140,12 +144,17 @@ module "copilot_cli" {
 
 ## Authentication
 
-This module uses Coder's GitHub external authentication:
+This module works with multiple GitHub authentication methods:
 
-- Users authenticate via GitHub OAuth in the Coder UI
-- Copilot CLI automatically uses the authenticated session
-- No manual token management required
-- If not authenticated, users will be prompted to login via the `/login` slash command
+**Recommended (automatic):**
+- **Coder External Auth**: Configure GitHub external authentication in Coder for seamless OAuth token integration
+- **GitHub CLI**: Users can run `gh auth login` in their workspace
+
+**Automatic fallback:**
+- **Environment tokens**: Uses existing `GITHUB_TOKEN` if available (note: Personal Access Tokens may not work with all Copilot CLI features)
+- **Interactive login**: If no authentication is found, Copilot CLI will prompt users to login via the `/login` slash command
+
+**No setup required** - the module automatically detects and uses whatever authentication is available.
 
 ## Troubleshooting
 

registry/coder-labs/modules/copilot-cli/scripts/install.sh

@@ -49,26 +49,30 @@ install_copilot_cli() {
 }
 
 check_github_authentication() {
-  echo "Checking GitHub authentication via Coder external auth..."
+  echo "Checking GitHub authentication..."
 
   if command_exists coder; then
     if coder external-auth access-token "${ARG_EXTERNAL_AUTH_ID:-github}" > /dev/null 2>&1; then
-      echo "GitHub authentication via Coder external auth: OK"
+      echo "✓ GitHub OAuth authentication via Coder external auth"
       return 0
-    else
-      echo "WARNING: GitHub external auth not configured or expired"
-      echo "Please authenticate with GitHub in the Coder UI"
     fi
   fi
 
   if command_exists gh && gh auth status > /dev/null 2>&1; then
-    echo "GitHub CLI authentication detected as fallback"
+    echo "✓ GitHub OAuth authentication via GitHub CLI"
     return 0
   fi
 
-  echo "WARNING: No GitHub authentication found. Copilot CLI requires:"
-  echo "  - GitHub external authentication configured in Coder (recommended)"
-  echo "  - Or GitHub CLI with 'gh auth login'"
+  if [ -n "$GITHUB_TOKEN" ]; then
+    echo "✓ GitHub token found in environment"
+    echo "  Note: Copilot CLI works best with OAuth tokens from Coder external auth or 'gh auth login'"
+    return 0
+  fi
+
+  echo "⚠ No GitHub authentication detected"
+  echo "  Copilot CLI will prompt for authentication when started"
+  echo "  For seamless experience, configure GitHub external auth in Coder or run 'gh auth login'"
+  return 0
 }
 
 setup_copilot_configurations() {

registry/coder-labs/modules/copilot-cli/scripts/start.sh

@@ -87,24 +87,34 @@ setup_github_authentication() {
 
   if command_exists coder; then
     local github_token
-    if github_token=$(coder external-auth access-token "${ARG_EXTERNAL_AUTH_ID}" 2>/dev/null); then
+    if github_token=$(coder external-auth access-token "${ARG_EXTERNAL_AUTH_ID:-github}" 2>/dev/null); then
       if [ -n "$github_token" ] && [ "$github_token" != "null" ]; then
         export GITHUB_TOKEN="$github_token"
         export GH_TOKEN="$github_token"
-        echo "GitHub authentication: via Coder external auth"
+        echo "✓ Using Coder external auth OAuth token"
         return 0
       fi
     fi
   fi
 
+  # Try GitHub CLI as fallback
   if command_exists gh && gh auth status > /dev/null 2>&1; then
-    echo "GitHub authentication: via GitHub CLI"
+    echo "✓ Using GitHub CLI OAuth authentication"
     return 0
   fi
 
-  echo "WARNING: No GitHub authentication found. Copilot CLI requires authentication."
-  echo "Please ensure GitHub external auth is configured in Coder or run 'gh auth login'"
-  return 1
+  # Use existing environment variable if present
+  if [ -n "$GITHUB_TOKEN" ]; then
+    export GH_TOKEN="$GITHUB_TOKEN"
+    echo "✓ Using GitHub token from environment"
+    echo "  Note: If this is a Personal Access Token, Copilot CLI may not work properly"
+    return 0
+  fi
+  
+  echo "⚠ No GitHub authentication available"
+  echo "  Copilot CLI will prompt for login during first use"
+  echo "  Use the '/login' command in Copilot CLI to authenticate"
+  return 0  # Don't fail - let Copilot CLI handle authentication
 }
 
 start_agentapi() {