refactor: replace temp file with global array for module tagging in release script

Author: DevelopmentCats

.github/scripts/tag_release.sh

@@ -7,6 +7,8 @@
 
 set -euo pipefail
 
+MODULES_TO_TAG=()
+
 usage() {
   echo "Usage: $0"
   echo ""
@@ -35,15 +37,12 @@ extract_version_from_readme() {
   local readme_path="$1"
   local namespace="$2"
   local module_name="$3"
-  
-  if [ ! -f "$readme_path" ]; then
-    echo "❌ README not found: $readme_path" >&2
-    return 1
-  fi
-  
+
+  [ ! -f "$readme_path" ] && return 1
+
   local version_line
   version_line=$(grep -E "source\s*=\s*\"registry\.coder\.com/${namespace}/${module_name}" "$readme_path" | head -1 || echo "")
-  
+
   if [ -n "$version_line" ]; then
     local version
     version=$(echo "$version_line" | sed -n 's/.*version\s*=\s*"\([^"]*\)".*/\1/p')
@@ -52,165 +51,155 @@ extract_version_from_readme() {
       return 0
     fi
   fi
-  
+
   local fallback_version
   fallback_version=$(grep -E 'version\s*=\s*"[0-9]+\.[0-9]+\.[0-9]+"' "$readme_path" | head -1 | sed 's/.*version\s*=\s*"\([^"]*\)".*/\1/' || echo "")
-  
+
   if [ -n "$fallback_version" ]; then
     echo "$fallback_version"
     return 0
   fi
-  
+
   return 1
 }
 
 check_module_needs_tagging() {
   local namespace="$1"
   local module_name="$2"
   local readme_version="$3"
-  
+
   local tag_name="release/${namespace}/${module_name}/v${readme_version}"
-  
-  if git rev-parse --verify "$tag_name" >/dev/null 2>&1; then
+
+  if git rev-parse --verify "$tag_name" > /dev/null 2>&1; then
     return 1
   else
     return 0
   fi
 }
 
 detect_modules_needing_tags() {
-  local modules_to_tag=()
-  
+  MODULES_TO_TAG=()
+
   echo "🔍 Scanning all modules for missing release tags..."
   echo ""
-  
 
   local all_modules
   all_modules=$(find registry -type d -path "*/modules/*" -mindepth 3 -maxdepth 3 | sort -u || echo "")
-  
-  if [ -z "$all_modules" ]; then
+
+  [ -z "$all_modules" ] && {
     echo "❌ No modules found to check"
     return 1
-  fi
-  
+  }
+
   local total_checked=0
   local needs_tagging=0
-  
+
   while IFS= read -r module_path; do
     if [ -z "$module_path" ]; then continue; fi
-    
+
     local namespace
     namespace=$(echo "$module_path" | cut -d'/' -f2)
     local module_name
     module_name=$(echo "$module_path" | cut -d'/' -f4)
-    
+
     total_checked=$((total_checked + 1))
-    
+
     local readme_path="$module_path/README.md"
     local readme_version
-    
+
     if ! readme_version=$(extract_version_from_readme "$readme_path" "$namespace" "$module_name"); then
       echo "⚠️  $namespace/$module_name: No version found in README, skipping"
       continue
     fi
-    
+
     if ! validate_version "$readme_version"; then
       echo "⚠️  $namespace/$module_name: Invalid version format '$readme_version', skipping"
       continue
     fi
-    
+
     if check_module_needs_tagging "$namespace" "$module_name" "$readme_version"; then
       echo "📦 $namespace/$module_name: v$readme_version (needs tag)"
-      modules_to_tag+=("$module_path:$namespace:$module_name:$readme_version")
+      MODULES_TO_TAG+=("$module_path:$namespace:$module_name:$readme_version")
       needs_tagging=$((needs_tagging + 1))
     else
       echo "✅ $namespace/$module_name: v$readme_version (already tagged)"
     fi
-    
+
   done <<< "$all_modules"
-  
+
   echo ""
   echo "📊 Summary: $needs_tagging of $total_checked modules need tagging"
   echo ""
-  
-  if [ $needs_tagging -eq 0 ]; then
+
+  [ $needs_tagging -eq 0 ] && {
     echo "🎉 All modules are up to date! No tags needed."
     return 0
-  fi
-  
+  }
 
   echo "## Tags to be created:"
-  for module_info in "${modules_to_tag[@]}"; do
+  for module_info in "${MODULES_TO_TAG[@]}"; do
     IFS=':' read -r module_path namespace module_name version <<< "$module_info"
     echo "- \`release/$namespace/$module_name/v$version\`"
   done
   echo ""
-  
 
-  printf '%s\n' "${modules_to_tag[@]}" > /tmp/modules_to_tag.txt
-  
   return 0
 }
 
 create_and_push_tags() {
-  if [ ! -f /tmp/modules_to_tag.txt ]; then
+  [ ${#MODULES_TO_TAG[@]} -eq 0 ] && {
     echo "❌ No modules to tag found"
     return 1
-  fi
-  
+  }
+
   local current_commit
   current_commit=$(git rev-parse HEAD)
-  
+
   echo "🏷️  Creating release tags for commit: $current_commit"
   echo ""
-  
+
   local created_tags=0
   local failed_tags=0
-  
-  while IFS= read -r module_info; do
-    if [ -z "$module_info" ]; then continue; fi
-    
+
+  for module_info in "${MODULES_TO_TAG[@]}"; do
     IFS=':' read -r module_path namespace module_name version <<< "$module_info"
-    
+
     local tag_name="release/$namespace/$module_name/v$version"
     local tag_message="Release $namespace/$module_name v$version"
-    
+
     echo "Creating tag: $tag_name"
-    
+
     if git tag -a "$tag_name" -m "$tag_message" "$current_commit"; then
       echo "✅ Created: $tag_name"
       created_tags=$((created_tags + 1))
     else
       echo "❌ Failed to create: $tag_name"
       failed_tags=$((failed_tags + 1))
     fi
-    
-  done < /tmp/modules_to_tag.txt
-  
+  done
+
   echo ""
   echo "📊 Tag creation summary:"
   echo "  Created: $created_tags"
   echo "  Failed: $failed_tags"
   echo ""
-  
-  if [ $created_tags -eq 0 ]; then
+
+  [ $created_tags -eq 0 ] && {
     echo "❌ No tags were created successfully"
     return 1
-  fi
-  
+  }
+
   echo "🚀 Pushing tags to origin..."
-  
+
   local pushed_tags=0
   local failed_pushes=0
-  
-  while IFS= read -r module_info; do
-    if [ -z "$module_info" ]; then continue; fi
-    
+
+  for module_info in "${MODULES_TO_TAG[@]}"; do
     IFS=':' read -r module_path namespace module_name version <<< "$module_info"
-    
+
     local tag_name="release/$namespace/$module_name/v$version"
-    
-    if git rev-parse --verify "$tag_name" >/dev/null 2>&1; then
+
+    if git rev-parse --verify "$tag_name" > /dev/null 2>&1; then
       echo "Pushing: $tag_name"
       if git push origin "$tag_name"; then
         echo "✅ Pushed: $tag_name"
@@ -220,15 +209,14 @@ create_and_push_tags() {
         failed_pushes=$((failed_pushes + 1))
       fi
     fi
-    
-  done < /tmp/modules_to_tag.txt
-  
+  done
+
   echo ""
   echo "📊 Push summary:"
   echo "  Pushed: $pushed_tags"
   echo "  Failed: $failed_pushes"
   echo ""
-  
+
   if [ $pushed_tags -gt 0 ]; then
     echo "🎉 Successfully created and pushed $pushed_tags release tags!"
     echo ""
@@ -237,55 +225,43 @@ create_and_push_tags() {
     echo "  - Monitor the registry website for updates"
     echo "  - Check GitHub releases for any issues"
   fi
-  
 
-  rm -f /tmp/modules_to_tag.txt
-  
   return 0
 }
 
 main() {
-  if [ $# -gt 0 ]; then
-    usage
-  fi
-  
+  [ $# -gt 0 ] && usage
+
   echo "🚀 Coder Registry Tag Release Script"
   echo "Operating on commit: $(git rev-parse HEAD)"
   echo ""
-  
 
-  if ! git rev-parse --git-dir >/dev/null 2>&1; then
+  if ! git rev-parse --git-dir > /dev/null 2>&1; then
     echo "❌ Not in a git repository"
     exit 1
   fi
-  
 
-  if ! detect_modules_needing_tags; then
-    exit 1
-  fi
-  
+  detect_modules_needing_tags || exit 1
 
-  if [ ! -f /tmp/modules_to_tag.txt ] || [ ! -s /tmp/modules_to_tag.txt ]; then
+  [ ${#MODULES_TO_TAG[@]} -eq 0 ] && {
     echo "✨ No modules need tagging. All done!"
     exit 0
-  fi
-  
+  }
 
   echo ""
   echo "❓ Do you want to proceed with creating and pushing these release tags?"
   echo "   This will create git tags and push them to the remote repository."
   echo ""
   read -p "Continue? [y/N]: " -r response
-  
+
   case "$response" in
-    [yY]|[yY][eE][sS])
+    [yY] | [yY][eE][sS])
       echo ""
       create_and_push_tags
       ;;
     *)
       echo ""
       echo "🚫 Operation cancelled by user"
-      rm -f /tmp/modules_to_tag.txt
       exit 0
       ;;
   esac