feat: add vscode-desktop-core module
#278
Conversation
There was a problem hiding this comment.
Thanks a lot @phorcys420. This will significantly enhance the DevEX for module development and maintenance.
|
@matifali I want to add a |
|
Nice. But I think exposing MCPs separately would make more sense given how popular they are. |
Co-authored-by: Atif Ali <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new vscode-desktop-core module to centralize VSCode desktop IDE logic across multiple modules, acting as a building block similar to how AgentAPI functions for other modules. This effort aims to reduce code duplication and maintenance burden.
- Creates a core Terraform module for VSCode desktop IDE functionality
- Provides a reusable foundation for VSCode-based IDE modules
- Includes comprehensive test coverage and documentation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| registry/coder/modules/vscode-desktop-core/main.tf | Core Terraform module implementation with variables, data sources, and coder_app resource |
| registry/coder/modules/vscode-desktop-core/main.test.ts | Comprehensive test suite covering various configuration scenarios |
| registry/coder/modules/vscode-desktop-core/README.md | Documentation with usage examples and caution about direct usage |
Co-authored-by: Copilot <[email protected]>
This PR introduces a new
vscode-desktop-coremodule that acts similarly as AgentAPI does for other modules as an effort to centralize the logic.This will help with avoiding maintaining multiple modules that do the same thing. I will follow shortly with a PR for a
vscode-web-coremodule to centralize the logic forvscode-webandcode-serveras we've had issues where both would behave differently due to forgetting to update one or the other.This will also help make the amount of effort lower if we ever need to implement a module for another vendor (or if a community member does).
Modules update in #279