chore(release): always use GitHub username for author mentions #373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify author mention logic in release changelog generation:
.author.login
from the commit API when building the changelog entries.commit.author.name
to avoid invalid@
mentions when only a name is availableRationale: All commits land via PRs that are linked to GitHub users, so
.author.login
should always be available.Test plan:
If any commit ever lacks
.author.login
, the entry would produce an empty mention; but given our policy this should not occur.