fix: use option Name instead of Flag when emitting missing error

ammario · ammario · commit 888d43498ac7 · 2024-04-25T13:05:19.000-05:00
Some options (e.g. environment-controlled secrets) have no flag name,
leading to a confusing error message.
diff --git a/command.go b/command.go
@@ -392,7 +392,12 @@ func (inv *Invocation) run(state *runState) error {
 	var missing []string
 	for _, opt := range inv.Command.Options {
 		if opt.Required && opt.ValueSource == ValueSourceNone {
-			missing = append(missing, opt.Flag)
+			name := opt.Name
+			// use flag as a fallback if name is empty
+			if name == "" {
+				name = opt.Flag
+			}
+			missing = append(missing, name)
 		}
 	}
 	// Don't error for missing flags if `--help` was supplied.

Original file line number	Diff line number	Diff line change
`@@ -392,7 +392,12 @@ func (inv Invocation) run(state runState) error {`
`392`	`392`	`var missing []string`
`393`	`393`	`for _, opt := range inv.Command.Options {`
`394`	`394`	`if opt.Required && opt.ValueSource == ValueSourceNone {`
`395`		`- missing = append(missing, opt.Flag)`
	`395`	`+ name := opt.Name`
	`396`	`+ // use flag as a fallback if name is empty`
	`397`	`+ if name == "" {`
	`398`	`+ name = opt.Flag`
	`399`	`+ }`
	`400`	`+ missing = append(missing, name)`
`396`	`401`	`}`
`397`	`402`	`}`
`398`	`403`	// Don't error for missing flags if `--help` was supplied.