chore: add max validation of 604800 seconds (7 days) for invalidate_after_secs to prevent stale prebuilds

Author: ssncferreira

provider/workspace_preset.go

@@ -99,11 +99,12 @@ func workspacePresetDataSource() *schema.Resource {
 							Elem: &schema.Resource{
 								Schema: map[string]*schema.Schema{
 									"invalidate_after_secs": {
-										Type:         schema.TypeInt,
-										Description:  "Time in seconds after which an unclaimed prebuild is considered expired and eligible for cleanup.",
-										Required:     true,
-										ForceNew:     true,
-										ValidateFunc: validation.IntAtLeast(0),
+										Type:        schema.TypeInt,
+										Description: "Time in seconds after which an unclaimed prebuild is considered expired and eligible for cleanup.",
+										Required:    true,
+										ForceNew:    true,
+										// Ensure invalidation is between 0 and 604800 seconds (7 days) to prevent stale prebuilds
+										ValidateFunc: validation.IntBetween(0, 604800),
 									},
 								},
 							},

provider/workspace_preset_test.go

@@ -189,6 +189,23 @@ func TestWorkspacePreset(t *testing.T) {
 				return nil
 			},
 		},
+		{
+			Name: "Prebuilds block with cache_invalidation.invalidate_after_secs set to 15 days (exceeds 7 days limit)",
+			Config: `
+			data "coder_workspace_preset" "preset_1" {
+				name = "preset_1"
+				parameters = {
+					"region" = "us-east1-a"
+				}
+				prebuilds {
+					instances = 1
+					cache_invalidation {
+						invalidate_after_secs = 1296000
+					}
+				}
+			}`,
+			ExpectError: regexp.MustCompile(`expected prebuilds.0.cache_invalidation.0.invalidate_after_secs to be in the range \(0 - 604800\), got 1296000`),
+		},
 		{
 			Name: "Prebuilds is set with a cache_invalidation field with its required fields and an unexpected argument",
 			Config: `