improve testing logic

Author: defelmnq

provider/agent.go

@@ -277,14 +277,13 @@ func agentResource() *schema.Resource {
 										Type:        schema.TypeBool,
 										Description: "Enable memory monitoring for this agent.",
 										ForceNew:    true,
-										Optional:    true,
-										Default:     true,
+										Required:    true,
 									},
 									"threshold": {
 										Type:        schema.TypeInt,
 										Description: "The memory usage threshold in percentage at which to trigger an alert. Value should be between 0 and 100.",
 										ForceNew:    true,
-										Optional:    true,
+										Required:    true,
 									},
 								},
 							},
@@ -300,20 +299,19 @@ func agentResource() *schema.Resource {
 										Type:        schema.TypeString,
 										Description: "The path of the volume to monitor.",
 										ForceNew:    true,
-										Optional:    true,
+										Required:    true,
 									},
 									"enabled": {
 										Type:        schema.TypeBool,
 										Description: "Enable volume monitoring for this agent.",
 										ForceNew:    true,
-										Optional:    true,
-										Default:     true,
+										Required:    true,
 									},
 									"threshold": {
 										Type:        schema.TypeInt,
 										Description: "The volume usage threshold in percentage at which to trigger an alert. Value should be between 0 and 100.",
 										ForceNew:    true,
-										Optional:    true,
+										Required:    true,
 									},
 								},
 							},

provider/agent_test.go

@@ -264,6 +264,45 @@ func TestAgent_ResourcesMonitoring(t *testing.T) {
 	})
 }
 
+func TestAgent_ResourcesMonitoring_OnlyMemory(t *testing.T) {
+	t.Parallel()
+	resource.Test(t, resource.TestCase{
+		ProviderFactories: coderFactory(),
+		IsUnitTest:        true,
+		Steps: []resource.TestStep{{
+			Config: `
+				provider "coder" {
+					url = "https://example.com"
+				}
+				resource "coder_agent" "dev" {
+					os = "linux"
+					arch = "amd64"
+					resources_monitoring {
+						memory {
+							enabled = true
+							threshold = 80
+						}
+					}
+				}`,
+			Check: func(state *terraform.State) error {
+				require.Len(t, state.Modules, 1)
+				require.Len(t, state.Modules[0].Resources, 1)
+
+				resource := state.Modules[0].Resources["coder_agent.dev"]
+				require.NotNil(t, resource)
+
+				t.Logf("resource: %v", resource.Primary.Attributes)
+
+				attr := resource.Primary.Attributes
+				require.Equal(t, "1", attr["resources_monitoring.#"])
+				require.Equal(t, "1", attr["resources_monitoring.0.memory.#"])
+				require.Equal(t, "80", attr["resources_monitoring.0.memory.0.threshold"])
+				return nil
+			},
+		}},
+	})
+}
+
 func TestAgent_MetadataDuplicateKeys(t *testing.T) {
 	t.Parallel()
 	resource.Test(t, resource.TestCase{