|
1 | 1 | package helpers |
2 | 2 |
|
3 | 3 | import ( |
4 | | - "strings" |
5 | 4 | "testing" |
| 5 | + |
| 6 | + "github.com/stretchr/testify/require" |
6 | 7 | ) |
7 | 8 |
|
8 | 9 | func TestValidateURL(t *testing.T) { |
@@ -137,27 +138,17 @@ func TestValidateURL(t *testing.T) { |
137 | 138 | warnings, errors := ValidateURL(tt.value, tt.label) |
138 | 139 |
|
139 | 140 | if tt.expectError { |
140 | | - if len(errors) == 0 { |
141 | | - t.Errorf("expected an error but got none") |
142 | | - return |
143 | | - } |
| 141 | + require.NotEmpty(t, errors, "expected an error but got none") |
144 | 142 |
|
145 | 143 | if tt.errorContains != "" { |
146 | | - errorStr := errors[0].Error() |
147 | | - if !strings.Contains(errorStr, tt.errorContains) { |
148 | | - t.Errorf("expected error to contain %q, got %q", tt.errorContains, errorStr) |
149 | | - } |
| 144 | + require.Contains(t, errors[0].Error(), tt.errorContains) |
150 | 145 | } |
151 | 146 | } else { |
152 | | - if len(errors) > 0 { |
153 | | - t.Errorf("expected no errors but got: %v", errors) |
154 | | - } |
155 | | - |
156 | | - // Should always return nil for warnings |
157 | | - if warnings != nil { |
158 | | - t.Errorf("expected warnings to be nil, got %v", warnings) |
159 | | - } |
| 147 | + require.Empty(t, errors, "expected no errors but got: %v", errors) |
160 | 148 | } |
| 149 | + |
| 150 | + // Should always return nil for warnings |
| 151 | + require.Nil(t, warnings, "expected warnings to be nil, got %v", warnings) |
161 | 152 | }) |
162 | 153 | } |
163 | 154 | } |
0 commit comments