Skip to content

Commit f686169

Browse files
committed
Change token to agent_id
1 parent 234129b commit f686169

File tree

3 files changed

+19
-12
lines changed

3 files changed

+19
-12
lines changed

docs/resources/external_agent.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Define an external agent to be used in a workspace.
1717

1818
### Required
1919

20-
- `token` (String, Sensitive) Set the environment variable `CODER_AGENT_TOKEN` with this token to authenticate an agent.
20+
- `agent_id` (String) The `id` property of a `coder_agent` resource to associate with.
2121

2222
### Read-Only
2323

provider/external_agent.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,11 @@ func externalAgentResource() *schema.Resource {
2020
ReadContext: schema.NoopContext,
2121
DeleteContext: schema.NoopContext,
2222
Schema: map[string]*schema.Schema{
23-
"token": {
23+
"agent_id": {
24+
Type: schema.TypeString,
25+
Description: "The `id` property of a `coder_agent` resource to associate with.",
2426
ForceNew: true,
2527
Required: true,
26-
Sensitive: true,
27-
Description: "Set the environment variable `CODER_AGENT_TOKEN` with this token to authenticate an agent.",
28-
Type: schema.TypeString,
2928
},
3029
},
3130
}

provider/external_agent_test.go

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,18 +21,26 @@ func TestExternalAgent(t *testing.T) {
2121
Config: `
2222
provider "coder" {
2323
}
24+
25+
resource "coder_agent" "dev" {
26+
os = "linux"
27+
arch = "amd64"
28+
}
2429
25-
resource "coder_external_agent" "main" {
26-
token = "token"
30+
resource "coder_external_agent" "dev" {
31+
agent_id = coder_agent.dev.id
2732
}
2833
`,
2934
Check: func(state *terraform.State) error {
3035
require.Len(t, state.Modules, 1)
31-
resource := state.Modules[0].Resources["coder_external_agent.main"]
32-
require.NotNil(t, resource)
33-
value := resource.Primary.Attributes["token"]
34-
require.NotNil(t, value)
35-
require.Greater(t, len(value), 0)
36+
require.Len(t, state.Modules[0].Resources, 2)
37+
38+
agentResource := state.Modules[0].Resources["coder_agent.dev"]
39+
require.NotNil(t, agentResource)
40+
externalAgentResource := state.Modules[0].Resources["coder_external_agent.dev"]
41+
require.NotNil(t, externalAgentResource)
42+
43+
require.Equal(t, agentResource.Primary.Attributes["id"], externalAgentResource.Primary.Attributes["agent_id"])
3644
return nil
3745
},
3846
}},

0 commit comments

Comments
 (0)