Skip to content

ci: check for unstaged files correctly during gen #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2024
Merged

ci: check for unstaged files correctly during gen #142

merged 1 commit into from
Nov 15, 2024

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Nov 15, 2024 •
edited
Loading

Discovered in #141 that CI could pass even when make gen could produce a new file.

@ethanndickson Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson marked this pull request as ready for review November 15, 2024 03:20
@ethanndickson ethanndickson merged commit 1c5fef0 into main Nov 15, 2024
14 checks passed
@ethanndickson ethanndickson deleted the ethan/fix-gen-ci branch November 15, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deansheather deansheather Awaiting requested review from deansheather

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ethanndickson