helpers: remove unused allEnvKeys

johnstcn · johnstcn · commit 06127ae8824e · 2024-09-04T14:22:20.000+01:00
diff --git a/internal/provider/helpers.go b/internal/provider/helpers.go
@@ -208,12 +208,10 @@ func overrideOptionsFromExtraEnv(opts *eboptions.Options, extraEnv map[string]st
 // It will not set certain options, such as ENVBUILDER_CACHE_REPO and ENVBUILDER_GIT_URL.
 // It will also not handle legacy Envbuilder options (i.e. those not prefixed with ENVBUILDER_).
 func computeEnvFromOptions(opts eboptions.Options, extraEnv map[string]string) map[string]string {
-	allEnvKeys := make(map[string]struct{})
 	for _, opt := range opts.CLI() {
 		if opt.Env == "" {
 			continue
 		}
-		allEnvKeys[opt.Env] = struct{}{}
 	}
 
 	computed := make(map[string]string)

Original file line number	Diff line number	Diff line change
`@@ -208,12 +208,10 @@ func overrideOptionsFromExtraEnv(opts *eboptions.Options, extraEnv map[string]st`
`208`	`208`	`// It will not set certain options, such as ENVBUILDER_CACHE_REPO and ENVBUILDER_GIT_URL.`
`209`	`209`	`// It will also not handle legacy Envbuilder options (i.e. those not prefixed with ENVBUILDER_).`
`210`	`210`	`func computeEnvFromOptions(opts eboptions.Options, extraEnv map[string]string) map[string]string {`
`211`		`- allEnvKeys := make(map[string]struct{})`
`212`	`211`	`for _, opt := range opts.CLI() {`
`213`	`212`	`if opt.Env == "" {`
`214`	`213`	`continue`
`215`	`214`	`}`
`216`		`- allEnvKeys[opt.Env] = struct{}{}`
`217`	`215`	`}`
`218`	`216`
`219`	`217`	`computed := make(map[string]string)`