finish up using the argument for the log directory

Author: bcpeinhardt

CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## Unreleased
 
+### Changed
+
+- Make proxyLogDirectory a setting in the vscode extension rather than using the default for vscode,
+  and only send the --log-dir argument to coder/coder if the value is set.
+
 ## [v1.3.1](https://github.com/coder/vscode-coder/releases/tag/v1.3.1) (2024-07-15)
 
 ### Fixed

src/remote.ts

@@ -638,9 +638,9 @@ export class Remote {
     if (supportsCoderAgentLogDirFlag(this.coderVersion)) {
       const logDir = expandPath(String(vscode.workspace.getConfiguration().get("coder.proxyLogDirectory") ?? "").trim())
       if (logDir) {
-        await fs.mkdir(this.storage.getLogPath(), { recursive: true })
-        logArg = ` --log-dir ${escape(this.storage.getLogPath())}`
-        this.storage.writeToCoderOutputChannel(`Your logs are being written to ${this.storage.getLogPath()}`)
+        await fs.mkdir(logDir, { recursive: true })
+        logArg = ` --log-dir ${escape(logDir)}`
+        this.storage.writeToCoderOutputChannel(`Your logs are being written to ${logDir}`)
       }
     }
     const sshValues: SSHValues = {