Fix test waitgroups

Author: cmoog

localexec_test.go

@@ -26,8 +26,8 @@ func testExecer(ctx context.Context, t *testing.T, execer Execer) {
 	assert.Success(t, "start local cmd", err)
 
 	var wg sync.WaitGroup
+	wg.Add(1)
 	go func() {
-		wg.Add(1)
 		defer wg.Done()
 
 		stdout, err := ioutil.ReadAll(process.Stdout())
@@ -37,8 +37,8 @@ func testExecer(ctx context.Context, t *testing.T, execer Execer) {
 
 		assert.Equal(t, "stdout", wd, strings.TrimSuffix(string(stdout), "\n"))
 	}()
+	wg.Add(1)
 	go func() {
-		wg.Add(1)
 		defer wg.Done()
 
 		stderr, err := ioutil.ReadAll(process.Stderr())

tty_test.go

@@ -31,20 +31,20 @@ func testTTY(ctx context.Context, t *testing.T, e Execer) {
 	})
 	assert.Success(t, "start bash", err)
 	var wg sync.WaitGroup
+	wg.Add(1)
 	go func() {
-		wg.Add(1)
 		defer wg.Done()
 
 		stdout, err := ioutil.ReadAll(process.Stdout())
 		assert.Success(t, "read stdout", err)
 
 		t.Logf("bash tty stdout = %s", stdout)
 		prompt := string(stdout)
-		assert.True(t, `bash "$" prompt found`,
+		assert.True(t, `bash "$" or "#" prompt found`,
 			strings.HasSuffix(prompt, "$ ") || strings.HasSuffix(prompt, "# "))
 	}()
+	wg.Add(1)
 	go func() {
-		wg.Add(1)
 		defer wg.Done()
 
 		stderr, err := ioutil.ReadAll(process.Stderr())