fix: properly detect pty changes on windows

Author: coadler

.github/workflows/release.yaml

@@ -14,7 +14,7 @@ permissions:
 
 jobs:
   goreleaser:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-latest-8-cores
     steps:
       - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
         with:

.goreleaser.yaml

@@ -46,4 +46,4 @@ signs:
 # release:
 #   draft: true
 changelog:
-  skip: true
+  use: github-native

cmd/wush/send.go

@@ -8,23 +8,23 @@ import (
 	"log/slog"
 	"net/netip"
 	"os"
-	"os/signal"
 	"time"
 
 	"github.com/charmbracelet/huh"
-	"github.com/coder/coder/v2/pty"
-	"github.com/coder/serpent"
-	"github.com/coder/wush/cliui"
-	"github.com/coder/wush/overlay"
-	"github.com/coder/wush/tsserver"
 	"github.com/mattn/go-isatty"
 	"golang.org/x/crypto/ssh"
-	"golang.org/x/sys/unix"
 	"golang.org/x/term"
 	"golang.org/x/xerrors"
 	"tailscale.com/client/tailscale"
 	"tailscale.com/net/netns"
 	"tailscale.com/tailcfg"
+
+	"github.com/coder/coder/v2/pty"
+	"github.com/coder/serpent"
+	"github.com/coder/wush/cliui"
+	"github.com/coder/wush/overlay"
+	"github.com/coder/wush/tsserver"
+	xssh "github.com/coder/wush/xssh"
 )
 
 func sendCmd() *serpent.Command {
@@ -156,7 +156,7 @@ func sendCmd() *serpent.Command {
 					_ = pty.RestoreTerminal(stdoutFile.Fd(), outState)
 				}()
 
-				windowChange := listenWindowSize(ctx)
+				windowChange := xssh.ListenWindowSize(ctx)
 				go func() {
 					for {
 						select {
@@ -207,16 +207,6 @@ func sendCmd() *serpent.Command {
 	}
 }
 
-func listenWindowSize(ctx context.Context) <-chan os.Signal {
-	windowSize := make(chan os.Signal, 1)
-	signal.Notify(windowSize, unix.SIGWINCH)
-	go func() {
-		<-ctx.Done()
-		signal.Stop(windowSize)
-	}()
-	return windowSize
-}
-
 func waitUntilHasPeerHasIP(ctx context.Context, lc *tailscale.LocalClient) (netip.Addr, error) {
 	for {
 		select {

xssh/windowsize_other.go

@@ -0,0 +1,22 @@
+//go:build !windows
+// +build !windows
+
+package ssh
+
+import (
+	"context"
+	"os"
+	"os/signal"
+
+	"golang.org/x/sys/unix"
+)
+
+func ListenWindowSize(ctx context.Context) <-chan os.Signal {
+	windowSize := make(chan os.Signal, 1)
+	signal.Notify(windowSize, unix.SIGWINCH)
+	go func() {
+		<-ctx.Done()
+		signal.Stop(windowSize)
+	}()
+	return windowSize
+}

xssh/windowsize_windows.go

@@ -0,0 +1,27 @@
+//go:build windows
+// +build windows
+
+package ssh
+
+import (
+	"context"
+	"os"
+	"time"
+)
+
+func ListenWindowSize(ctx context.Context) <-chan os.Signal {
+	windowSize := make(chan os.Signal, 3)
+	ticker := time.NewTicker(time.Second)
+	go func() {
+		defer ticker.Stop()
+		for {
+			select {
+			case <-ctx.Done():
+				return
+			case <-ticker.C:
+			}
+			windowSize <- nil
+		}
+	}()
+	return windowSize
+}