fix: add support for missing package

Prior to this, a proto file without a package declaration didn't supported any operation as parser required that a package be present. For missing package we now consider . as package

Author: coder3101

sample/test.proto

@@ -9,3 +9,17 @@ message SomeMessage {
 
   CustomType another = 2;
 }
+
+message A {
+  // B is a b
+  message B {
+
+  }
+
+  B b = 1;
+}
+
+message C {
+  A.B ab = 1;
+  A a = 2;
+}

src/lsp.rs

@@ -135,18 +135,13 @@ impl LanguageServer for ProtoLanguageServer {
 
         let content = self.state.get_content(&uri);
         let hv = tree.get_hoverable_at_position(&pos, content.as_bytes());
-        let current_package_name = tree.get_package_name(content.as_bytes());
+        let current_package_name = tree.get_package_name(content.as_bytes()).unwrap_or(".");
 
         let Some(hv) = hv else {
             error!(uri=%uri, "failed to get hoverable identifier");
             return Box::pin(async move { Ok(None) });
         };
 
-        let Some(current_package_name) = current_package_name else {
-            error!(uri=%uri, "failed to get package name");
-            return Box::pin(async move { Ok(None) });
-        };
-
         let ipath = self.configs.get_include_paths(&uri).unwrap_or_default();
         let result = self.state.hover(&ipath, current_package_name.as_ref(), hv);
 
@@ -220,10 +215,7 @@ impl LanguageServer for ProtoLanguageServer {
 
         let content = self.state.get_content(&uri);
 
-        let Some(current_package) = tree.get_package_name(content.as_bytes()) else {
-            error!(uri=%uri, "failed to get package name");
-            return Box::pin(async move { Ok(None) });
-        };
+        let current_package = tree.get_package_name(content.as_bytes()).unwrap_or(".");
 
         let Some((edit, otext, ntext)) = tree.rename_tree(&pos, &new_name, content.as_bytes())
         else {
@@ -240,7 +232,6 @@ impl LanguageServer for ProtoLanguageServer {
         let progress_sender = work_done_token.map(|token| self.with_report_progress(token));
 
         let mut h = HashMap::new();
-        h.insert(tree.uri.clone(), edit);
         h.extend(self.state.rename_fields(
             current_package,
             &otext,
@@ -249,6 +240,8 @@ impl LanguageServer for ProtoLanguageServer {
             progress_sender,
         ));
 
+        h.entry(tree.uri).or_insert(edit.clone()).extend(edit);
+
         let response = Some(WorkspaceEdit {
             changes: Some(h),
             ..Default::default()
@@ -272,10 +265,7 @@ impl LanguageServer for ProtoLanguageServer {
 
         let content = self.state.get_content(&uri);
 
-        let Some(current_package) = tree.get_package_name(content.as_bytes()) else {
-            error!(uri=%uri, "failed to get package name");
-            return Box::pin(async move { Ok(None) });
-        };
+        let current_package = tree.get_package_name(content.as_bytes()).unwrap_or(".");
 
         let Some((mut refs, otext)) = tree.reference_tree(&pos, content.as_bytes()) else {
             error!(uri=%uri, "failed to find references in a tree");
@@ -321,18 +311,13 @@ impl LanguageServer for ProtoLanguageServer {
 
         let content = self.state.get_content(&uri);
         let jump = tree.get_jumpable_at_position(&pos, content.as_bytes());
-        let current_package_name = tree.get_package_name(content.as_bytes());
+        let current_package_name = tree.get_package_name(content.as_bytes()).unwrap_or(".");
 
         let Some(jump) = jump else {
             error!(uri=%uri, "failed to get jump identifier");
             return Box::pin(async move { Ok(None) });
         };
 
-        let Some(current_package_name) = current_package_name else {
-            error!(uri=%uri, "failed to get package name");
-            return Box::pin(async move { Ok(None) });
-        };
-
         let ipath = self.configs.get_include_paths(&uri).unwrap_or_default();
         let locations = self
             .state
@@ -407,9 +392,9 @@ impl LanguageServer for ProtoLanguageServer {
             return ControlFlow::Continue(());
         };
 
-        if let Some(diagnostics) = self
-            .state
-            .upsert_file(&uri, content, &ipath, 8, &pconf.config, true)
+        if let Some(diagnostics) =
+            self.state
+                .upsert_file(&uri, content, &ipath, 8, &pconf.config, true)
         {
             if let Err(e) = self.client.publish_diagnostics(diagnostics) {
                 error!(error=%e, "failed to publish diagnostics")
@@ -434,9 +419,9 @@ impl LanguageServer for ProtoLanguageServer {
             return ControlFlow::Continue(());
         };
 
-        if let Some(diagnostics) = self
-            .state
-            .upsert_file(&uri, content, &ipath, 8, &pconf.config, true)
+        if let Some(diagnostics) =
+            self.state
+                .upsert_file(&uri, content, &ipath, 8, &pconf.config, true)
         {
             if let Err(e) = self.client.publish_diagnostics(diagnostics) {
                 error!(error=%e, "failed to publish diagnostics")
@@ -457,7 +442,10 @@ impl LanguageServer for ProtoLanguageServer {
             return ControlFlow::Continue(());
         };
 
-        if let Some(diagnostics) = self.state.upsert_file(&uri, content, &ipath, 8, &pconf.config, false) {
+        if let Some(diagnostics) =
+            self.state
+                .upsert_file(&uri, content, &ipath, 8, &pconf.config, false)
+        {
             if let Err(e) = self.client.publish_diagnostics(diagnostics) {
                 error!(error=%e, "failed to publish diagnostics")
             }

src/parser/definition.rs

@@ -11,6 +11,7 @@ impl ParsedTree {
         self.definition_impl(identifier, self.tree.root_node(), &mut results, content);
         results
     }
+
     fn definition_impl(
         &self,
         identifier: &str,

src/state.rs

@@ -68,7 +68,7 @@ impl ProtoLanguageState {
             .filter(|tree| {
                 let content = self.get_content(&tree.uri);
                 tree.get_package_name(content.as_bytes())
-                    .unwrap_or_default()
+                    .unwrap_or(".")
                     == package
             })
             .map(ToOwned::to_owned)

src/utils.rs

@@ -37,7 +37,6 @@ pub fn is_inner_identifier(s: &str) -> bool {
 }
 
 pub fn split_identifier_package(s: &str) -> (&str, &str) {
-    // trim beginning dots, some use `.` prefix for fully qualified field names
     let s = s.trim_start_matches(".");
     if is_inner_identifier(s) || !s.contains('.') {
         return ("", s);

src/workspace/rename.rs

@@ -23,7 +23,7 @@ impl ProtoLanguageState {
             .into_iter()
             .fold(HashMap::new(), |mut h, tree| {
                 let content = self.get_content(&tree.uri);
-                let package = tree.get_package_name(content.as_ref()).unwrap_or_default();
+                let package = tree.get_package_name(content.as_ref()).unwrap_or(".");
                 let mut old = identifier.to_string();
                 let mut new = new_text.to_string();
                 if current_package != package {
@@ -52,7 +52,7 @@ impl ProtoLanguageState {
             .into_iter()
             .fold(Vec::<Location>::new(), |mut v, tree| {
                 let content = self.get_content(&tree.uri);
-                let package = tree.get_package_name(content.as_ref()).unwrap_or_default();
+                let package = tree.get_package_name(content.as_ref()).unwrap_or(".");
                 let mut old = identifier.to_owned();
                 if current_package != package {
                     old = format!("{current_package}.{old}");