feat: Add hover docs for builtin types

Author: coder3101

src/nodekind.rs

@@ -8,7 +8,6 @@ pub enum NodeKind {
     Message,
     EnumName,
     FieldName,
-    FieldBuiltinTypeName,
     ServiceName,
     RpcName,
     PackageName,
@@ -24,7 +23,6 @@ impl NodeKind {
             NodeKind::Message => "message",
             NodeKind::EnumName => "enum_name",
             NodeKind::FieldName => "message_or_enum_type",
-            NodeKind::FieldBuiltinTypeName => "type",
             NodeKind::ServiceName => "service_name",
             NodeKind::RpcName => "rpc_name",
             NodeKind::PackageName => "full_ident",
@@ -59,10 +57,6 @@ impl NodeKind {
         n.kind() == Self::FieldName.as_str()
     }
 
-    pub fn is_builtin_field_type(n: &Node) -> bool {
-        n.kind() == Self::FieldBuiltinTypeName.as_str()
-    }
-
     pub fn is_userdefined(n: &Node) -> bool {
         n.kind() == Self::EnumName.as_str() || n.kind() == Self::MessageName.as_str()
     }

src/parser/tree.rs

@@ -63,13 +63,14 @@ impl ParsedTree {
             .map(|n| n.utf8_text(content.as_ref()).expect("utf-8 parse error"))
     }
 
-    pub fn get_hoverable_node_text_at_position<'a>(&'a self, pos:&Position, content: &'a [u8]) -> Option<&'a str> {
-        if let Some(n) = self.get_node_at_position(pos) {
-            if NodeKind::is_builtin_field_type(&n) {
-                return Some(n.utf8_text(content).expect("utf8-parse error"))
-            }
-        }
+    pub fn get_hoverable_node_text_at_position<'a>(
+        &'a self,
+        pos: &Position,
+        content: &'a [u8],
+    ) -> Option<&'a str> {
+        let n = self.get_node_at_position(pos)?;
         self.get_actionable_node_text_at_position(pos, content)
+            .or(Some(n.kind()))
     }
 
     pub fn get_ancestor_nodes_at_position<'a>(&'a self, pos: &Position) -> Vec<Node<'a>> {

src/workspace/snapshots/protols__workspace__hover__test__workspace_test_hover-2.snap

@@ -1,5 +1,6 @@
 ---
 source: src/workspace/hover.rs
-expression: "state.hover(\"com.library\", \"Author.Address\")"
+expression: "state.hover(\"com.workspace\", \"int64\")"
+snapshot_kind: text
 ---
-- Address is a Address
+- "A 64-bit integer (varint encoding)\n\nValues of this type range between `-9223372036854775808` and `9223372036854775807`.\nBeware that negative values are encoded as ten bytes on the wire!"

src/workspace/snapshots/protols__workspace__hover__test__workspace_test_hover-2.snap.new

@@ -1,5 +1,6 @@
 ---
 source: src/workspace/hover.rs
-expression: "state.hover(\"com.library\", \"com.utility.Foobar.Baz\")"
+expression: "state.hover(\"com.workspace\", \"Author.Address\")"
+snapshot_kind: text
 ---
-- What is baz?
+- Address is a Address

src/workspace/snapshots/protols__workspace__hover__test__workspace_test_hover-3.snap

@@ -0,0 +1,6 @@
+---
+source: src/workspace/hover.rs
+expression: "state.hover(\"com.utility\", \"Baz\")"
+snapshot_kind: text
+---
+- What is baz?