Events are now Clone-able to prevent read races

Author: AndrewBurian

client.go

@@ -54,7 +54,7 @@ func (c *Client) Send(ev *Event) error {
 	if c.closed {
 		return io.ErrClosedPipe
 	}
-	c.events <- ev
+	c.events <- ev.Clone()
 	return nil
 }
 
@@ -65,7 +65,7 @@ func (c *Client) Shutdown() {
 }
 
 // Wait blocks and waits for the client to be shutdown.
-// Call this is http handler threads to prevent the server from closing
+// Call this in http handler threads to prevent the server from closing
 // the client connection.
 func (c *Client) Wait() {
 	c.waiter.Wait()

event.go

@@ -132,3 +132,15 @@ func (e *Event) String() string {
 	fullEvent, _ := ioutil.ReadAll(e)
 	return string(fullEvent)
 }
+
+// Clone returns a deep copy of the event
+func (e *Event) Clone() *Event {
+	clone := &Event{
+		id:    e.id,
+		event: e.event,
+		retry: e.retry,
+	}
+
+	clone.data = append(clone.data, e.data...)
+	return clone
+}

stream.go

@@ -84,7 +84,7 @@ func (s *Stream) Unsubscribe(topic string, c *Client) {
 // Publish sends the event to clients that have subscribed to the given topic.
 func (s *Stream) Publish(topic string, e *Event) {
 	s.listLock.RLock()
-	defer s.listLock.Unlock()
+	defer s.listLock.RUnlock()
 
 	for element := s.clients.Front(); element != nil; element = element.Next() {
 		cli := element.Value.(*registeredClient)