List remove bug

AndrewBurian · AndrewBurian · commit 84da5688b176 · 2017-09-06T01:33:55.000-07:00
diff --git a/stream.go b/stream.go
@@ -135,10 +135,12 @@ func (s *Stream) Shutdown() {
 	s.listLock.Lock()
 	defer s.listLock.Unlock()
 
-	for element := s.clients.Front(); element != nil; element = element.Next() {
+	for element := s.clients.Front(); element != nil; {
 		cli := element.Value.(*registeredClient)
 		cli.c.Shutdown()
+		next := element.Next()
 		s.clients.Remove(element)
+		element = next
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -135,10 +135,12 @@ func (s *Stream) Shutdown() {`
`135`	`135`	`s.listLock.Lock()`
`136`	`136`	`defer s.listLock.Unlock()`
`137`	`137`
`138`		`- for element := s.clients.Front(); element != nil; element = element.Next() {`
	`138`	`+ for element := s.clients.Front(); element != nil; {`
`139`	`139`	`cli := element.Value.(*registeredClient)`
`140`	`140`	`cli.c.Shutdown()`
	`141`	`+ next := element.Next()`
`141`	`142`	`s.clients.Remove(element)`
	`143`	`+ element = next`
`142`	`144`	`}`
`143`	`145`	`}`
`144`	`146`