Skip to content

Commit c8ce1f8

Browse files
Use BaseMenu<?> instead of Inventory
This is to Improve performance by allocating less each inventory recreation (unlike 1.1.3 and under)
1 parent b064c7d commit c8ce1f8

File tree

1 file changed

+14
-9
lines changed

1 file changed

+14
-9
lines changed

src/main/java/me/flame/menus/menu/fillers/BorderFiller.java

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import lombok.var;
44
import me.flame.menus.items.MenuItem;
55

6+
import me.flame.menus.menu.BaseMenu;
67
import org.bukkit.Material;
78
import org.bukkit.inventory.Inventory;
89
import org.bukkit.inventory.ItemStack;
@@ -11,35 +12,39 @@
1112

1213
@SuppressWarnings("unused")
1314
public final class BorderFiller {
14-
private final Inventory menu;
15-
private final int size;
15+
private final BaseMenu<?> menu;
1616

17-
BorderFiller(@NotNull Inventory menu) {
17+
BorderFiller(@NotNull BaseMenu<?> menu) {
1818
this.menu = menu;
19-
this.size = menu.getSize();
2019
}
2120

22-
public static BorderFiller from(@NotNull Inventory menu) {
21+
public static BorderFiller from(@NotNull BaseMenu<?> menu) {
2322
return new BorderFiller(menu);
2423
}
2524

2625
public void fillBorders(Material borderMaterial) {
27-
var itemStack = new ItemStack(borderMaterial);
26+
final int size = menu.getSize();
27+
final var itemStack = new ItemStack(borderMaterial);
28+
2829
for (int i = 0; i < size; i++) {
29-
if ((i < 9 || i >= size - 9) || (i % 9 == 0 || i % 9 == 8))
30-
menu.setItem(i, itemStack);
30+
if ((i < 9 || i >= size - 9) ||
31+
(i % 9 == 0 || i % 9 == 8)) menu.setItem(i, itemStack);
3132
}
3233
}
3334

3435
public void fillBorders(@NotNull MenuItem borderMaterial) {
35-
var itemStack = borderMaterial.getItemStack();
36+
final int size = menu.getSize();
37+
final var itemStack = borderMaterial.getItemStack();
38+
3639
for (int i = 0; i < size; i++) {
3740
if ((i < 9 || i >= size - 9) ||
3841
(i % 9 == 0 || i % 9 == 8)) menu.setItem(i, itemStack);
3942
}
4043
}
4144

4245
public void fillBorders(ItemStack itemStack) {
46+
final int size = menu.getSize();
47+
4348
for (int i = 0; i < size; i++) {
4449
if ((i < 9 || i >= size - 9) ||
4550
(i % 9 == 0 || i % 9 == 8)) menu.setItem(i, itemStack);

0 commit comments

Comments
 (0)