Integrate SkyValueRetriever with SerializationCheckingGraph.

This formalizes the distinction between serialization policies into a
DefaultPolicy and an AnaylsisPolicy that uses the SkyValueRetriever.

PiperOrigin-RevId: 671332658
Change-Id: I1c02e2c06e74328fa6a3d21dbd2fb056dea4d97a

Author: aoeui

src/main/java/com/google/devtools/build/lib/skyframe/serialization/FingerprintValueService.java

@@ -80,7 +80,7 @@ public FingerprintValueService(
   }
 
   /** Delegates to {@link FingerprintValueStore#put}. */
-  ListenableFuture<Void> put(ByteString fingerprint, byte[] serializedBytes) {
+  public ListenableFuture<Void> put(ByteString fingerprint, byte[] serializedBytes) {
     return store.put(fingerprint, serializedBytes);
   }
 

src/main/java/com/google/devtools/build/lib/skyframe/serialization/SerializationResult.java

@@ -53,7 +53,7 @@ public T getObject() {
     return object;
   }
 
-  static <T> SerializationResult<T> create(
+  public static <T> SerializationResult<T> create(
       T object, @Nullable ListenableFuture<Void> futureToBlockWritesOn) {
     return futureToBlockWritesOn != null
         ? new ObjectWithFuture<>(object, futureToBlockWritesOn)

src/test/java/com/google/devtools/build/lib/skyframe/BUILD

@@ -766,6 +766,7 @@ java_test(
         "//src/main/java/com/google/devtools/build/lib/skyframe:configured_target_key",
         "//src/main/java/com/google/devtools/build/lib/skyframe:skyframe_cluster",
         "//src/main/java/com/google/devtools/build/lib/skyframe/config",
+        "//src/main/java/com/google/devtools/build/lib/skyframe/serialization",
         "//src/main/java/com/google/devtools/build/lib/skyframe/toolchains:toolchain_context_key",
         "//src/main/java/com/google/devtools/build/lib/skyframe/toolchains:unloaded_toolchain_context",
         "//src/main/java/com/google/devtools/build/lib/skyframe/toolchains:unloaded_toolchain_context_impl",
@@ -777,6 +778,7 @@ java_test(
         "//third_party:jsr305",
         "//third_party:junit4",
         "//third_party:truth",
+        "//third_party/protobuf:protobuf_java",
     ],
 )
 

src/test/java/com/google/devtools/build/lib/skyframe/ConfigurationsForTargetsTest.java

@@ -45,6 +45,11 @@
 import com.google.devtools.build.lib.packages.Attribute;
 import com.google.devtools.build.lib.packages.Target;
 import com.google.devtools.build.lib.skyframe.config.BuildConfigurationKey;
+import com.google.devtools.build.lib.skyframe.serialization.AsyncDeserializationContext;
+import com.google.devtools.build.lib.skyframe.serialization.DeferredObjectCodec;
+import com.google.devtools.build.lib.skyframe.serialization.DeferredObjectCodec.DeferredValue;
+import com.google.devtools.build.lib.skyframe.serialization.SerializationContext;
+import com.google.devtools.build.lib.skyframe.serialization.SerializationException;
 import com.google.devtools.build.lib.skyframe.toolchains.ToolchainContextKey;
 import com.google.devtools.build.lib.skyframe.toolchains.UnloadedToolchainContext;
 import com.google.devtools.build.lib.skyframe.toolchains.UnloadedToolchainContextImpl;
@@ -57,6 +62,10 @@
 import com.google.devtools.build.skyframe.SkyFunctionName;
 import com.google.devtools.build.skyframe.SkyKey;
 import com.google.devtools.build.skyframe.SkyValue;
+import com.google.errorprone.annotations.Keep;
+import com.google.protobuf.CodedInputStream;
+import com.google.protobuf.CodedOutputStream;
+import java.io.IOException;
 import java.util.List;
 import java.util.Optional;
 import javax.annotation.Nullable;
@@ -136,6 +145,34 @@ public Label getLabel() {
         // Technically unused, but needed to mark this key as an ActionLookupKey.
         return arg.getLabel();
       }
+
+      /**
+       * A serialization-only codec to support test infrastructure.
+       *
+       * <p>Certain tests require the byte representation of keys without requiring those bytes to
+       * be deserialized.
+       */
+      @Keep
+      private static final class Codec extends DeferredObjectCodec<Key> {
+
+        @Override
+        public Class<Key> getEncodedClass() {
+          return Key.class;
+        }
+
+        @Override
+        public void serialize(SerializationContext context, Key key, CodedOutputStream codedOut)
+            throws SerializationException, IOException {
+          context.serialize(key.getLabel(), codedOut);
+          context.serialize(key.getConfigurationKey(), codedOut);
+        }
+
+        @Override
+        public DeferredValue<Key> deserializeDeferred(
+            AsyncDeserializationContext context, CodedInputStream codedIn) {
+          throw new IllegalStateException("not expected to be called");
+        }
+      }
     }
 
     /** Returns an {@link OrderedSetMultimap} representing the deps of given target. */