Remove native C++ linking code

Remove the flag and native code paths.
Remove testComputeKeyStatic that were covering only native code.
Move LinkBuildVariables into the LinkBuildVariablesTest. The only remaining use.
Substitute dummy-exec-requirement with supports-exec-requirement. Stalark actions filter exec requirements that don't start with a set of predefined strings.

PiperOrigin-RevId: 747737688
Change-Id: I425c0f7aec4205ef6027eb690840293d2f45fc04

Author: comius

src/main/java/com/google/devtools/build/lib/bazel/rules/cpp/BazelCppSemantics.java

@@ -34,7 +34,6 @@
 import com.google.devtools.build.lib.rules.cpp.CppCompileActionBuilder;
 import com.google.devtools.build.lib.rules.cpp.CppConfiguration;
 import com.google.devtools.build.lib.rules.cpp.CppFileTypes;
-import com.google.devtools.build.lib.rules.cpp.CppLinkActionBuilder;
 import com.google.devtools.build.lib.skyframe.serialization.autocodec.SerializationConstant;
 import net.starlark.java.eval.EvalException;
 import net.starlark.java.eval.Sequence;
@@ -120,10 +119,6 @@ public void finalizeCompileActionBuilder(
     }
   }
 
-  @Override
-  public void finalizeLinkActionBuilder(
-      CppConfiguration configuration, CppLinkActionBuilder actionBuilder) throws EvalException {}
-
   @Override
   public boolean allowIncludeScanning() {
     return true;

src/main/java/com/google/devtools/build/lib/rules/cpp/CcLinkingHelper.java

@@ -18,6 +18,7 @@
 import static com.google.devtools.build.lib.skyframe.BzlLoadValue.keyForBuild;
 
 import com.google.common.base.Ascii;
+import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.ImmutableSet;
@@ -38,6 +39,7 @@
 import com.google.devtools.build.lib.cmdline.Label;
 import com.google.devtools.build.lib.collect.nestedset.Depset;
 import com.google.devtools.build.lib.collect.nestedset.Depset.TypeException;
+import com.google.devtools.build.lib.collect.nestedset.NestedSet;
 import com.google.devtools.build.lib.packages.Attribute.ComputedDefault;
 import com.google.devtools.build.lib.packages.AttributeMap;
 import com.google.devtools.build.lib.packages.Info;
@@ -709,18 +711,71 @@ public Args getArgs(
         @Param(name = "supports_dynamic_linker")
       })
   public StarlarkList<LibraryInput> convertLibraryToLinkListToLinkerInputList(
-      Depset librariesToLink,
+      Depset librariesToLinkDepset,
       boolean staticMode,
       boolean forDynamicLibrary,
       boolean supportsDynamicLinker)
       throws TypeException {
-    return StarlarkList.copyOf(
-        Mutability.IMMUTABLE,
-        CcLinkingHelper.convertLibraryToLinkListToLinkerInputList(
-            librariesToLink.getSet(LibraryToLink.class),
-            staticMode,
-            forDynamicLibrary,
-            supportsDynamicLinker));
+    // LINT.IfChange
+    NestedSet<LibraryToLink> librariesToLink = librariesToLinkDepset.getSet(LibraryToLink.class);
+
+    ImmutableList.Builder<LibraryInput> libraryInputsBuilder = ImmutableList.builder();
+    for (LibraryToLink libraryToLink : librariesToLink.toList()) {
+      LibraryInput staticLibraryInput =
+          libraryToLink.getStaticLibrary() == null ? null : libraryToLink.getStaticLibraryInput();
+      LibraryInput picStaticLibraryInput =
+          libraryToLink.getPicStaticLibrary() == null
+              ? null
+              : libraryToLink.getPicStaticLibraryInput();
+      LibraryInput libraryInputToUse = null;
+      if (staticMode) {
+        if (forDynamicLibrary) {
+          if (picStaticLibraryInput != null) {
+            libraryInputToUse = picStaticLibraryInput;
+          } else if (staticLibraryInput != null) {
+            libraryInputToUse = staticLibraryInput;
+          }
+        } else {
+          if (staticLibraryInput != null) {
+            libraryInputToUse = staticLibraryInput;
+          } else if (picStaticLibraryInput != null) {
+            libraryInputToUse = picStaticLibraryInput;
+          }
+        }
+        if (libraryInputToUse == null) {
+          if (libraryToLink.getInterfaceLibrary() != null) {
+            libraryInputToUse = libraryToLink.getInterfaceLibraryInput();
+          } else if (libraryToLink.getDynamicLibrary() != null) {
+            libraryInputToUse = libraryToLink.getDynamicLibraryInput();
+          }
+        }
+      } else {
+        if (libraryToLink.getInterfaceLibrary() != null) {
+          libraryInputToUse = libraryToLink.getInterfaceLibraryInput();
+        } else if (libraryToLink.getDynamicLibrary() != null) {
+          libraryInputToUse = libraryToLink.getDynamicLibraryInput();
+        }
+        if (libraryInputToUse == null || !supportsDynamicLinker) {
+          if (forDynamicLibrary) {
+            if (picStaticLibraryInput != null) {
+              libraryInputToUse = picStaticLibraryInput;
+            } else if (staticLibraryInput != null) {
+              libraryInputToUse = staticLibraryInput;
+            }
+          } else {
+            if (staticLibraryInput != null) {
+              libraryInputToUse = staticLibraryInput;
+            } else if (picStaticLibraryInput != null) {
+              libraryInputToUse = picStaticLibraryInput;
+            }
+          }
+        }
+      }
+      Preconditions.checkNotNull(libraryInputToUse);
+      libraryInputsBuilder.add(libraryInputToUse);
+    }
+    return StarlarkList.copyOf(Mutability.IMMUTABLE, libraryInputsBuilder.build());
+    // LINT.ThenChange(//src/main/starlark/builtins_bzl/common/cc/link/convert_linker_inputs.bzl)
   }
 
   @StarlarkMethod(

src/main/java/com/google/devtools/build/lib/rules/cpp/CcModule.java

@@ -1020,13 +1020,4 @@ public boolean experimentalStarlarkCompiling(StarlarkThread thread) throws EvalE
     CcModule.checkPrivateStarlarkificationAllowlist(thread);
     return cppOptions.experimentalStarlarkCompiling;
   }
-
-  @StarlarkMethod(
-      name = "experimental_starlark_linking",
-      documented = false,
-      useStarlarkThread = true)
-  public boolean experimentalStarlarkLinking(StarlarkThread thread) throws EvalException {
-    CcModule.checkPrivateStarlarkificationAllowlist(thread);
-    return cppOptions.experimentalStarlarkLinking;
-  }
 }