[chore] optimize code style (apache#1984)

Signed-off-by: yuluo-yx <[email protected]>
Co-authored-by: tomsun28 <[email protected]>

Author: YuLuo

collector/src/main/java/org/apache/hertzbeat/collector/collect/common/cache/CacheIdentifier.java

@@ -21,7 +21,6 @@
 import lombok.Builder;
 import lombok.Data;
 
-
 /**
  * resource identifier in cache
  */

collector/src/main/java/org/apache/hertzbeat/collector/collect/common/cache/ConnectionCommonCache.java

@@ -17,7 +17,6 @@
 
 package org.apache.hertzbeat.collector.collect.common.cache;
 
-
 import com.google.common.util.concurrent.ThreadFactoryBuilder;
 import com.googlecode.concurrentlinkedhashmap.ConcurrentLinkedHashMap;
 import java.util.Map;

collector/src/main/java/org/apache/hertzbeat/collector/collect/common/ssh/CommonSshClient.java

@@ -26,7 +26,6 @@
 import org.apache.sshd.common.kex.BuiltinDHFactories;
 import org.apache.sshd.core.CoreModuleProperties;
 
-
 /**
  * common ssh pool client
  */

collector/src/main/java/org/apache/hertzbeat/collector/collect/database/JdbcSpiLoader.java

@@ -31,7 +31,6 @@
 @Order(value = Ordered.HIGHEST_PRECEDENCE)
 public class JdbcSpiLoader implements CommandLineRunner {
 
-
     @Override
     public void run(String... args) throws Exception {
         log.info("start load jdbc drivers");

collector/src/main/java/org/apache/hertzbeat/collector/collect/dns/DnsCollectImpl.java

@@ -90,7 +90,6 @@ public class DnsCollectImpl extends AbstractCollect {
     private static final String AUTHORITY_ROW_COUNT = "authorityRowCount";
     private static final String ADDITIONAL_ROW_COUNT = "additionalRowCount";
 
-
     @Override
     public void preCheck(Metrics metrics) throws IllegalArgumentException {
         // compatible with monitoring template configurations of older versions
@@ -207,7 +206,6 @@ private List<String> getSectionInfo(Message message, int section) {
         return infoList;
     }
 
-
     @Data
     @Builder
     @NoArgsConstructor

collector/src/main/java/org/apache/hertzbeat/collector/collect/http/HttpCollectImpl.java

@@ -87,7 +87,6 @@
 import org.w3c.dom.Node;
 import org.w3c.dom.NodeList;
 
-
 /**
  * http https collect
  */
@@ -102,7 +101,7 @@ public class HttpCollectImpl extends AbstractCollect {
     private final Set<Integer> defaultSuccessStatusCodes = Stream.of(HttpStatus.SC_OK, HttpStatus.SC_CREATED,
             HttpStatus.SC_ACCEPTED, HttpStatus.SC_MULTIPLE_CHOICES, HttpStatus.SC_MOVED_PERMANENTLY,
             HttpStatus.SC_MOVED_TEMPORARILY).collect(Collectors.toSet());
-    
+
     public HttpCollectImpl() {
     }
 
@@ -140,7 +139,7 @@ public void collect(CollectRep.MetricsData.Builder builder,
             }
             // todo This code converts an InputStream directly to a String. For large data in Prometheus exporters,
             // this could create large objects, potentially impacting JVM memory space significantly.
-            // Option 1: Parse using InputStream, but this requires significant code changes; 
+            // Option 1: Parse using InputStream, but this requires significant code changes;
             // Option 2: Manually trigger garbage collection, similar to how it's done in Dubbo for large inputs.
             String resp = EntityUtils.toString(response.getEntity(), StandardCharsets.UTF_8);
             if (StringUtils.hasText(resp)) {
@@ -149,22 +148,21 @@ public void collect(CollectRep.MetricsData.Builder builder,
             Long responseTime = System.currentTimeMillis() - startTime;
             String parseType = metrics.getHttp().getParseType();
             try {
-                if (DispatchConstants.PARSE_DEFAULT.equals(parseType)) {
-                    parseResponseByDefault(resp, metrics.getAliasFields(), metrics.getHttp(), builder, responseTime);
-                } else if (DispatchConstants.PARSE_JSON_PATH.equals(parseType)) {
-                    parseResponseByJsonPath(resp, metrics.getAliasFields(), metrics.getHttp(), builder, responseTime);
-                } else if (DispatchConstants.PARSE_PROM_QL.equalsIgnoreCase(parseType)) {
-                    parseResponseByPromQl(resp, metrics.getAliasFields(), metrics.getHttp(), builder);
-                } else if (DispatchConstants.PARSE_PROMETHEUS.equals(parseType)) {
-                    parseResponseByPrometheusExporter(resp, metrics.getAliasFields(), builder);
-                } else if (DispatchConstants.PARSE_XML_PATH.equals(parseType)) {
-                    parseResponseByXmlPath(resp, metrics.getAliasFields(), metrics.getHttp(), builder);
-                } else if (DispatchConstants.PARSE_WEBSITE.equals(parseType)) {
-                    parseResponseByWebsite(resp, metrics.getAliasFields(), metrics.getHttp(), builder, responseTime);
-                } else if (DispatchConstants.PARSE_SITE_MAP.equals(parseType)) {
-                    parseResponseBySiteMap(resp, metrics.getAliasFields(), builder);
-                } else {
-                    parseResponseByDefault(resp, metrics.getAliasFields(), metrics.getHttp(), builder, responseTime);
+                switch (parseType) {
+                    case DispatchConstants.PARSE_JSON_PATH ->
+                            parseResponseByJsonPath(resp, metrics.getAliasFields(), metrics.getHttp(), builder, responseTime);
+                    case DispatchConstants.PARSE_PROM_QL ->
+                            parseResponseByPromQl(resp, metrics.getAliasFields(), metrics.getHttp(), builder);
+                    case DispatchConstants.PARSE_PROMETHEUS ->
+                            parseResponseByPrometheusExporter(resp, metrics.getAliasFields(), builder);
+                    case DispatchConstants.PARSE_XML_PATH ->
+                            parseResponseByXmlPath(resp, metrics.getAliasFields(), metrics.getHttp(), builder);
+                    case DispatchConstants.PARSE_WEBSITE ->
+                            parseResponseByWebsite(resp, metrics.getAliasFields(), metrics.getHttp(), builder, responseTime);
+                    case DispatchConstants.PARSE_SITE_MAP ->
+                            parseResponseBySiteMap(resp, metrics.getAliasFields(), builder);
+                    default ->
+                            parseResponseByDefault(resp, metrics.getAliasFields(), metrics.getHttp(), builder, responseTime);
                 }
             } catch (Exception e) {
                 log.info("parse error: {}.", e.getMessage(), e);
@@ -202,12 +200,12 @@ public void collect(CollectRep.MetricsData.Builder builder,
             }
         }
     }
-    
+
     @Override
     public String supportProtocol() {
         return DispatchConstants.PROTOCOL_HTTP;
     }
-    
+
     private void parseResponseByWebsite(String resp, List<String> aliasFields, HttpProtocol http,
                                         CollectRep.MetricsData.Builder builder, Long responseTime) {
         CollectRep.ValueRow.Builder valueRowBuilder = CollectRep.ValueRow.newBuilder();
@@ -223,7 +221,7 @@ private void parseResponseByWebsite(String resp, List<String> aliasFields, HttpP
         }
         builder.addValues(valueRowBuilder.build());
     }
-    
+
     private void parseResponseBySiteMap(String resp, List<String> aliasFields,
                                         CollectRep.MetricsData.Builder builder) {
         List<String> siteUrls = new LinkedList<>();
@@ -306,11 +304,11 @@ private void parseResponseBySiteMap(String resp, List<String> aliasFields,
             builder.addValues(valueRowBuilder.build());
         }
     }
-    
+
     private void parseResponseByXmlPath(String resp, List<String> aliasFields, HttpProtocol http,
                                         CollectRep.MetricsData.Builder builder) {
     }
-    
+
     private void parseResponseByJsonPath(String resp, List<String> aliasFields, HttpProtocol http,
                                          CollectRep.MetricsData.Builder builder, Long responseTime) {
         List<Object> results = JsonPathParser.parseContentWithJsonPath(resp, http.getParseScript());
@@ -362,15 +360,15 @@ private void parseResponseByJsonPath(String resp, List<String> aliasFields, Http
             }
         }
     }
-    
+
     private void parseResponseByPromQl(String resp, List<String> aliasFields, HttpProtocol http,
                                        CollectRep.MetricsData.Builder builder) {
         AbstractPrometheusParse prometheusParser = PrometheusParseCreater.getPrometheusParse();
         prometheusParser.handle(resp, aliasFields, http, builder);
     }
-    
+
     private static final Map<Long, ExporterParser> EXPORTER_PARSER_TABLE = new ConcurrentHashMap<>();
-    
+
     private void parseResponseByPrometheusExporter(String resp, List<String> aliasFields,
                                                    CollectRep.MetricsData.Builder builder) {
         if (!EXPORTER_PARSER_TABLE.containsKey(builder.getId())) {
@@ -405,7 +403,7 @@ private void parseResponseByPrometheusExporter(String resp, List<String> aliasFi
             }
         }
     }
-    
+
     private void parseResponseByDefault(String resp, List<String> aliasFields, HttpProtocol http,
                                         CollectRep.MetricsData.Builder builder, Long responseTime) {
         JsonElement element = JsonParser.parseString(resp);
@@ -419,7 +417,7 @@ private void parseResponseByDefault(String resp, List<String> aliasFields, HttpP
             getValueFromJson(aliasFields, builder, responseTime, element, keywordNum);
         }
     }
-    
+
     private void getValueFromJson(List<String> aliasFields, CollectRep.MetricsData.Builder builder, Long responseTime, JsonElement element, int keywordNum) {
         if (element.isJsonObject()) {
             JsonObject object = element.getAsJsonObject();
@@ -442,7 +440,7 @@ private void getValueFromJson(List<String> aliasFields, CollectRep.MetricsData.B
             builder.addValues(valueRowBuilder.build());
         }
     }
-    
+
     /**
      * create httpContext
      * @param httpProtocol http protocol
@@ -467,7 +465,7 @@ public HttpContext createHttpContext(HttpProtocol httpProtocol) {
         }
         return null;
     }
-    
+
     /**
      * create http request
      * @param httpProtocol http params
@@ -531,7 +529,7 @@ public HttpUriRequest createHttpRequest(HttpProtocol httpProtocol) {
         } else {
             requestBuilder.addHeader(HttpHeaders.ACCEPT, "*/*");
         }
-        
+
         if (httpProtocol.getAuthorization() != null) {
             HttpProtocol.Authorization authorization = httpProtocol.getAuthorization();
             if (DispatchConstants.BEARER_TOKEN.equalsIgnoreCase(authorization.getType())) {
@@ -546,16 +544,16 @@ public HttpUriRequest createHttpRequest(HttpProtocol httpProtocol) {
                 }
             }
         }
-        
+
         // if it has payload, would override post params
         if (StringUtils.hasLength(httpProtocol.getPayload())) {
             requestBuilder.setEntity(new StringEntity(httpProtocol.getPayload(), StandardCharsets.UTF_8));
         }
-        
+
         // uri
         String uri = CollectUtil.replaceUriSpecialChar(httpProtocol.getUrl());
         if (IpDomainUtil.isHasSchema(httpProtocol.getHost())) {
-            
+
             requestBuilder.setUri(httpProtocol.getHost() + ":" + httpProtocol.getPort() + uri);
         } else {
             String ipAddressType = IpDomainUtil.checkIpAddressType(httpProtocol.getHost());
@@ -569,7 +567,7 @@ public HttpUriRequest createHttpRequest(HttpProtocol httpProtocol) {
                 requestBuilder.setUri(CollectorConstants.HTTP_HEADER + baseUri);
             }
         }
-        
+
         // custom timeout
         int timeout = CollectUtil.getTimeout(httpProtocol.getTimeout(), 0);
         if (timeout > 0) {
@@ -582,7 +580,7 @@ public HttpUriRequest createHttpRequest(HttpProtocol httpProtocol) {
         }
         return requestBuilder.build();
     }
-    
+
     private boolean checkSuccessInvoke(Metrics metrics, int statusCode) {
         List<String> successCodes = metrics.getHttp().getSuccessCodes();
         Set<Integer> successCodeSet = successCodes != null ? successCodes.stream().map(code -> {

collector/src/main/java/org/apache/hertzbeat/collector/collect/http/promethus/exporter/ExporterParser.java

@@ -81,23 +81,25 @@ private void parseLine(Map<String, MetricFamily> metricMap, StrBuffer buffer) {
         buffer.skipBlankTabs();
         if (buffer.isEmpty()) return;
         switch (buffer.charAt(0)) {
-            case '#':
+            case '#' -> {
                 buffer.read();
                 this.currentMetricFamily = null;
                 this.parseComment(metricMap, buffer);
-                break;
-            case ENTER:
-                break;
-            default:
+            }
+            case ENTER -> {}
+            default -> {
                 this.currentBucket = null;
                 this.currentQuantile = null;
                 this.parseMetric(buffer);
+            }
         }
     }
 
     private void parseComment(Map<String, MetricFamily> metricMap, StrBuffer buffer) {
         buffer.skipBlankTabs();
-        if (buffer.isEmpty()) return;
+        if (buffer.isEmpty()) {
+            return;
+        }
         String token = this.readTokenUnitWhitespace(buffer);
         if (EOF.equals(token)) {
             return;
@@ -160,7 +162,9 @@ private void parseMetric(StrBuffer buffer) {
 
     private void readLabels(MetricFamily.Metric metric, StrBuffer buffer) {
         buffer.skipBlankTabs();
-        if (buffer.isEmpty()) return;
+        if (buffer.isEmpty()) {
+            return;
+        }
         metric.setLabelPair(new ArrayList<>());
         if (buffer.charAt(0) == LEFT_CURLY_BRACKET) {
             buffer.read();
@@ -172,11 +176,15 @@ private void readLabels(MetricFamily.Metric metric, StrBuffer buffer) {
 
     private void startReadLabelName(MetricFamily.Metric metric, StrBuffer buffer) {
         buffer.skipBlankTabs();
-        if (buffer.isEmpty()) return;
+        if (buffer.isEmpty()) {
+            return;
+        }
         if (buffer.charAt(0) == RIGHT_CURLY_BRACKET) {
             buffer.read();
             buffer.skipBlankTabs();
-            if (buffer.isEmpty()) return;
+            if (buffer.isEmpty()) {
+                return;
+            }
             this.readLabelValue(metric, new MetricFamily.Label(), buffer);
             return;
         }
@@ -194,7 +202,9 @@ private void startReadLabelName(MetricFamily.Metric metric, StrBuffer buffer) {
 
     private void startReadLabelValue(MetricFamily.Metric metric, MetricFamily.Label label, StrBuffer buffer) {
         buffer.skipBlankTabs();
-        if (buffer.isEmpty()) return;
+        if (buffer.isEmpty()) {
+            return;
+        }
         char c = buffer.read();
         if (c != QUOTES) {
             throw new ParseException("expected '\"' at start of label value, line: " + buffer.toStr());
@@ -211,7 +221,9 @@ private void startReadLabelValue(MetricFamily.Metric metric, MetricFamily.Label
         } else {
             metric.getLabelPair().add(label);
         }
-        if (buffer.isEmpty()) return;
+        if (buffer.isEmpty()) {
+            return;
+        }
         c = buffer.read();
         switch (c) {
             case COMMA -> this.startReadLabelName(metric, buffer);
@@ -378,15 +390,10 @@ private String readTokenAsLabelValue(StrBuffer buffer) {
                 escaped = false;
             } else {
                 switch (c) {
-                    case QUOTES:
-                        return builder.toString();
-                    case ENTER:
-                        throw new ParseException("parse label value error, next line");
-                    case '\\':
-                        escaped = true;
-                        break;
-                    default:
-                        builder.append(c);
+                    case QUOTES -> { return builder.toString(); }
+                    case ENTER -> throw new ParseException("parse label value error, next line");
+                    case '\\' -> escaped = true;
+                    default -> builder.append(c);
                 }
             }
         }

collector/src/main/java/org/apache/hertzbeat/collector/collect/http/promethus/exporter/MetricFamily.java

@@ -23,7 +23,7 @@
 import lombok.ToString;
 
 /**
- *
+ * MetricFamily.
  */
 @Data
 @ToString

collector/src/main/java/org/apache/hertzbeat/collector/collect/nebulagraph/NebulaGraphCollectImpl.java

@@ -47,7 +47,6 @@
 import org.apache.http.protocol.HttpContext;
 import org.apache.http.util.EntityUtils;
 
-
 /**
  *  NebulaGraph collect
  */

collector/src/main/java/org/apache/hertzbeat/collector/collect/nginx/NginxCollectImpl.java

@@ -54,7 +54,6 @@
 import org.apache.http.protocol.HttpContext;
 import org.apache.http.util.EntityUtils;
 
-
 /**
  * nginx collect
  */