Refactor inner callback conditional

Author: matt-welch

tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java

@@ -101,19 +101,11 @@ void start(String[] args) throws IOException {
                 record = new ProducerRecord<>(config.topicName, payload);
 
                 long sendStartMs = System.currentTimeMillis();
-                if (config.warmupRecords > 0) {
-                    if (i < config.warmupRecords) {
-                        cb = new PerfCallback(sendStartMs, payload.length, stats);
-                    } else {
-                        if (i == config.warmupRecords) {
-                            steadyStateStats = new Stats(config.numRecords - config.warmupRecords, DEFAULT_REPORTING_INTERVAL_MS, config.warmupRecords > 0);
-                            stats.steadyStateActive = true;
-                        }
-                        cb = new PerfCallback(sendStartMs, payload.length, stats, steadyStateStats);
-                    }
-                } else {
-                    cb = new PerfCallback(sendStartMs, payload.length, stats);
+                if ( config.warmupRecords > 0 && i == config.warmupRecords ) {
+                    steadyStateStats = new Stats(config.numRecords - config.warmupRecords, DEFAULT_REPORTING_INTERVAL_MS, config.warmupRecords > 0);
+                    stats.steadyStateActive = true;
                 }
+                cb = new PerfCallback(sendStartMs, payload.length, stats, steadyStateStats);
                 producer.send(record, cb);
 
                 currentTransactionSize++;
@@ -173,7 +165,6 @@ KafkaProducer<byte[], byte[]> createKafkaProducer(Properties props) {
     }
 
     Callback cb;
-
     Stats stats;
     Stats steadyStateStats;
 
@@ -510,13 +501,6 @@ static final class PerfCallback implements Callback {
         private final Stats stats;
         private final Stats steadyStateStats;
 
-        public PerfCallback(long start, int bytes, Stats stats) {
-            this.start = start;
-            this.stats = stats;
-            this.steadyStateStats = null;
-            this.bytes = bytes;
-        }
-
         public PerfCallback(long start, int bytes, Stats stats, Stats steadyStateStats) {
             this.start = start;
             this.stats = stats;