Skip to content

Commit 80b209d

Browse files
MINOR: remove unused parameter from KafkaMetadataLog (apache#19458)
1. Remove unused parameter from KafkaMetadataLog. 2. Give Utils.closeQuietly a meaningful name when closing reader. Reviewers: TengYao Chi <[email protected]>, Ken Huang <[email protected]>, Jhen-Yung Hsu <[email protected]>, Chia-Ping Tsai <[email protected]> --------- Co-authored-by: TengYao Chi <[email protected]>
1 parent b18f00b commit 80b209d

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

core/src/main/scala/kafka/raft/KafkaMetadataLog.scala

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -553,7 +553,7 @@ final class KafkaMetadataLog private (
553553
if (expiredSnapshots.nonEmpty) {
554554
scheduler.scheduleOnce(
555555
"delete-snapshot-files",
556-
() => KafkaMetadataLog.deleteSnapshotFiles(log.dir.toPath, expiredSnapshots, this),
556+
() => KafkaMetadataLog.deleteSnapshotFiles(log.dir.toPath, expiredSnapshots),
557557
config.deleteDelayMillis
558558
)
559559
}
@@ -698,12 +698,10 @@ object KafkaMetadataLog extends Logging {
698698

699699
private def deleteSnapshotFiles(
700700
logDir: Path,
701-
expiredSnapshots: mutable.TreeMap[OffsetAndEpoch, Option[FileRawSnapshotReader]],
702-
logging: Logging
703-
): Unit = {
701+
expiredSnapshots: mutable.TreeMap[OffsetAndEpoch, Option[FileRawSnapshotReader]]): Unit = {
704702
expiredSnapshots.foreach { case (snapshotId, snapshotReader) =>
705703
snapshotReader.foreach { reader =>
706-
Utils.closeQuietly(reader, "reader")
704+
Utils.closeQuietly(reader, "FileRawSnapshotReader")
707705
}
708706
Snapshots.deleteIfExists(logDir, snapshotId)
709707
}

0 commit comments

Comments
 (0)