feature: @putout/plugin-github: set-node-versions: improve

Author: coderaiser

.github/workflows/nodejs-pr.yml

@@ -12,6 +12,7 @@ jobs:
           - 20.x
           - 22.x
           - 24.x
+          - 25.x
     steps:
       - uses: actions/checkout@v4
       - uses: oven-sh/setup-bun@v1

.github/workflows/nodejs.yml

@@ -13,6 +13,7 @@ jobs:
           - 20.x
           - 22.x
           - 24.x
+          - 25.x
     steps:
       - uses: actions/checkout@v4
       - uses: oven-sh/setup-bun@v1

packages/plugin-github/lib/set-node-versions/fixture/overlap-fix.js

@@ -0,0 +1,17 @@
+__putout_processor_yaml({
+    "jobs": {
+        "build": {
+            "runs-on": "ubuntu-latest",
+            "strategy": {
+                "matrix": {
+                    "node-version": [
+                        "20.x",
+                        "22.x",
+                        "24.x",
+                        "25.x"
+                    ]
+                }
+            }
+        }
+    }
+});

packages/plugin-github/lib/set-node-versions/fixture/overlap.js

@@ -0,0 +1,12 @@
+__putout_processor_yaml({
+    "jobs": {
+        "build": {
+            "runs-on": "ubuntu-latest",
+            "strategy": {
+                "matrix": {
+                    "node-version": ["20.x", "24.x"]
+                }
+            }
+        }
+    }
+});

packages/plugin-github/lib/set-node-versions/index.js

@@ -38,6 +38,7 @@ export const traverse = ({push, options}) => ({
         const {__object} = getTemplateValues(path, __yaml);
 
         for (const nodeVersionPath of traverseProperties(__object, 'node-version')) {
+            let is = false;
             const valueStr = nodeVersionPath.get('value').toString();
 
             const versions = parse(valueStr);
@@ -54,12 +55,15 @@ export const traverse = ({push, options}) => ({
                 for (const currentVersion of versions) {
                     const [current] = currentVersion.split('.');
 
-                    if (current === nodeVersion)
-                        return;
+                    if (current !== nodeVersion) {
+                        is = true;
+                        break;
+                    }
                 }
             }
 
-            push(nodeVersionPath.get('value'));
+            if (is)
+                push(nodeVersionPath.get('value'));
         }
     },
 });

packages/plugin-github/lib/set-node-versions/index.spec.js

@@ -32,6 +32,16 @@ test('plugin-github: set node versions: no transform: no-version', (t) => {
     t.end();
 });
 
+test('plugin-github: set node versions: transform: overlap', (t) => {
+    t.transform('overlap');
+    t.end();
+});
+
+test('plugin-github: set node versions: report: overlap', (t) => {
+    t.report('overlap', ['Use latest version of node']);
+    t.end();
+});
+
 test('plugin-github: set node versions: no report with options: intersects', (t) => {
     t.noReportWithOptions('intersects', {
         versions: ['24.x'],