feature: @putout/plugin-remove-useless-arguments: unused: add

Author: coderaiser

packages/operator-match-files/lib/match-files.js

@@ -43,11 +43,11 @@ module.exports.matchFiles = (options) => {
     };
 };
 
-function fix(inputFile, {dirPath, mainPath, matchInputFilename, outputFilename, matchedJS, matchedAST, options}) {
+function fix(inputFile, {dirPath, matchInputFilename, outputFilename, matchedJS, matchedAST, options}) {
     transform(matchedAST, matchedJS, options);
 
     const matchedJSON = magicPrint(outputFilename, matchedAST);
-    const outputFile = getOutputFile(mainPath, {
+    const outputFile = getOutputFile({
         dirPath,
         matchInputFilename,
         outputFilename,
@@ -80,7 +80,6 @@ const createScan = ({files, exclude}) => (mainPath, {push, progress, options}) =
                 continue;
 
             allFiles.push({
-                mainPath,
                 dirPath,
                 matchInputFilename,
                 rawOptions,
@@ -101,7 +100,6 @@ const createScan = ({files, exclude}) => (mainPath, {push, progress, options}) =
             inputFilename,
             outputFilename,
             rawOptions,
-            mainPath,
         } = current;
 
         progress({
@@ -122,7 +120,6 @@ const createScan = ({files, exclude}) => (mainPath, {push, progress, options}) =
 
         push(inputFile, {
             dirPath,
-            mainPath,
             matchInputFilename,
 
             outputFilename,
@@ -171,7 +168,7 @@ function check(files) {
     }
 }
 
-function getOutputFile(path, {dirPath, matchInputFilename, outputFilename, inputFile}) {
+function getOutputFile({dirPath, matchInputFilename, outputFilename, inputFile}) {
     if (matchInputFilename === outputFilename)
         return inputFile;
 

packages/plugin-cloudcmd/lib/convert-load-dir-to-change-dir/index.js

@@ -13,7 +13,7 @@ module.exports.replace = () => ({
     'CloudCmd.loadDir({path})': 'CloudCmd.changeDir(path)',
     'CloudCmd.loadDir({path: __a})': 'CloudCmd.changeDir(__a)',
     'CloudCmd.loadDir(__object)': (vars, path) => {
-        convert(vars, path);
+        convert(path);
         path.node.callee.property.name = 'changeDir';
 
         return path;
@@ -27,21 +27,21 @@ module.exports.replace = () => ({
         return 'changeDir(path)';
     },
     'loadDir(__object)': (vars, path) => {
-        convert(vars, path);
+        convert(path);
         renameAll(path);
 
         return path;
     },
     'changeDir({path: __a})': 'changeDir(__a)',
     'changeDir({path})': 'changeDir(path)',
     'changeDir(__object)': (vars, path) => {
-        convert(vars, path);
+        convert(path);
 
         return path;
     },
 });
 
-function convert(vars, path) {
+function convert(path) {
     const args = path.node.arguments;
     const [obj] = path.get('arguments');
     const properties = obj.get('properties');

packages/plugin-optional-chaining/lib/get-logical.js

@@ -11,7 +11,7 @@ module.exports.getLogical = (path, {assign} = {}) => {
     const logical = [member];
 
     while (++i < n) {
-        member += compute(member, list[i]);
+        member += compute(list[i]);
         logical.push(member);
     }
 
@@ -23,7 +23,7 @@ module.exports.getLogical = (path, {assign} = {}) => {
     return `${fullLogical} && (${logical.at(-1)} = __a)`;
 };
 
-function compute(member, current) {
+function compute(current) {
     if (current[0] === '(')
         return current;
 

packages/plugin-remove-useless-arguments/README.md

@@ -11,14 +11,22 @@
 npm i @putout/plugin-remove-useless-arguments
 ```
 
-## Rule
+## Rules
+
+- ✅ [arguments](#arguments);
+- ✅ [destructuring](#destructring);
+- ✅ [method](#method);
+- ✅ [unused](#unused);
+
+## Config
 
 ```json
 {
     "rules": {
         "remove-useless-arguments/arguments": "on",
         "remove-useless-arguments/destructuring": "on",
-        "remove-useless-arguments/method": "on"
+        "remove-useless-arguments/method": "on",
+        "remove-useless-arguments/unused": "on"
     }
 }
 ```
@@ -92,6 +100,30 @@ class Parser {
 }
 ```
 
+### unused
+
+Check it out in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/f6bf5e069cfb1328fe7418c501e265cc/388ab2266babe84f77c1f82687f5ed44873e8651).
+
+### ❌ Example of incorrect code
+
+```js
+member += compute(member, list[i]);
+
+function compute(member, current) {
+    return String(current);
+}
+```
+
+### ✅ Example of correct code
+
+```js
+member += compute(list[i]);
+
+function compute(current) {
+    return String(current);
+}
+```
+
 ## License
 
 MIT

…rguments/lib/remove-useless-arguments.js …in-remove-useless-arguments/lib/index.jspackages/plugin-remove-useless-arguments/lib/remove-useless-arguments.js renamed to packages/plugin-remove-useless-arguments/lib/index.js packages/plugin-remove-useless-arguments/lib/remove-useless-arguments.js renamed to packages/plugin-remove-useless-arguments/lib/index.js

@@ -3,9 +3,11 @@
 const argumentsRule = require('./arguments');
 const destructuring = require('./destructuring');
 const method = require('./method');
+const unused = require('./unused');
 
 module.exports.rules = {
     arguments: argumentsRule,
     destructuring,
     method,
+    unused,
 };

packages/plugin-remove-useless-arguments/lib/unused/fixture/anonymous-fix.js

@@ -0,0 +1,13 @@
+const outputFile = getOutputFile({
+    dirPath,
+    outputFilename,
+});
+
+const outputFile2 = getOutputFile({
+    dirPath,
+    matchInputFilename,
+});
+
+const getOutputFile = function({dirPath, outputFile}) {
+    return createFile(dirPath);
+};

packages/plugin-remove-useless-arguments/lib/unused/fixture/anonymous.js

@@ -0,0 +1,13 @@
+const outputFile = getOutputFile(mainPath, {
+    dirPath,
+    outputFilename,
+});
+
+const outputFile2 = getOutputFile(mainPath, {
+    dirPath,
+    matchInputFilename,
+});
+
+const getOutputFile = function(path, {dirPath, outputFile}) {
+    return createFile(dirPath);
+}

packages/plugin-remove-useless-arguments/lib/unused/fixture/const-fix.js

@@ -0,0 +1,10 @@
+const outputFile = getOutputFile({
+    dirPath,
+    matchInputFilename,
+    outputFilename,
+    inputFile,
+});
+
+const getOutputFile = ({dirPath, matchInputFilename, outputFilename, inputFile}) => {
+    return createFile(dirPath, outputFilename);
+};

packages/plugin-remove-useless-arguments/lib/unused/fixture/const.js

@@ -0,0 +1,10 @@
+const outputFile = getOutputFile(mainPath, {
+    dirPath,
+    matchInputFilename,
+    outputFilename,
+    inputFile,
+});
+
+const getOutputFile = (path, {dirPath, matchInputFilename, outputFilename, inputFile}) => {
+    return createFile(dirPath, outputFilename);
+}

packages/plugin-remove-useless-arguments/lib/unused/fixture/couple-fix.js

@@ -0,0 +1,13 @@
+const outputFile = getOutputFile({
+    dirPath,
+    outputFilename,
+});
+
+const outputFile2 = getOutputFile({
+    dirPath,
+    matchInputFilename,
+});
+
+const getOutputFile = ({dirPath, outputFile}) => {
+    return createFile(dirPath);
+};