feature: @putout/plugin-minify: convert-if-to-logical: improve

Author: coderaiser

packages/plugin-minify/lib/convert-if-to-logical/fixture/if-no-ternary.js

@@ -0,0 +1,3 @@
+const now = new Date();
+now.setDate(1);
+now.getMonth() < 11 ? (now.setMonth(now.getMonth() + 1)) : (now.setMonth(0), now.setFullYear(now.getFullYear() + 1));

packages/plugin-minify/lib/convert-if-to-logical/index.js

@@ -84,7 +84,7 @@ export const replace = () => ({
         if (!__b.body.length && isBlockStatement(__c))
             return LogicalExpression('&&', UnaryExpression('!', __a), __c.body[0].expression);
 
-        if (__b.body.length === 1)
+        if (__b.body.length === 1 && __c.body.length === 1)
             return ConditionalExpression(__a, __b.body[0].expression, __c.body[0].expression);
 
         const expressionsB = parseExpressions(__b);

packages/plugin-minify/lib/convert-if-to-logical/index.spec.js

@@ -52,3 +52,8 @@ test('plugin-minify: convert-if-to-logical: transform: nested-or', (t) => {
     t.transform('nested-or');
     t.end();
 });
+
+test('plugin-minify: convert-if-to-logical: no transform: if-no-ternary', (t) => {
+    t.noTransform('if-no-ternary');
+    t.end();
+});

packages/plugin-minify/test/fixture/if-no-ternary-fix.js

@@ -0,0 +1,3 @@
+var a = new Date();
+a.setDate(1);
+a.getMonth() < 11 ? (a.setMonth(a.getMonth() + 1)) : (a.setMonth(0), a.setFullYear(a.getFullYear() + 1));

packages/plugin-minify/test/fixture/if-no-ternary.js

@@ -0,0 +1,10 @@
+const now = new Date();
+now.setDate(1);
+if (now.getMonth() < 11) {
+  // increase month by 1 if it is not currently December
+  now.setMonth(now.getMonth() + 1);
+} else {
+  // else, consider year rollover and go to next January
+  now.setMonth(0);
+  now.setFullYear(now.getFullYear() + 1);
+}

packages/plugin-minify/test/minify.js

@@ -105,6 +105,11 @@ test('plugin-minify: transform: if', (t) => {
     t.end();
 });
 
+test('plugin-minify: transform: if-no-ternary', (t) => {
+    t.transform('if-no-ternary');
+    t.end();
+});
+
 test('plugin-minify: transform: merge-loops', (t) => {
     t.transform('merge-loops');
     t.end();