feature: @putout/plugin-eslint: remove-spread-from-create-eslint-config: add

Author: coderaiser

packages/plugin-eslint/README.md

@@ -39,6 +39,7 @@ npm i @putout/plugin-eslint -D
 - ✅ [remove-useless-slice](#remove-useless-slice);
 - ✅ [remove-useless-properties](#remove-useless-properties);
 - ✅ [remove-parser-options](#remove-parser-options);
+- ✅ [remove-spread-from-create-eslint-config](#remove-spread-from-create-eslint-config);
 
 ## Config
 
@@ -68,7 +69,8 @@ npm i @putout/plugin-eslint -D
         "eslint/remove-overrides-with-empty-rules": "on",
         "eslint/remove-useless-slice": "on",
         "eslint/remove-useless-properties": "on",
-        "eslint/remove-parser-options": "on"
+        "eslint/remove-parser-options": "on",
+        "eslint/remove-spread-from-create-eslint-config": "on"
     }
 }
 ```
@@ -492,6 +494,25 @@ const ruleTester = new RuleTester({
 });
 ```
 
+## remove-spread-from-create-eslint-config
+
+Checkout in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/1e10683f0f1fbb6f5b3dd23a940b316c/6274c36dfa69a98e640e2ee1cdd5bfcbf52d36ee).
+
+### ❌ Example of incorrect code
+
+```js
+export default createESLintConfig([
+    safeAlign,
+    ...matchToFlat(match),
+]);
+```
+
+### ✅ Example of correct code
+
+```js
+export default createESLintConfig([safeAlign, matchToFlat(match)]);
+```
+
 ## convert-node-to-n
 
 `eslint-plugin-node` [is no longer supported](https://github.com/mysticatea/eslint-plugin-node/issues/300). Better to use [`eslint-plugin-n`](https://github.com/weiran-zsd/eslint-plugin-node).

packages/plugin-eslint/lib/index.js

@@ -22,6 +22,7 @@ const removeUselessProperties = require('./remove-useless-properties');
 const applyIgnores = require('./apply-ignores');
 const applyCreateEslintConfig = require('./apply-create-eslint-config');
 const removeParserOptions = require('./remove-parser-options');
+const removeSpreadFromCreateEslintConfig = require('./remove-spread-from-create-eslint-config');
 
 module.exports.rules = {
     'add-putout': addPutout,
@@ -46,4 +47,5 @@ module.exports.rules = {
     'apply-ignores': ['off', applyIgnores],
     'apply-create-eslint-config': applyCreateEslintConfig,
     'remove-parser-options': removeParserOptions,
+    'remove-spread-from-create-eslint-config': removeSpreadFromCreateEslintConfig,
 };

packages/plugin-eslint/lib/remove-spread-from-create-eslint-config/fixture/remove-spread-from-create-eslint-config-fix.js

@@ -0,0 +1 @@
+export default createESLintConfig([safeAlign, matchToFlat(match)]);

packages/plugin-eslint/lib/remove-spread-from-create-eslint-config/fixture/remove-spread-from-create-eslint-config.js

@@ -0,0 +1,4 @@
+export default createESLintConfig([
+    safeAlign,
+    ...matchToFlat(match),
+]);

packages/plugin-eslint/lib/remove-spread-from-create-eslint-config/index.js

@@ -0,0 +1,20 @@
+'use strict';
+
+const {types, operator} = require('putout');
+const {isSpreadElement} = types;
+const {replaceWith} = operator;
+
+module.exports.report = () => `Avoid spread ('...') in 'createEslintConfig'`;
+
+module.exports.fix = (path) => {
+    replaceWith(path, path.node.argument);
+};
+
+module.exports.traverse = ({push}) => ({
+    'createESLintConfig(__array)'(path) {
+        for (const argPath of path.get('arguments.0.elements')) {
+            if (isSpreadElement(argPath))
+                push(argPath);
+        }
+    },
+});

packages/plugin-eslint/lib/remove-spread-from-create-eslint-config/index.spec.js

@@ -0,0 +1,20 @@
+'use strict';
+
+const {createTest} = require('@putout/test');
+const plugin = require('.');
+
+const test = createTest(__dirname, {
+    plugins: [
+        ['remove-spread-from-create-eslint-config', plugin],
+    ],
+});
+
+test('eslint: remove-spread-from-create-eslint-config: report', (t) => {
+    t.report('remove-spread-from-create-eslint-config', `Avoid spread ('...') in 'createEslintConfig'`);
+    t.end();
+});
+
+test('eslint: remove-spread-from-create-eslint-config: transform', (t) => {
+    t.transform('remove-spread-from-create-eslint-config');
+    t.end();
+});

packages/plugin-eslint/test/eslint.js

@@ -123,3 +123,8 @@ test('plugin-eslint: transform: remove-parser-options', (t) => {
     t.transform('remove-parser-options');
     t.end();
 });
+
+test('plugin-eslint: transform: remove-spread-from-create-eslint-config', (t) => {
+    t.transform('remove-spread-from-create-eslint-config');
+    t.end();
+});

packages/plugin-eslint/test/fixture/apply-match-to-flat-fix.js

@@ -11,7 +11,4 @@ export const match = {
         'node/no-extraneous-import': 'off',
     },
 };
-export default createESLintConfig([
-    safeAlign,
-    ...matchToFlat(match),
-]);
+export default createESLintConfig([safeAlign, matchToFlat(match)]);

packages/plugin-eslint/test/fixture/remove-spread-from-create-eslint-config-fix.js

@@ -0,0 +1,5 @@
+import {createESLintConfig} from '@putout/eslint-flat';
+import {safeAlign} from 'eslint-plugin-putout/config';
+import {matchToFlat} from '@putout/eslint-flat';
+
+export default createESLintConfig([safeAlign, matchToFlat(match)]);

packages/plugin-eslint/test/fixture/remove-spread-from-create-eslint-config.js

@@ -0,0 +1,4 @@
+export default createESLintConfig([
+    safeAlign,
+    ...matchToFlat(match),
+]);