fix: @putout/plugin-remove-unreachable-code: report count

Author: coderaiser

packages/plugin-remove-unreachable-code/lib/remove-unreachable-code.js

@@ -13,38 +13,39 @@ const not = (fn) => (...a) => !fn(...a);
 
 module.exports.report = () => `Unreachable code`;
 
-module.exports.fix = (path) => {
-    remove(path);
+module.exports.fix = ({siblings}) => {
+    siblings.map(remove);
 };
 
 module.exports.traverse = ({push}) => ({
     'ReturnStatement|ThrowStatement'(path) {
-        while (path.parentPath?.isBlockStatement()) {
-            const siblings = path.getAllNextSiblings();
-            const {argument} = path.node;
+        let nextPath = path;
+        
+        while (nextPath.parentPath?.isBlockStatement()) {
+            const siblings = nextPath
+                .getAllNextSiblings()
+                .filter(not(isFunctionDeclaration));
+            
+            const prevPath = nextPath;
 
-            path = path.parentPath;
+            nextPath = nextPath.parentPath;
+            
+            if (!siblings.length)
+                continue;
+            
+            const {argument} = path.node;
 
             if (checkFirstSibling({argument, siblings}))
                 continue;
 
-            processSiblings({
-                push,
+            push({
+                path: prevPath,
                 siblings,
             });
         }
     },
 });
 
-const processSiblings = ({push, siblings}) => {
-    if (!siblings.length)
-        return;
-    
-    siblings
-        .filter(not(isFunctionDeclaration))
-        .map(push);
-};
-
 function checkFirstSibling({argument, siblings}) {
     if (argument)
         return false;

packages/plugin-remove-unreachable-code/test/fixture/backtrack-normal.js

@@ -6,6 +6,8 @@ function fun3(f) {
         return x3 * 2;
     }
     return 3;
+    return 5;
+    return 7;
 }
 
-fun3(x3);
+fun3(x3);

packages/plugin-remove-unreachable-code/test/remove-unreachable-code.js

@@ -44,6 +44,11 @@ test('plugin-remove-unreachable-code: transform: backtrack-normal', (t) => {
     t.end();
 });
 
+test('plugin-remove-unreachable-code: report: backtrack-normal', (t) => {
+    t.report('backtrack-normal', ['Unreachable code', 'Unreachable code', 'Unreachable code']);
+    t.end();
+});
+
 test('plugin-remove-unreachable-code: no report: backtrack-func', (t) => {
     t.noReport('backtrack-func');
     t.end();