feature: @putout/plugin-declare-before-reference: variables/apply-declarations-order

Author: coderaiser

packages/plugin-declare-before-reference/lib/declare-before-reference.js

@@ -94,6 +94,9 @@ export const traverse = ({push}) => ({
                 if (compareAny(getName(referenceParentPath), getKeys(path)))
                     break;
 
+                if (path.key < referencePath.parentPath.parentPath.key)
+                    break;
+                
                 const [own, pathLoc] = getLoc(path);
                 const [referenceOwn, referenceLoc] = getLoc(referencePath);
 

packages/plugin-declare-before-reference/test/declare-before-reference.js

@@ -12,7 +12,8 @@ import * as args from '@putout/plugin-arguments';
 import * as destructuring from '@putout/plugin-destructuring';
 import * as declare from '../lib/declare-before-reference.js';
 
-const mergeDestructuringProperties = destructuring.rules['merge-properties'];
+const mergeProperties = destructuring.rules['merge-properties'];
+const applyDeclarationsOrder = variables.rules['apply-declarations-order'];
 const removeUselessVariables = variables.rules['remove-useless'];
 const reuseDuplicateInit = variables.rules['reuse-duplicate-init'];
 
@@ -188,7 +189,15 @@ test('plugin-merge-destructuring-properties: transform: merge-destructuring-prop
     t.transform('merge-destructuring-properties', {
         'printer/declare': printer.rules.declare,
         'nodejs/declare-after-require': nodejs.rules['declare-after-require'],
-        'merge-destructuring-properties': mergeDestructuringProperties,
+        'destructuring/merge-properties': mergeProperties,
+    });
+    t.end();
+});
+
+test('plugin-merge-destructuring-properties: no report after transform: apply-declarations-order', (t) => {
+    t.noReportAfterTransform('apply-declarations-order', {
+        'variables/apply-declarations-order': applyDeclarationsOrder,
+        'variables/reuse-duplicate-init': reuseDuplicateInit,
     });
     t.end();
 });

packages/plugin-declare-before-reference/test/fixture/apply-declarations-order-fix.js

@@ -0,0 +1,2 @@
+const process = require('node:process');
+const {env} = require('node:process');

packages/plugin-declare-before-reference/test/fixture/apply-declarations-order.js

@@ -0,0 +1,2 @@
+const {env} = require('node:process');
+const process = require('node:process');

packages/plugin-declare-before-reference/test/fixture/destructuring-fix.js

@@ -1,7 +1,7 @@
 module.exports.fix = ({path, lefts, right, merged}) => {
     if (merged) {
         const rightPath = path.get('right');
-        const {right, left} = rightPath.node;
         const {object, property} = left;
+        const {right, left} = rightPath.node;
     }
 };

packages/plugin-declare-before-reference/test/fixture/merge-destructuring-properties-fix.js

@@ -1,12 +1,12 @@
 'use strict';
 
+const {types} = require('@putout/babel');
 const {
     isForOf,
     isCoupleLines,
     exists,
 } = require('../../is');
 
-const {types} = require('@putout/babel');
 const {
     isObjectExpression,
     isIdentifier,

packages/plugin-declare-before-reference/test/fixture/putout-fix.js

@@ -1,3 +1,4 @@
 const {types, operator} = require('putout');
+
 const {remove} = operator;
 remove(path);