feature: @putout/plugin-for-of: remove-useless-variables: exclude nested ObjectPatterns

Author: coderaiser

packages/plugin-for-of/lib/remove-useless-variables/fixture/nested.js

@@ -0,0 +1,10 @@
+for (const place of places) {
+    const {
+        rule,
+        message,
+        position: {
+            line,
+            column,
+        },
+    } = place;
+}

packages/plugin-for-of/lib/remove-useless-variables/index.js

@@ -3,8 +3,11 @@
 const {types, operator} = require('putout');
 
 const {replaceWith, remove} = operator;
+const {
+    isAssignmentPattern,
+    isObjectPattern,
+} = types;
 
-const {isAssignmentPattern} = types;
 const isToManyProperties = (a, {maxProperties}) => a.isObjectPattern() && a.node.properties.length > maxProperties;
 const isAssignment = (a) => isAssignmentPattern(a.value);
 
@@ -24,9 +27,7 @@ module.exports.traverse = ({push, options}) => ({
             return;
 
         const {scope, node} = varPath;
-        
         const {name} = node;
-        
         const {references, referencePaths} = scope.bindings[name];
 
         if (references !== 1)
@@ -48,6 +49,9 @@ module.exports.traverse = ({push, options}) => ({
         if (isToManyProperties(idPath, {maxProperties}))
             return;
 
+        if (isNested(idPath))
+            return;
+        
         const {properties} = idPath.node;
 
         if (idPath.isObjectPattern() && properties.find(isAssignment))
@@ -59,3 +63,15 @@ module.exports.traverse = ({push, options}) => ({
         });
     },
 });
+
+function isNested(path) {
+    if (!path.isObjectPattern())
+        return false;
+    
+    for (const {value} of path.node.properties) {
+        if (isObjectPattern(value))
+            return true;
+    }
+    
+    return false;
+}

packages/plugin-for-of/lib/remove-useless-variables/index.spec.js

@@ -50,6 +50,11 @@ test('putout: plugin-for-of: remove-useless-variables no transform: assignment',
     t.end();
 });
 
+test('putout: plugin-for-of: remove-useless-variables no transform: nested', (t) => {
+    t.noReport('nested');
+    t.end();
+});
+
 test('putout: plugin-for-of: remove-useless-variables transform with: array-from', (t) => {
     t.transform('array-from', {
         'remove-useless-array-from': removeUselessArrayFrom,